[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2022-04-24 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527058#comment-17527058 ] Hudson commented on MNG-7010: - Build failed in Jenkins: Maven » Maven TLP » maven » MNG-7457 #2 See

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386887#comment-17386887 ] Hudson commented on MNG-7010: - Build failed in Jenkins: Maven » Maven TLP » maven » master #207 See

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386886#comment-17386886 ] Hudson commented on MNG-7010: - Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #57 See

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386876#comment-17386876 ] Michael Osipov commented on MNG-7010: - Created MNGSITE-456. [~rfscholte], I will create a new issue

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-24 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386681#comment-17386681 ] Robert Scholte commented on MNG-7010: - It is not needed anymore to set JAVA_HOME. If it is set,

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386547#comment-17386547 ] Michael Osipov commented on MNG-7010: - So you'd change {noformat} 147 echo "The JAVA_HOME environment

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-23 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386545#comment-17386545 ] Robert Scholte commented on MNG-7010: - We should improve the message: if JAVA_HOME is set, but

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386542#comment-17386542 ] Michael Osipov commented on MNG-7010: - I do agree with [~rfscholte], therefore I would skim the PR and

[jira] [Commented] (MNG-7010) Omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem

2021-07-23 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386539#comment-17386539 ] Robert Scholte commented on MNG-7010: - Actually, I think we should drop the line completely. To run

[jira] [Commented] (MNG-7010) omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem.

2021-07-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386144#comment-17386144 ] Elliotte Rusty Harold commented on MNG-7010: Looks like that would work. I don't know if

[jira] [Commented] (MNG-7010) omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem.

2021-07-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385771#comment-17385771 ] Michael Osipov commented on MNG-7010: - Makes sense.. Do you agree with the testing for {{javac}}? >

[jira] [Commented] (MNG-7010) omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem.

2021-07-22 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385769#comment-17385769 ] Elliotte Rusty Harold commented on MNG-7010: Yes, that makes sense. Speciifcally: 1. Warn "The

[jira] [Commented] (MNG-7010) omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem.

2021-07-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385765#comment-17385765 ] Michael Osipov commented on MNG-7010: - Wen can test whether {{JAVA_HOME}} contains {{javac}} and then

[jira] [Commented] (MNG-7010) omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem.

2020-11-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229935#comment-17229935 ] Michael Osipov commented on MNG-7010: - [~elharo], let's just remove it. > omit "NB: JAVA_HOME should

[jira] [Commented] (MNG-7010) omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem.

2020-11-11 Thread Mark Thomas (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229821#comment-17229821 ] Mark Thomas commented on MNG-7010: -- Yes, "NB" is an abbreviation of "Nota bene". The note was added in

[jira] [Commented] (MNG-7010) omit "NB: JAVA_HOME should point to a JDK not a JRE" except when that is the problem.

2020-11-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226555#comment-17226555 ] Michael Osipov commented on MNG-7010: - Frankly, I took this from Tomcat startup script. Maybe [~markt]