[ http://jira.codehaus.org/browse/MCHANGELOG-11?page=all ]
Brett Porter updated MCHANGELOG-11: ----------------------------------- Assign To: Edwin Punzalan Fix Version: 2.0 is this a duplicate? > ViewCVS links are incorrect. > ----------------------------- > > Key: MCHANGELOG-11 > URL: http://jira.codehaus.org/browse/MCHANGELOG-11 > Project: Maven 2.x Changelog Plugin > Type: Bug > Versions: 2.0 > Reporter: Martin Johannesen > Assignee: Edwin Punzalan > Fix For: 2.0 > > > My ViewCVS links are incorrect . Example of link: > SCM Url not inherited and ending with /: > Incorrect: http://........./viewcvs/viewcvs.cgi/common/om.xml > Correct: http://........./viewcvs/viewcvs.cgi/common/pom.xml > SCM Url inherited and ending with /: > Incorrect: http://........./viewcvs/viewcvs.cgi/common/oioom.xml > Correct: http://........./viewcvs/viewcvs.cgi/common/oio/pom.xml > The problem is in org.apache.maven.changelog.ChangeLogReport: > {{ > private String getAbsolutePath( final String base, final String target ) > { > > ............ > return absPath + target.substring( 1 ); > } > }} > It always cuts of the first character of the target, maybe because it assumes > that the first character is a /. > The next problem is that when using an inherited scm url, it doesnt get a "/" > appended to the absPath, so a solution to this problem could be: > {{ > private String getAbsolutePath( final String base, final String target ) > { > > ............ > if(!absPath.endsWith("/")) absPath+="/"; > String newTarget=target; > if(newTarget.startsWith("/")) newTarget=newTarget.substring(1); > return absPath + newTarget; > } > }} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira