Re: [PR] [MASSEMBLY-1008] Wrong use of dependency scopes [maven-assembly-plugin]

2023-11-15 Thread via GitHub
cstamas commented on code in PR #166: URL: https://github.com/apache/maven-assembly-plugin/pull/166#discussion_r1394207292 ## pom.xml: ## @@ -71,8 +71,8 @@ under the License. 8 2.2.0 -3.2.5 -1.7.5 +3.9.5 Review Comment: No ,is irrelevant -- Thi

Re: [PR] [MASSEMBLY-1008] Wrong use of dependency scopes [maven-assembly-plugin]

2023-11-15 Thread via GitHub
slawekjaranowski commented on code in PR #166: URL: https://github.com/apache/maven-assembly-plugin/pull/166#discussion_r1394176097 ## pom.xml: ## @@ -71,8 +71,8 @@ under the License. 8 2.2.0 -3.2.5 -1.7.5 +3.9.5 Review Comment: Do we need such upd