Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-18 Thread via GitHub
rmannibucau commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1769109005 @gnodet I'm mixed about it since it assumes everything is wired in plugins conf and plugins/extensions don't read any other property so not sure it is really better today, maybe let's w

Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-18 Thread via GitHub
gnodet commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1769106593 > Well any later phase is wrong cause then it depends if the interpolation will be reprocessed or not so think it is the least bad compromise to work immediately but agree on your point, the

Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-18 Thread via GitHub
rmannibucau commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1769070264 Well any later phase is wrong cause then it depends if the interpolation will be reprocessed or not so think it is the least bad compromise to work immediately but agree on your point,

Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-18 Thread via GitHub
gnodet commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1768992902 This really looks like a temporary hack for agents to being supported by Surefire... It only saves the following declaration: ``` maven-dependency-plugin

Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-15 Thread via GitHub
bmarwell commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1763364152 Thank you for the explanation, that makes excellent documentation! 😃 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-15 Thread via GitHub
rmannibucau commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1763304992 If it clashes we have other troubles and using another sep looks wrong in placeholders to me. Im also very hesitant to add another plugin in any lifecycle cause: 1. It is speci

Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-14 Thread via GitHub
bmarwell commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1763191586 I forgot this file doesn't exist anymore. https://github.com/apache/maven/blob/maven-3.3.8/maven-core/src/main/resources/META-INF/plexus/default-bindings.xml But I think you g

Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]

2023-10-14 Thread via GitHub
bmarwell commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1763190531 So the idea is that a given group and artifact ID gets resolved to the following property: `${project.dependencies.com.bar.dummy-agent}` Only disadvantage of your solution: I