[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829347#comment-17829347 ] ASF GitHub Bot commented on MNG-8081: - mbenson commented on PR #1446: URL:

Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2011019881 > > That was what I originally considered, but I quickly came to the opinion that as soon as we did it that way, someone would want to use some such property to match a Java version, etc.,

[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829299#comment-17829299 ] ASF GitHub Bot commented on MNG-8081: - gnodet commented on PR #1446: URL:

Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
gnodet commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2010621686 > That was what I originally considered, but I quickly came to the opinion that as soon as we did it that way, someone would want to use some such property to match a Java version, etc.,

[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829298#comment-17829298 ] ASF GitHub Bot commented on MNG-8081: - mbenson commented on PR #1446: URL:

Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2010580914 That was what I originally considered, but I quickly came to the opinion that as soon as we did it that way, someone would want to use some such property to match a Java version, etc., and

[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829296#comment-17829296 ] ASF GitHub Bot commented on MNG-8081: - gnodet commented on PR #1446: URL:

Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
gnodet commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2010577651 > > @mbenson well a mini language got rejected multiple times on the list - this is where this sh solution comes from. ultimately I'm for having a multipass filtering to filter as much as

[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829293#comment-17829293 ] ASF GitHub Bot commented on MNG-8081: - gnodet commented on PR #1446: URL:

Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
gnodet commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2010564585 > @mbenson well a mini language got rejected multiple times on the list - this is where this sh solution comes from. ultimately I'm for having a multipass filtering to filter as much as we

[PR] Fix typos in metadata documentation [maven-site]

2024-03-20 Thread via GitHub
pkwarren opened a new pull request, #505: URL: https://github.com/apache/maven-site/pull/505 Update 'versionining' to 'versioning' in the metadata documentation. Confirmed that this matches the .xsd schema. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (MWRAPPER-108) mvnw script fails silently when download fails

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829276#comment-17829276 ] ASF GitHub Bot commented on MWRAPPER-108: - bdemers commented on PR #98: URL:

Re: [PR] [MWRAPPER-108] - only-mvnw add error checking when download or unpacking fails [maven-wrapper]

2024-03-20 Thread via GitHub
bdemers commented on PR #98: URL: https://github.com/apache/maven-wrapper/pull/98#issuecomment-2010326792 I just ran into the same problem while testing out the wrapper and `mvnd` I didn't set the version correctly I had a silent death. This patch seemed to work fine and produced a

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread Matthew Jason Benson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829273#comment-17829273 ] Matthew Jason Benson commented on MNG-5235: --- New issue created for user/system properties; does

[jira] [Commented] (MNG-8081) default profile activation should consider available system and user properties

2024-03-20 Thread Matthew Jason Benson (Jira)
[ https://issues.apache.org/jira/browse/MNG-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829272#comment-17829272 ] Matthew Jason Benson commented on MNG-8081: --- Maven 4.x impl @

[jira] [Created] (MNG-8081) default profile activation should consider available system and user properties

2024-03-20 Thread Matthew Jason Benson (Jira)
Matthew Jason Benson created MNG-8081: - Summary: default profile activation should consider available system and user properties Key: MNG-8081 URL: https://issues.apache.org/jira/browse/MNG-8081

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829271#comment-17829271 ] ASF GitHub Bot commented on MNG-5235: - rmannibucau commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
rmannibucau commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2010282601 @mbenson well a mini language got rejected multiple times on the list - this is where this sh solution comes from. ultimately I'm for having a multipass filtering to filter as much as

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829268#comment-17829268 ] ASF GitHub Bot commented on MNG-5235: - mbenson commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2010279301 @gnodet I agree that MNG-5235 has a different ask than this PR addresses. I will open a new issue and rewrite this commit message accordingly. -- This is an automated message from the

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829266#comment-17829266 ] ASF GitHub Bot commented on MNG-5235: - mbenson commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2010277373 @rmannibucau I think it's okay if different users want to interact with Maven in different ways. Your preference does not invalidate mine. -- This is an automated message from the Apache

Re: [PR] Remove references to old versions of the plugin [maven-remote-resources-plugin]

2024-03-20 Thread via GitHub
elharo merged PR #55: URL: https://github.com/apache/maven-remote-resources-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829255#comment-17829255 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on code in PR #140:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin commented on code in PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1532514596 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829254#comment-17829254 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on code in PR #140:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin commented on code in PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1532514596 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829252#comment-17829252 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- michael-o commented on code in PR

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
michael-o commented on code in PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1532512828 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829236#comment-17829236 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on code in PR #140:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin commented on code in PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1532397290 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829234#comment-17829234 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on code in PR #140:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin commented on code in PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1532398438 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829232#comment-17829232 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on code in PR #140:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin commented on code in PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1532397290 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829230#comment-17829230 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- michael-o commented on code in PR

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
michael-o commented on code in PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#discussion_r1532392121 ## doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfigurator.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829225#comment-17829225 ] ASF GitHub Bot commented on MSITE-1000: --- kwin opened a new pull request, #177: URL:

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829223#comment-17829223 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin closed pull request #126:

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829224#comment-17829224 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on PR #126: URL:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of Doxia parser [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin commented on PR #126: URL: https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-2009951837 Superseded by #140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of Doxia parser [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin closed pull request #126: [DOXIASITETOOLS-324] Allow configuration of Doxia parser URL: https://github.com/apache/maven-doxia-sitetools/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829222#comment-17829222 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin commented on PR #140: URL:

Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]

2024-03-20 Thread via GitHub
kwin commented on PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140#issuecomment-2009950266 This is the leaner alternative to #126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829221#comment-17829221 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin opened a new pull request,

[jira] [Created] (MASSEMBLY-1026) Assembly plugin 3.7.0 handles scopes wrongly

2024-03-20 Thread Filipe Roque (Jira)
Filipe Roque created MASSEMBLY-1026: --- Summary: Assembly plugin 3.7.0 handles scopes wrongly Key: MASSEMBLY-1026 URL: https://issues.apache.org/jira/browse/MASSEMBLY-1026 Project: Maven Assembly

[jira] [Updated] (MASSEMBLY-1026) Assembly plugin 3.7.0 handles scopes wrongly

2024-03-20 Thread Filipe Roque (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filipe Roque updated MASSEMBLY-1026: Description: maven-assembly-plugin 3.7.0 is not consistent with maven-jar-plugin and

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829214#comment-17829214 ] ASF GitHub Bot commented on MNG-5235: - rmannibucau commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
rmannibucau commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2009880595 @mbenson see it the other way, `if (magic) -DdoItSlow` then you can use this new fake variable accordingly. You can migrate but the easiest is a custom base image IMHO which does this

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829209#comment-17829209 ] ASF GitHub Bot commented on MNG-5235: - mbenson commented on code in PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on code in PR #1446: URL: https://github.com/apache/maven/pull/1446#discussion_r1532281361 ## maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileSelector.java: ## @@ -76,16 +85,24 @@ public List getActiveProfilesV4( @Override

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829207#comment-17829207 ] ASF GitHub Bot commented on MNG-5235: - mbenson commented on code in PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on code in PR #1446: URL: https://github.com/apache/maven/pull/1446#discussion_r1532281361 ## maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileSelector.java: ## @@ -76,16 +85,24 @@ public List getActiveProfilesV4( @Override

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829204#comment-17829204 ] ASF GitHub Bot commented on MNG-5235: - gnodet commented on code in PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
gnodet commented on code in PR #1446: URL: https://github.com/apache/maven/pull/1446#discussion_r1532256262 ## maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileSelector.java: ## @@ -76,16 +85,24 @@ public List getActiveProfilesV4( @Override

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828968#comment-17828968 ] ASF GitHub Bot commented on MNG-5235: - gnodet commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
gnodet commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2009712804 > Hmm, my approach was, e.g.: > > ``` > > > env.CI_COMMIT_REF_NAME > ${env.CI_DEFAULT_BRANCH} > > > ``` > > ...which seems fine to me 路

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828965#comment-17828965 ] ASF GitHub Bot commented on MNG-5235: - mbenson commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2009690607 @rmannibucau but your pipeline has to know/hope that the project has such a `shared-dev` profile. For my purposes my pipeline wouldn't know what such a profile might be named, but my org's

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828959#comment-17828959 ] ASF GitHub Bot commented on MNG-5235: - rmannibucau commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
rmannibucau commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2009673949 personally i do it in the sh part of the yaml: case ${DEPLOY_ENV:-dev} in dev) export SCRIPTS_DEPLOY_DEPLOYMENT_PROFILES="-Pshared-dev

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828957#comment-17828957 ] ASF GitHub Bot commented on MNG-5235: - mbenson commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2009669185 Hmm, my approach was, e.g.: ``` CI_COMMIT_REF_NAME ${env.CI_DEFAULT_BRANCH} ``` ...which seems fine to me 路 -- This is an automated

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828955#comment-17828955 ] ASF GitHub Bot commented on MNG-5235: - gnodet commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
gnodet commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2009654648 > My use case is to be able to compare environment variables. Specifically, with GitLab CI, if `CI_COMMIT_REF_NAME` has the same value as `CI_DEFAULT_BRANCH`, then I want to enable stricter

[PR] Bump org.apache.jena:jena-core from 3.17.0 to 5.0.0 [maven-doap-plugin]

2024-03-20 Thread via GitHub
dependabot[bot] opened a new pull request, #23: URL: https://github.com/apache/maven-doap-plugin/pull/23 [![Dependabot compatibility

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828932#comment-17828932 ] ASF GitHub Bot commented on MNG-5235: - mbenson commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
mbenson commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2009399551 My use case is to be able to compare environment variables. Specifically, with GitLab CI, if `CI_COMMIT_REF_NAME` has the same value as `CI_DEFAULT_BRANCH`, then I want to enable stricter

[jira] [Commented] (MJAR-62) Build-Jdk in Manifest.mf does not reflect which compiler version actually compiled the classes in the jar

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAR-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828935#comment-17828935 ] ASF GitHub Bot commented on MJAR-62: elharo commented on code in PR #73: URL:

Re: [PR] [MJAR-62] Set Build-Jdk according to used toolchain [maven-jar-plugin]

2024-03-20 Thread via GitHub
elharo commented on code in PR #73: URL: https://github.com/apache/maven-jar-plugin/pull/73#discussion_r1531982231 ## src/main/java/org/apache/maven/plugins/jar/ToolchainsJdkSpecification.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (MASSEMBLY-883) Transitive dependencies with scope provided are included with jar-with-dependencies descriptor

2024-03-20 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828662#comment-17828662 ] Slawomir Jaranowski commented on MASSEMBLY-883: --- [~stoty] thanks for testing ... so I

[jira] [Closed] (MASSEMBLY-883) Transitive dependencies with scope provided are included with jar-with-dependencies descriptor

2024-03-20 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MASSEMBLY-883. - Fix Version/s: 3.1.1 Resolution: Fixed > Transitive dependencies with

[jira] [Updated] (MJMOD-33) Remove duplicate reporting section

2024-03-20 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJMOD-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MJMOD-33: - Fix Version/s: 3.0.0 (was: next-release) > Remove duplicate

[jira] [Closed] (MJMOD-33) Remove duplicate reporting section

2024-03-20 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJMOD-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MJMOD-33. Fix Version/s: next-release Resolution: Fixed > Remove duplicate reporting section >

[jira] [Commented] (MJMOD-33) Remove duplicate reporting section

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJMOD-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828661#comment-17828661 ] ASF GitHub Bot commented on MJMOD-33: - slawekjaranowski merged PR #25: URL:

Re: [PR] [MJMOD-33] Remove duplicate reporting section [maven-jmod-plugin]

2024-03-20 Thread via GitHub
slawekjaranowski merged PR #25: URL: https://github.com/apache/maven-jmod-plugin/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-8076) when jar in local repository from other repository id, should not reject but check if it is also available in current repository id context

2024-03-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828655#comment-17828655 ] Tamas Cservenak commented on MNG-8076: -- FYI, failed attempt is NOT in {{_remote.repositories}} file,

[jira] [Commented] (MNG-8076) when jar in local repository from other repository id, should not reject but check if it is also available in current repository id context

2024-03-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828653#comment-17828653 ] Tamas Cservenak commented on MNG-8076: -- So, you had in local repo: * recorded "failed" attempt

[jira] [Commented] (MNG-8076) when jar in local repository from other repository id, should not reject but check if it is also available in current repository id context

2024-03-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828652#comment-17828652 ] Tamas Cservenak commented on MNG-8076: -- Huh, I think the key is here: "... was not found in

[jira] [Updated] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-03-20 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MTOOLCHAINS-49: --- Fix Version/s: 3.2.0 > Automatic discovery of JDK toolchains >

[jira] [Closed] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-03-20 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MTOOLCHAINS-49. -- Resolution: Fixed > Automatic discovery of JDK toolchains >

[jira] [Updated] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-03-20 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MTOOLCHAINS-49: --- Description: Add mojos to: * display a human readable list of discovered JDK

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828650#comment-17828650 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet merged PR #14: URL:

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-03-20 Thread via GitHub
gnodet merged PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MRESOLVER-512) Scope Manager

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828649#comment-17828649 ] ASF GitHub Bot commented on MRESOLVER-512: -- gnodet commented on PR #445: URL:

Re: [PR] [MRESOLVER-512] ScopeManager [maven-resolver]

2024-03-20 Thread via GitHub
gnodet commented on PR #445: URL: https://github.com/apache/maven-resolver/pull/445#issuecomment-2008977378 @cstamas The whole `SystemScopeHandler` needs has to be removed imho, it's superseded by the `ScopeManager`. -- This is an automated message from the Apache Git Service. To respond

[PR] switch from png+imagemap to svg [maven-plugin-tools]

2024-03-20 Thread via GitHub
hboutemy opened a new pull request, #271: URL: https://github.com/apache/maven-plugin-tools/pull/271 same test as https://github.com/apache/maven-site/pull/504 result published to https://maven.apache.org/plugin-tools-archives/plugin-tools-LATEST/ vs initial png

[jira] [Commented] (MNG-8076) when jar in local repository from other repository id, should not reject but check if it is also available in current repository id context

2024-03-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828640#comment-17828640 ] Tamas Cservenak commented on MNG-8076: -- [~hboutemy] I think we are wrong. Created reproducer that

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828629#comment-17828629 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR #14: URL:

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-03-20 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1531598055 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Comment Edited] (MSITE-1000) Allow parametrisation of Doxia parser per file

2024-03-20 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828482#comment-17828482 ] Konrad Windszus edited comment on MSITE-1000 at 3/20/24 7:16 AM: - I think

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828628#comment-17828628 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- olamy commented on code in PR #14: URL:

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-03-20 Thread via GitHub
olamy commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1531596969 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (MNG-5235) Profiles not activated according to property values

2024-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828625#comment-17828625 ] ASF GitHub Bot commented on MNG-5235: - gnodet commented on PR #1446: URL:

Re: [PR] [MNG-5235] interpolate available properties during default profile selection (Maven 4.x) [maven]

2024-03-20 Thread via GitHub
gnodet commented on PR #1446: URL: https://github.com/apache/maven/pull/1446#issuecomment-2008911652 The code looks good. However, what's the real use case for that ? It seems actually unrelated to MNG-5235, in a sense that the behaviour on this project is not modified by this PR.