[ https://issues.apache.org/jira/browse/MESOS-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617270#comment-15617270 ]
Anand Mazumdar edited comment on MESOS-6507 at 10/29/16 2:53 AM: ----------------------------------------------------------------- It was an oversight on my part, had forgotten backporting Ben's UUID patches. This should unblock the 1.0.2 release. {noformat} commit 9e0f9505bae40a5f803d9a3eebfebe62287fbe91 Author: Benjamin Mahler <bmah...@apache.org> Date: Tue Sep 20 14:17:30 2016 -0700 Updated scheduler library to handle UUID parsing error. Previously this would have thrown an exception. Review: https://reviews.apache.org/r/52099 commit 4e4d058ea3c012b2e6d4bbed58ef7fbaea5b60fb Author: Benjamin Mahler <bmah...@apache.org> Date: Tue Sep 20 14:14:39 2016 -0700 Updated UUID::fromString to not throw an exception on error. The exception from the string_generator needs to be caught so that we can surface a Try to the caller. Review: https://reviews.apache.org/r/52098 {noformat} was (Author: anandmazumdar): It was an oversight on my part, had forgotten backporting Ben's UUID patches. This should unblock the 1.0.2 release. However, we still need to fix the test flakiness on HEAD. I would update the JIRA with the flaky test log. {noformat} commit 9e0f9505bae40a5f803d9a3eebfebe62287fbe91 Author: Benjamin Mahler <bmah...@apache.org> Date: Tue Sep 20 14:17:30 2016 -0700 Updated scheduler library to handle UUID parsing error. Previously this would have thrown an exception. Review: https://reviews.apache.org/r/52099 commit 4e4d058ea3c012b2e6d4bbed58ef7fbaea5b60fb Author: Benjamin Mahler <bmah...@apache.org> Date: Tue Sep 20 14:14:39 2016 -0700 Updated UUID::fromString to not throw an exception on error. The exception from the string_generator needs to be caught so that we can surface a Try to the caller. Review: https://reviews.apache.org/r/52098 {noformat} > 'DockerContainerizerTest.ROOT_DOCKER_SkipRecoverMalformedUUID' fails > consistently. > ---------------------------------------------------------------------------------- > > Key: MESOS-6507 > URL: https://issues.apache.org/jira/browse/MESOS-6507 > Project: Mesos > Issue Type: Bug > Components: docker, test > Reporter: Gilbert Song > Priority: Blocker > Labels: failure > > Here is the log: > {noformat} > [23:09:24] : [Step 10/10] [ RUN ] > DockerContainerizerTest.ROOT_DOCKER_SkipRecoverMalformedUUID > [23:09:24] : [Step 10/10] I1028 23:09:24.304638 31435 docker.cpp:933] > Running docker -H unix:///var/run/docker.sock rm -f -v mesos-s1.malformedUUID > [23:09:24] : [Step 10/10] I1028 23:09:24.398941 31435 resources.cpp:572] > Parsing resources as JSON failed: cpus:1;mem:512 > [23:09:24] : [Step 10/10] Trying semicolon-delimited string format instead > [23:09:24] : [Step 10/10] I1028 23:09:24.399123 31435 docker.cpp:809] > Running docker -H unix:///var/run/docker.sock run --cpu-shares 1024 --memory > 536870912 -e MESOS_SANDBOX=/mnt/mesos/sandbox -e > MESOS_CONTAINER_NAME=mesos-s1.malformedUUID -v > /mnt/teamcity/temp/buildTmp/DockerContainerizerTest_ROOT_DOCKER_SkipRecoverMalformedUUID_rjDyqa:/mnt/mesos/sandbox > --net host --entrypoint /bin/sh --name mesos-s1.malformedUUID alpine -c > sleep 1000 > [23:09:24] : [Step 10/10] I1028 23:09:24.401227 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:24] : [Step 10/10] I1028 23:09:24.700460 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:24] : [Step 10/10] I1028 23:09:24.804401 31453 docker.cpp:785] > Recovering Docker containers > [23:09:24] : [Step 10/10] I1028 23:09:24.804477 31453 docker.cpp:1091] > Running docker -H unix:///var/run/docker.sock ps -a > [23:09:24] : [Step 10/10] I1028 23:09:24.905027 31454 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:25] : [Step 10/10] W1028 23:09:25.008965 31454 docker.cpp:838] > Skipping recovery of executor '' of framework '' because its latest run could > not be recovered > [23:09:25] : [Step 10/10] I1028 23:09:25.008996 31454 docker.cpp:957] > Checking if Docker container named '/mesos-s1.malformedUUID' was started by > Mesos > [23:09:25] : [Step 10/10] I1028 23:09:25.009019 31454 docker.cpp:967] > Checking if Mesos container with ID 'malformedUUID' has been orphaned > [23:09:25] : [Step 10/10] I1028 23:09:25.009052 31454 docker.cpp:860] > Running docker -H unix:///var/run/docker.sock stop -t 0 > 1e9990dbadad6078ceda5d5e0cbfd62b9242c22359126b42dca77d6fdd9a2747 > [23:09:25] : [Step 10/10] I1028 23:09:25.109345 31451 docker.cpp:933] > Running docker -H unix:///var/run/docker.sock rm -v > 1e9990dbadad6078ceda5d5e0cbfd62b9242c22359126b42dca77d6fdd9a2747 > [23:09:25] : [Step 10/10] I1028 23:09:25.212870 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:25] : [Step 10/10] I1028 23:09:25.513255 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:25] : [Step 10/10] I1028 23:09:25.815946 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:26] : [Step 10/10] I1028 23:09:26.119107 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:26] : [Step 10/10] I1028 23:09:26.421722 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:26] : [Step 10/10] I1028 23:09:26.724777 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:27] : [Step 10/10] I1028 23:09:27.028252 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:27] : [Step 10/10] I1028 23:09:27.331799 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:27] : [Step 10/10] I1028 23:09:27.634660 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:27] : [Step 10/10] I1028 23:09:27.938190 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:28] : [Step 10/10] I1028 23:09:28.241756 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:28] : [Step 10/10] I1028 23:09:28.544697 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:28] : [Step 10/10] I1028 23:09:28.847909 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:29] : [Step 10/10] I1028 23:09:29.151430 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:29] : [Step 10/10] I1028 23:09:29.454700 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:29] : [Step 10/10] I1028 23:09:29.757531 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:30] : [Step 10/10] I1028 23:09:30.060485 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:30] : [Step 10/10] I1028 23:09:30.364303 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:30] : [Step 10/10] I1028 23:09:30.668233 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:30] : [Step 10/10] I1028 23:09:30.971650 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:31] : [Step 10/10] I1028 23:09:31.275362 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:31] : [Step 10/10] I1028 23:09:31.578639 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:31] : [Step 10/10] I1028 23:09:31.881480 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:32] : [Step 10/10] I1028 23:09:32.185004 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:32] : [Step 10/10] I1028 23:09:32.488839 31435 docker.cpp:972] > Running docker -H unix:///var/run/docker.sock inspect mesos-s1.malformedUUID > [23:09:32] : [Step 10/10] > ../../src/tests/containerizer/docker_containerizer_tests.cpp:1519: Failure > [23:09:32] : [Step 10/10] Value of: exists(docker, slaveId, containerId) > [23:09:32] : [Step 10/10] Actual: false > [23:09:32] : [Step 10/10] Expected: true > [23:09:32] : [Step 10/10] I1028 23:09:32.792539 31435 docker.cpp:1091] > Running docker -H unix:///var/run/docker.sock ps -a > [23:09:32] : [Step 10/10] [ FAILED ] > DockerContainerizerTest.ROOT_DOCKER_SkipRecoverMalformedUUID (8590 ms) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)