[
https://issues.apache.org/jira/browse/MESOS-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299928#comment-16299928
]
Armand Grillet commented on MESOS-8217:
---------------------------------------
In order to not change the current workflow using git hooks, the review request
above makes mesos-style smarter by only creating the virtual environment if
necessary. This means that only developers working on {{.py}} and {{.js}} files
will have to download linters from the internet to be able to instantiate them.
For C++ developers, the linter is already included in the repository and the
git hook will thus be a fast process again once r/64683/ is merged.
> Don't run linters on every commit
> ---------------------------------
>
> Key: MESOS-8217
> URL: https://issues.apache.org/jira/browse/MESOS-8217
> Project: Mesos
> Issue Type: Bug
> Reporter: Benno Evers
> Assignee: Armand Grillet
>
> The mesos `pre-commit` hook is currently running several linters on the
> source code, some of which are even dynamically installed from the internet
> during a commit.
> This can hinder development because it also applies to local commits that are
> not intended to be ever published, and can quickly become annoying when
> rebasing old branches.
> Instead, we should think about putting these hooks into a separate
> `support/verify-reviews.py` which would be executed when trying to post a
> review, since at this point the patches should be cleaned up and pass all
> linter checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
