[ 
https://issues.apache.org/jira/browse/MESOS-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Mahler reopened MESOS-2381:
------------------------------------

authentication.proto was missed during the change, it still has {{package 
mesos}}.

> Build failure after reintroducing "internal" namespace
> ------------------------------------------------------
>
>                 Key: MESOS-2381
>                 URL: https://issues.apache.org/jira/browse/MESOS-2381
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Kapil Arya
>            Assignee: Kapil Arya
>            Priority: Blocker
>
> Four different problems with the build:
> 1. https://builds.apache.org/job/Mesos-Ubuntu-distcheck/703/changes
> {code}
> + ./support/mesos-style.py
> Checking 592 files using filter 
> --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
> src/tests/isolator.hpp:44:  Lines should be <= 80 characters long  
> [whitespace/line_length] [2]
> Total errors found: 1
> Build step 'Execute shell' marked build as failure
> {code}
> 2. 
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2479/changes
> {code}
> libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
> -DPACKAGE_VERSION=\"0.22.0\" "-DPACKAGE_STRING=\"mesos 0.22.0\"" 
> -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
> -DVERSION=\"0.22.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
> -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
> -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
> -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 
> -DHAVE_LIBCURL=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 
> -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
> -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBSASL2=1 -DMESOS_HAS_JAVA=1 
> -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -Wall -Werror 
> -DLIBDIR=\"/usr/local/lib\" -DPKGLIBEXECDIR=\"/usr/local/libexec/mesos\" 
> -DPKGDATADIR=\"/usr/local/share/mesos\" -I../include 
> -I../3rdparty/libprocess/include 
> -I../3rdparty/libprocess/3rdparty/stout/include -I../include 
> -I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0 
> -I../3rdparty/libprocess/3rdparty/picojson-4f93734 
> -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src 
> -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src 
> -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src 
> -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include 
> -I../3rdparty/zookeeper-3.4.5/src/c/generated 
> -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src 
> -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 
> -pthread -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT 
> hook/libmesos_no_3rdparty_la-manager.lo -MD -MP -MF 
> hook/.deps/libmesos_no_3rdparty_la-manager.Tpo -c hook/manager.cpp  -fPIC 
> -DPIC -o hook/.libs/libmesos_no_3rdparty_la-manager.o
> In file included from hook/manager.cpp:36:0:
> ./module/manager.hpp: In static member function 'static 
> std::vector<std::basic_string<char> > mesos::modules::ModuleManager::find()':
> ./module/manager.hpp:120:5: error: 'Lock' is not a member of 'mesos'
>      mesos::Lock lock(&mutex);
>      ^
> ./module/manager.hpp:120:5: note: suggested alternative:
> In file included from hook/manager.cpp:34:0:
> ./common/lock.hpp:28:7: note:   'mesos::internal::Lock'
>  class Lock
>        ^
> In file included from hook/manager.cpp:36:0:
> ./module/manager.hpp:120:17: error: expected ';' before 'lock'
>      mesos::Lock lock(&mutex);
>                  ^
> make[2]: *** [hook/libmesos_no_3rdparty_la-manager.lo] Error 1
> make[2]: Leaving directory 
> `<https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src'>
> make[1]: *** [check] Error 2
> make[1]: Leaving directory 
> `<https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/ws/src'>
> make: *** [check-recursive] Error 1
> Build step 'Execute shell' marked build as failure
> Recording test results
> {code}
> 3. Missing the following lines from src/local.cpp:
> {code}
> using mesos::internal::slave::Containerizer;                                  
>    
> using mesos::internal::slave::Fetcher;                                        
>    
> using mesos::internal::slave::GarbageCollector;                               
>    
> using mesos::internal::slave::Slave;                                          
>    
> using mesos::internal::slave::StatusUpdateManager;                            
>    
> {code}
> 4. Anonymous  module test:
> {code}
> ../../src/tests/anonymous_tests.cpp:37:24: error: ‘tests’ is not a 
> namespace-name
>  using namespace mesos::tests;
>                         ^
> ../../src/tests/anonymous_tests.cpp:37:29: error: expected namespace-name 
> before ‘;’ token
>  using namespace mesos::tests;
>                              ^
> Makefile:4635: recipe for target 'tests/mesos_tests-anonymous_tests.o' failed
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to