[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589380#comment-16589380
]
ASF GitHub Bot commented on METRON-1665:
Github user merrimanr commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/
I really like this feature and think it's an important improvement. This
PR is a great start and I don't see any major architectural issues. I've added
some comments inline for the really minor
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589351#comment-16589351
]
ASF GitHub Bot commented on METRON-1665:
Github user merrimanr commented on a diff in the pull
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212108451
--- Diff: metron-interface/metron-ui-host/pom.xml ---
@@ -0,0 +1,142 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589344#comment-16589344
]
ASF GitHub Bot commented on METRON-1665:
Github user merrimanr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589343#comment-16589343
]
ASF GitHub Bot commented on METRON-1665:
Github user merrimanr commented on a diff in the pull
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212107810
--- Diff: metron-interface/metron-rest-client/bin/pom.xml ---
@@ -0,0 +1,52 @@
+
--- End diff --
Is adding this file a mistake?
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212107439
--- Diff:
metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh ---
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+#
+# Licensed to
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589340#comment-16589340
]
ASF GitHub Bot commented on METRON-1665:
Github user merrimanr commented on a diff in the pull
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212106486
--- Diff: metron-interface/metron-alerts-host/pom.xml ---
@@ -0,0 +1,143 @@
+
--- End diff --
I'm not even sure this is accurate
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589338#comment-16589338
]
ASF GitHub Bot commented on METRON-1665:
Github user merrimanr commented on a diff in the pull
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212106080
--- Diff:
metron-interface/metron-alerts-host/src/main/java/org/apache/metron/ui/AlertsApplication.java
---
@@ -0,0 +1,31 @@
+/**
--- End diff
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589330#comment-16589330
]
ASF GitHub Bot commented on METRON-1665:
Github user merrimanr commented on a diff in the pull
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212104536
--- Diff: metron-interface/metron-alerts-host/pom.xml ---
@@ -0,0 +1,143 @@
+
--- End diff --
Our xml files generally follow the
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589067#comment-16589067
]
ASF GitHub Bot commented on METRON-1724:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212012726
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588988#comment-16588988
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on a diff in the pull
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211990573
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588985#comment-16588985
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on a diff in the pull
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211989622
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588930#comment-16588930
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on a diff in the pull
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211979831
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211972645
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588909#comment-16588909
]
ASF GitHub Bot commented on METRON-1724:
Github user ruffle1986 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588904#comment-16588904
]
ASF GitHub Bot commented on METRON-1724:
Github user ruffle1986 commented on a diff in the pull
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211970078
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1657#comment-1657
]
ASF GitHub Bot commented on METRON-1724:
Github user simonellistonball commented on a diff in
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211964997
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588867#comment-16588867
]
ASF GitHub Bot commented on METRON-1724:
Github user ruffle1986 commented on a diff in the pull
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211960374
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211945169
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588706#comment-16588706
]
ASF GitHub Bot commented on METRON-1724:
GitHub user tiborm opened a pull request:
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1172
METRON-1724: Date/time validation missing in PCAP query
## Contributor Comments
This PR contains date range validation. We added validation messages with
hints also, to help the user correct a
33 matches
Mail list logo
