[jira] [Commented] (METRON-1304) Allow metron-bro-plugin-kafka to include or exclude logs

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648686#comment-16648686 ] ASF GitHub Bot commented on METRON-1304: Github user JonZeolla commented on the issue:

[GitHub] metron-bro-plugin-kafka issue #2: METRON-1304: Allow metron-bro-plugin-kafka...

2018-10-12 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/2 An easy way to test this is to use bro-pkg to install the plugin from my branch, or you can go on a properly configured bro box to the `tests` directory and run `btest -d`. ---

[jira] [Created] (METRON-1824) Add travis to metron-bro-plugin-kafka

2018-10-12 Thread Jon Zeolla (JIRA)
Jon Zeolla created METRON-1824: -- Summary: Add travis to metron-bro-plugin-kafka Key: METRON-1824 URL: https://issues.apache.org/jira/browse/METRON-1824 Project: Metron Issue Type: Improvement

[jira] [Commented] (METRON-1304) Allow metron-bro-plugin-kafka to include or exclude logs

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648617#comment-16648617 ] ASF GitHub Bot commented on METRON-1304: Github user JonZeolla commented on the issue:

[GitHub] metron-bro-plugin-kafka issue #2: METRON-1304: Allow metron-bro-plugin-kafka...

2018-10-12 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/2 This is ready for review. I refactored and added tests for the new include/exclude functionality and also found out that the unit tests are broken for `0.2`, which this fixes.

[GitHub] metron pull request #1236: METRON-1821: Align prepare-release-candidate with...

2018-10-12 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/1236 METRON-1821: Align prepare-release-candidate with documentation ## Contributor Comments Somewhat straightforward change to `prepare-release-candidate`. Primarily fixes [a

[jira] [Updated] (METRON-1821) Align prepare-release-candidate with documentation

2018-10-12 Thread Jon Zeolla (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-1821: --- Summary: Align prepare-release-candidate with documentation (was: Add bro package tag during

[jira] [Commented] (METRON-1790) Unsubscribe from every observable in the pcap panel UI component

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647941#comment-16647941 ] ASF GitHub Bot commented on METRON-1790: Github user ruffle1986 commented on a diff in the pull

[GitHub] metron pull request #1208: METRON-1790: Unsubscribe from every observable in...

2018-10-12 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1208#discussion_r224797583 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.ts --- @@ -81,26 +81,28 @@ export class PcapPanelComponent

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647899#comment-16647899 ] ASF GitHub Bot commented on METRON-1681: Github user merrimanr commented on a diff in the pull

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-12 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1213#discussion_r224780152 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ParserRunnerImpl.java --- @@ -137,11 +208,29 @@ private void

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647896#comment-16647896 ] ASF GitHub Bot commented on METRON-1681: GitHub user merrimanr reopened a pull request:

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-12 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/1213 METRON-1681: Decouple the ParserBolt from the Parse execution logic ## Contributor Comments The primary purpose of this PR is to create a parser container abstraction that is decoupled

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-12 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1213 ---

[jira] [Commented] (METRON-1803) Integrate Cypress with Travis

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647841#comment-16647841 ] ASF GitHub Bot commented on METRON-1803: Github user tiborm commented on the issue:

[jira] [Commented] (METRON-1803) Integrate Cypress with Travis

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647829#comment-16647829 ] ASF GitHub Bot commented on METRON-1803: Github user tiborm commented on a diff in the pull

[GitHub] metron pull request #1226: METRON-1803: Integrate Cypress with Travis

2018-10-12 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1226#discussion_r224761311 --- Diff: metron-interface/metron-alerts/cypress/integration/pcap/pcap.spec.js --- @@ -0,0 +1,228 @@ +/// --- End diff -- This turns on

[jira] [Commented] (METRON-1803) Integrate Cypress with Travis

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647820#comment-16647820 ] ASF GitHub Bot commented on METRON-1803: Github user tiborm commented on a diff in the pull

[GitHub] metron pull request #1226: METRON-1803: Integrate Cypress with Travis

2018-10-12 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1226#discussion_r224759531 --- Diff: metron-interface/metron-alerts/cypress/support/commands.js --- @@ -0,0 +1,43 @@ +/** --- End diff -- Some files look like

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647800#comment-16647800 ] ASF GitHub Bot commented on METRON-1681: Github user ottobackwards commented on a diff in the

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1213#discussion_r224755060 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ParserRunnerImpl.java --- @@ -137,11 +208,29 @@ private void

[jira] [Commented] (METRON-1681) Decouple the ParserBolt from the Parse execution logic

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647779#comment-16647779 ] ASF GitHub Bot commented on METRON-1681: Github user ottobackwards commented on a diff in the

[GitHub] metron pull request #1213: METRON-1681: Decouple the ParserBolt from the Par...

2018-10-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1213#discussion_r224746795 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ParserRunnerImpl.java --- @@ -137,11 +208,29 @@ private void

[jira] [Commented] (METRON-1790) Unsubscribe from every observable in the pcap panel UI component

2018-10-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647775#comment-16647775 ] ASF GitHub Bot commented on METRON-1790: Github user tiborm commented on the issue:

[GitHub] metron issue #1208: METRON-1790: Unsubscribe from every observable in the pc...

2018-10-12 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1208 @nickwallen The concept here is observable is a stream of events. The basic rule is to unsubscribe when you no longer want to know about new values from a particular stream. (RxJs/Angular handling