[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654329#comment-16654329
]
ASF GitHub Bot commented on METRON-1816:
Github user merrimanr commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1233
The existing Stellar date functions use SimpleDateFormat and already have a
caching layer built in so I decided to reuse what was already there. Happy to
switch to DateTimeFormatter here or in a
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654274#comment-16654274
]
ASF GitHub Bot commented on METRON-1816:
Github user simonellistonball commented on the issue:
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/1233
Right, I hear that! I also really like the idea of a follow on function
that returns the default formats as a great solution to this problem. Should we
do that?
---
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654268#comment-16654268
]
ASF GitHub Bot commented on METRON-1816:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1233
This comes to mind for me, because using Nifi processors that take date
formats and in other places I'm sick of cutting and pasting complex ISO formats
into configurations when there are
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654263#comment-16654263
]
ASF GitHub Bot commented on METRON-1816:
Github user simonellistonball commented on the issue:
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/1233
I would worry about having to parse the strong argument to determine
whether to use a constant or custom formatter, but I guess my concern is
limited because weâre caching the formatter
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1233
I'm not sure what you mean? Can you elaborate?
Also, I'm actually thinking of using DateFormatter and the new java time
api's:
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654241#comment-16654241
]
ASF GitHub Bot commented on METRON-1816:
Github user ottobackwards commented on the issue:
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/1233
@ottobackwards wouldn't ISO constant support require us to do a check on
the string before passing to the DateFormat instance, which on something that
is likely to be run A LOT (i.e.
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654183#comment-16654183
]
ASF GitHub Bot commented on METRON-1816:
Github user simonellistonball commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654078#comment-16654078
]
ASF GitHub Bot commented on METRON-1816:
Github user ottobackwards commented on a diff in the
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654077#comment-16654077
]
ASF GitHub Bot commented on METRON-1816:
Github user ottobackwards commented on a diff in the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1233#discussion_r226064248
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java
---
@@ -225,4 +226,36 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1233#discussion_r226064136
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/DateFunctions.java
---
@@ -109,6 +110,13 @@ public
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654075#comment-16654075
]
ASF GitHub Bot commented on METRON-1816:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1233
we should support the ISO date format constants so that users don't have to
copy those formats.
---
[
https://issues.apache.org/jira/browse/METRON-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653902#comment-16653902
]
ASF GitHub Bot commented on METRON-1816:
Github user simonellistonball commented on the issue:
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/1233
Looks like a very useful gap filler to me. +1 (non-binding) by inspection
from me for sure.
---
[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653752#comment-16653752
]
ASF GitHub Bot commented on METRON-1681:
Github user mmiklavc commented on the issue:
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1213
lgtm, +1 by inspection. Thanks for the collaborative effort on this
@merrimanr and @ottobackwards!
---
[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653745#comment-16653745
]
ASF GitHub Bot commented on METRON-1681:
Github user merrimanr commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1213
The latest commit adds the Deprecated annotations to parse and
parseOptional and removes MultilineMessageParser. I also updated the
`MessageParserTest` with more tests to ensure we're handling
GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1240
METRON-1830: Re-implement Alerts dialog box without jQuery
## Contributor Comments
[Link to METRON-1830 on ASF
JIRA](https://issues.apache.org/jira/browse/METRON-1830)
Previously, the
[
https://issues.apache.org/jira/browse/METRON-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653682#comment-16653682
]
ASF GitHub Bot commented on METRON-1830:
GitHub user sardell opened a pull request:
[
https://issues.apache.org/jira/browse/METRON-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shane Ardell reassigned METRON-1830:
Assignee: Shane Ardell
> Re-implement Alerts dialog box without jQuery
>
Shane Ardell created METRON-1830:
Summary: Re-implement Alerts dialog box without jQuery
Key: METRON-1830
URL: https://issues.apache.org/jira/browse/METRON-1830
Project: Metron
Issue Type:
[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653370#comment-16653370
]
ASF GitHub Bot commented on METRON-1681:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1213
That is fine
---
[
https://issues.apache.org/jira/browse/METRON-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653171#comment-16653171
]
ASF GitHub Bot commented on METRON-1803:
Github user tiborm commented on the issue:
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1226
@mmiklavc Yes, that's the main file. Cypress.conf.json contains 4 line of
configs and package.json 3 lines of changes required by the integration.
Anything else is test response data.
---
32 matches
Mail list logo
