[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #40: METRON-2309 Add a Kafka "metadata.broker.list" for each log writer filter.

2020-04-29 Thread GitBox
JonZeolla commented on pull request #40: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/40#issuecomment-621417174 Hi @mauropalumbo75 thanks again for the contribution. Can you rebase this on master and see if the e2e tests pass? It should include the `btest`s within Docker

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #43: METRON-2349: [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests

2020-04-29 Thread GitBox
JonZeolla commented on pull request #43: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/43#issuecomment-621396855 Force pushed to rebase on master without merge conflicts. This is an automated message from the A

[jira] [Commented] (METRON-2349) [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests

2020-04-29 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095791#comment-17095791 ] Jon Zeolla commented on METRON-2349: https://github.com/apache/metron-bro-plugin-kaf

[GitHub] [metron] JonZeolla commented on pull request #1580: METRON-2348 fix prepare-commit

2020-04-29 Thread GitBox
JonZeolla commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-621391223 FYI tested this to merge apache/metron-bro-plugin-kafka#42 successfully. This is an automated message from the

[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #43: METRON-2349: [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests

2020-04-29 Thread GitBox
JonZeolla opened a new pull request #43: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/43 ## Contributor Comments Fixes e2e tests when a custom kafka topic is specified. Previously everything would have completed without error, but the bro container would have sent to a h

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
ottobackwards commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-621382174 +1 nice work This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
JonZeolla commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-621380805 Ok, back to you @ottobackwards should have addressed all of your feedback now This is an automate

[jira] [Created] (METRON-2349) [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests

2020-04-29 Thread Jon Zeolla (Jira)
Jon Zeolla created METRON-2349: -- Summary: [BRO-PLUGIN-KAFKA] Fix hard coded topic_name in e2e tests Key: METRON-2349 URL: https://issues.apache.org/jira/browse/METRON-2349 Project: Metron Issue

[jira] [Commented] (METRON-2339) Can not match backslash in REGEXP_MATCH Stellar REPL

2020-04-29 Thread Otto Fowler (Jira)
[ https://issues.apache.org/jira/browse/METRON-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095530#comment-17095530 ] Otto Fowler commented on METRON-2339: - If you can confirm that '\\\' works for you t

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
JonZeolla commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-621248256 Thanks - give me a bit to wrap up responses to your feedback, hopefully I'll get time in the next couple of days. ---

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-29 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417359367 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with