[GitHub] [metron] nickwallen commented on issue #1502: METRON-2248 Merge Master into Feature Branch

2019-09-06 Thread GitBox
nickwallen commented on issue #1502: METRON-2248 Merge Master into Feature Branch URL: https://github.com/apache/metron/pull/1502#issuecomment-528885930 This has been merged in master. This is an automated message from the

[GitHub] [metron] mmiklavc commented on issue #1502: METRON-2248 Merge Master into Feature Branch

2019-09-06 Thread GitBox
mmiklavc commented on issue #1502: METRON-2248 Merge Master into Feature Branch URL: https://github.com/apache/metron/pull/1502#issuecomment-528884907 +1 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] asfgit closed pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-09-06 Thread GitBox
asfgit closed pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495 This is an automated message from the Apache Git Service. To

[GitHub] [metron] nickwallen commented on issue #1502: METRON-2248 Merge Master into Feature Branch

2019-09-06 Thread GitBox
nickwallen commented on issue #1502: METRON-2248 Merge Master into Feature Branch URL: https://github.com/apache/metron/pull/1502#issuecomment-528867033 > @mmiklavc we need to be testing on a Centos 7 box for the feature branch, no? You are right. I updated the description and test

[GitHub] [metron] sardell commented on a change in pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-09-06 Thread GitBox
sardell commented on a change in pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495#discussion_r321648773 ## File path:

[GitHub] [metron] tigerquoll opened a new pull request #1503: Metron-2247

2019-09-06 Thread GitBox
tigerquoll opened a new pull request #1503: Metron-2247 URL: https://github.com/apache/metron/pull/1503 ## Contributor Comments This PR allows full dev deploy users to skip rpmlint processing via setting an environment variable. For justification for excluding rpmlint from the

[GitHub] [metron] mmiklavc commented on issue #1502: METRON-2248 Merge Master into Feature Branch

2019-09-05 Thread GitBox
mmiklavc commented on issue #1502: METRON-2248 Merge Master into Feature Branch URL: https://github.com/apache/metron/pull/1502#issuecomment-528649992 @nickwallen I reviewed the commits you made to get this working post-merge and it looks good to me. I'm +1 by inspection, unless you want

[GitHub] [metron] mmiklavc commented on issue #1502: METRON-2248 Merge Master into Feature Branch

2019-09-05 Thread GitBox
mmiklavc commented on issue #1502: METRON-2248 Merge Master into Feature Branch URL: https://github.com/apache/metron/pull/1502#issuecomment-528649248 @nickwallen we need to be testing on a Centos 7 box for the feature branch, no?

[GitHub] [metron] nickwallen opened a new pull request #1502: METRON-2248 Merge Master into Feature Branch

2019-09-05 Thread GitBox
nickwallen opened a new pull request #1502: METRON-2248 Merge Master into Feature Branch URL: https://github.com/apache/metron/pull/1502 This change merges the latest from master into the `feature/METRON-2088-support-hdp-3.1` feature branch. The most significant changes impacting the

[GitHub] [metron] mmiklavc commented on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-09-05 Thread GitBox
mmiklavc commented on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495#issuecomment-528568807 @sardell this is a nice improvement, thanks! I'm +1 by inspection pending a quick answer on my question

[GitHub] [metron] mmiklavc commented on a change in pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-09-05 Thread GitBox
mmiklavc commented on a change in pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495#discussion_r321465753 ## File path:

[GitHub] [metron] mmiklavc commented on a change in pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-09-05 Thread GitBox
mmiklavc commented on a change in pull request #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495#discussion_r321464109 ## File path:

[GitHub] [metron] ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-05 Thread GitBox
ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528524502 So, once 2069 is done, we are all set? This is an

[GitHub] [metron] JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-05 Thread GitBox
JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528496162 [METRON-2069](https://issues.apache.org/jira/browse/METRON-2069) is that other JIRA spelling it out. Essentially we had

[GitHub] [metron] ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-05 Thread GitBox
ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528369230 maybe another jira? or something spelling it all out

[GitHub] [metron] ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-05 Thread GitBox
ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528369069 @JonZeolla what exactly needs to be done? I'll take a look if you can layout what we need to do

[GitHub] [metron] JonZeolla edited a comment on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-05 Thread GitBox
JonZeolla edited a comment on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528152825 As a side note, 0.2 has an issue (segfaults bro/zeek on shutdown) which has been fixed but hasn't been included

[GitHub] [metron] tigerquoll commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528155042 @mmiklavc Documentation on the docker build caching process

[GitHub] [metron] JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-04 Thread GitBox
JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528152825 As a side note, 0.2 has an issue (segfaults bro/zeek on shutdown) which hasn't been resolved, and a large number of

[GitHub] [metron] JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-04 Thread GitBox
JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528152270 Yeah, so once [METRON-2069](https://issues.apache.org/jira/browse/METRON-2069) is completed we should be ready to cut

[GitHub] [metron] JonZeolla closed pull request #1287: METRON-1915: Disable vagrant hostmanager in the development guest

2019-09-04 Thread GitBox
JonZeolla closed pull request #1287: METRON-1915: Disable vagrant hostmanager in the development guest URL: https://github.com/apache/metron/pull/1287 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] JonZeolla commented on issue #1287: METRON-1915: Disable vagrant hostmanager in the development guest

2019-09-04 Thread GitBox
JonZeolla commented on issue #1287: METRON-1915: Disable vagrant hostmanager in the development guest URL: https://github.com/apache/metron/pull/1287#issuecomment-528151015 Nothing more to add than I mentioned before. Happy to close to clean things up

[GitHub] [metron] tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528135292 @ottobackwards First some clarification: The old docker build process mounted the entire project

[GitHub] [metron] tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528137707 @mmiklavc Fair question. During the maven prepare phase for the packaging project, the jars from all

[GitHub] [metron] tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528137707 @mmiklavc Fair question. During the maven prepare phase for the packaging project, the jars from all

[GitHub] [metron] tigerquoll commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528137707 @mmiklavc Fair question. During the maven prepare phase for the packaging project, the jars from all of

[GitHub] [metron] tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll edited a comment on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528137707 @mmiklavc Fair question. During the maven prepare phase for the packaging project, the jars from all

[GitHub] [metron] tigerquoll commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528135292 @ottobackwards First some clarification: The old docker build process mounted the entire project

[GitHub] [metron] mmiklavc commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
mmiklavc commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-528110304 > This PR restructures the rpm-docker project to use a three-stage docker build process. The first docker file

[GitHub] [metron] asfgit closed pull request #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-09-04 Thread GitBox
asfgit closed pull request #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483 This is an automated message from the Apache Git Service. To respond

[GitHub] [metron] nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-09-04 Thread GitBox
nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-528067186 This has been merged into the feature branch as f77946d6eb421ad89ac0221048113111b34502a1

[GitHub] [metron] nickwallen closed pull request #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-09-04 Thread GitBox
nickwallen closed pull request #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497 This is an automated message from the Apache

[GitHub] [metron] mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-09-04 Thread GitBox
mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-528065113 Ok, thanks @nickwallen! +1 by inspection.

[GitHub] [metron] nickwallen edited a comment on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-09-04 Thread GitBox
nickwallen edited a comment on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-528061667 The revert of #1456 was not 100% clean since there have been changes introduced

[GitHub] [metron] nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-09-04 Thread GitBox
nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-528061667 The revert of #1456 was not 100% clean since there have been changes introduced after

[GitHub] [metron] mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-09-04 Thread GitBox
mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-528055572 @nickwallen I stepped through the list of commits per your PR description and it looks

[GitHub] [metron] nickwallen closed pull request #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade

2019-09-04 Thread GitBox
nickwallen closed pull request #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499 This is an automated message from the Apache Git Service. To

[GitHub] [metron] nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade

2019-09-04 Thread GitBox
nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-528030116 This has been committed to the feature branch as 1004b694b2157acb9c8dda51fa49dd088d47fbbe.

[GitHub] [metron] asfgit closed pull request #1474: METRON-2201: The description for the IS_IP method default behavior needs to corrected as per implementation

2019-09-04 Thread GitBox
asfgit closed pull request #1474: METRON-2201: The description for the IS_IP method default behavior needs to corrected as per implementation URL: https://github.com/apache/metron/pull/1474 This is an automated message from

[GitHub] [metron] mmiklavc commented on issue #1287: METRON-1915: Disable vagrant hostmanager in the development guest

2019-09-04 Thread GitBox
mmiklavc commented on issue #1287: METRON-1915: Disable vagrant hostmanager in the development guest URL: https://github.com/apache/metron/pull/1287#issuecomment-528011984 Bump, any update? This is an automated message from

[GitHub] [metron] mmiklavc commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-09-04 Thread GitBox
mmiklavc commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-528011553 @JonZeolla just checking in on this - still TBD for 0.3? Heh, that rhymes.

[GitHub] [metron] mmiklavc commented on issue #1496: METRON-2235 - Increase server startup timeout

2019-09-04 Thread GitBox
mmiklavc commented on issue #1496: METRON-2235 - Increase server startup timeout URL: https://github.com/apache/metron/pull/1496#issuecomment-528010840 @tigerquoll - can you indicate what you've completed on the checklist? Anything not done bc it's "n/a" just replace the box "[]" with

[GitHub] [metron] asfgit closed pull request #1493: METRON-2227 - Increase Kafka test harness timeout

2019-09-04 Thread GitBox
asfgit closed pull request #1493: METRON-2227 - Increase Kafka test harness timeout URL: https://github.com/apache/metron/pull/1493 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [metron] asfgit closed pull request #1489: METRON-2221: Notebook import fails through Zeppelin REST API

2019-09-04 Thread GitBox
asfgit closed pull request #1489: METRON-2221: Notebook import fails through Zeppelin REST API URL: https://github.com/apache/metron/pull/1489 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [metron] ottobackwards commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
ottobackwards commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-527927570 Can you do a scan of the documentation and make sure that the RPM location is correctly referenced?

[GitHub] [metron] sardell commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API

2019-09-04 Thread GitBox
sardell commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API URL: https://github.com/apache/metron/pull/1489#issuecomment-527915254 +1. Manually validated with full dev. Works exactly as described. Good stuff, @anandsubbu!

[GitHub] [metron] ottobackwards commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
ottobackwards commented on issue #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501#issuecomment-527903970 I was considering this type of thing as my next step in my pr. I'll review

[GitHub] [metron] tigerquoll opened a new pull request #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance

2019-09-04 Thread GitBox
tigerquoll opened a new pull request #1501: Metron-2246 rpm-docker - minimise use of bind mounts due to performance URL: https://github.com/apache/metron/pull/1501 ## Contributor Comments Docker bind shared folders have a reputation as being fairly slow and inefficient on Docker for

[GitHub] [metron] mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-09-03 Thread GitBox
mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-525102320 ## Test Plan ### Enrichments This will cover enrichments, threat intel, and the bulk loading

[GitHub] [metron] anandsubbu commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API

2019-09-03 Thread GitBox
anandsubbu commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API URL: https://github.com/apache/metron/pull/1489#issuecomment-527538202 Thanks @mmiklavc , done. I will wait for any comments from @sardell on the PR.

[GitHub] [metron] mmiklavc commented on issue #1261: METRON-1860 new developer option for ansible in docker to deploy to vagrant

2019-09-03 Thread GitBox
mmiklavc commented on issue #1261: METRON-1860 new developer option for ansible in docker to deploy to vagrant URL: https://github.com/apache/metron/pull/1261#issuecomment-527511923 @luozhenwei - it's generally best to ask these questions on the user or dev list, but here's the list of

[GitHub] [metron] mmiklavc commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API

2019-09-03 Thread GitBox
mmiklavc commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API URL: https://github.com/apache/metron/pull/1489#issuecomment-527497172 This looks good @anandsubbu - can you check off "Have you verified the basic functionality of the build by building and

[GitHub] [metron] asfgit closed pull request #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings

2019-09-03 Thread GitBox
asfgit closed pull request #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings URL: https://github.com/apache/metron/pull/1500 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] sardell commented on issue #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings

2019-09-03 Thread GitBox
sardell commented on issue #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings URL: https://github.com/apache/metron/pull/1500#issuecomment-527448548 @luozhenwei It sounds like your questions are unrelated to this PR, so they have a low likelihood of being answered

[GitHub] [metron] MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-09-03 Thread GitBox
MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-527448402 Thanks @mmiklavc ! it's +1 with verification from my side .

[GitHub] [metron] luozhenwei commented on issue #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings

2019-09-03 Thread GitBox
luozhenwei commented on issue #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings URL: https://github.com/apache/metron/pull/1500#issuecomment-527438789 Hello, may I ask you a question? For testing purposes, I compiled metron according to the source code on github.

[GitHub] [metron] anandsubbu commented on issue #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings

2019-09-03 Thread GitBox
anandsubbu commented on issue #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings URL: https://github.com/apache/metron/pull/1500#issuecomment-527413556 +1 * Spun up full dev and did some sanity testing on the UIs * Ran `npm audit`on both metron-alerts and

[GitHub] [metron] tigerquoll commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-09-02 Thread GitBox
tigerquoll commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-527148785 One thing to note, there was a non-fatal class cast exception in the nimbus logs: ``` 2019-09-02

[GitHub] [metron] tigerquoll commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-09-02 Thread GitBox
tigerquoll commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-527128643 Tests completed on a fresh pull / full dev deployment. All tests passed successfully. One nit: Command for

[GitHub] [metron] mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade

2019-08-30 Thread GitBox
mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526693199 @nickwallen I think that is reasonable here, specifically because I don't think your change is going to have

[GitHub] [metron] nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade

2019-08-30 Thread GitBox
nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526678480 I just did the basic 'vagrant up'. I added that to the description. Let me know if you think we should do

[GitHub] [metron] nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade

2019-08-30 Thread GitBox
nickwallen commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526675769 What do you suggest? This is an automated

[GitHub] [metron] mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade

2019-08-30 Thread GitBox
mmiklavc commented on issue #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499#issuecomment-526670030 Considering the high exposure to classpath issues we have, what's the test plan for this beyond the basic Travis

[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-30 Thread GitBox
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526668757 @MohanDV that makes sense then - this would be an expected exception in that case.

[GitHub] [metron] MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-30 Thread GitBox
MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526644929 @mmiklavc Yes I have an entry `1567166198.507 0 ::1 TAG_NONE/400 3983 GET

[GitHub] [metron] asfgit closed pull request #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input

2019-08-30 Thread GitBox
asfgit closed pull request #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input URL: https://github.com/apache/metron/pull/1477 This is an automated message from the Apache Git Service.

[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-30 Thread GitBox
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526643205 @MohanDV thanks for the review! The enrichment I constructed wasn't robust in the sense that if an ip_dst_addr

[GitHub] [metron] MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-30 Thread GitBox
MohanDV commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526633319 @mmiklavc I have completed tests on a 5 node cluster, for the profiler tests I see below exceptions in the worker

[GitHub] [metron] sardell opened a new pull request #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings

2019-08-30 Thread GitBox
sardell opened a new pull request #1500: METRON-2243: [UI] Update npm dependencies to resolve audit warnings URL: https://github.com/apache/metron/pull/1500 ## Contributor Comments Link to ASF Jira ticket: https://issues.apache.org/jira/browse/METRON-2243 This PR updates a few

[GitHub] [metron] nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-08-29 Thread GitBox
nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-526351500 I have included the patch for #1499 as this was preventing the CI build from completing

[GitHub] [metron] nickwallen opened a new pull request #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade

2019-08-29 Thread GitBox
nickwallen opened a new pull request #1499: METRON-2241 Profiler Integration Test Fails After Storm 1.2.1 Upgrade URL: https://github.com/apache/metron/pull/1499 After the upgrade to Storm 1.2.1, there have been intermittent failures in the Storm Profiler integration tests. This

[GitHub] [metron] mmiklavc commented on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-08-29 Thread GitBox
mmiklavc commented on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495#issuecomment-526269692 @sardell you must be making people happy with this one - I think this is the first time I've ever seen a

[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-29 Thread GitBox
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526245828 @tigerquoll what all are you running? This leaves me with 1 slot available still

[GitHub] [metron] mmiklavc commented on issue #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input

2019-08-29 Thread GitBox
mmiklavc commented on issue #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input URL: https://github.com/apache/metron/pull/1477#issuecomment-526243889 +1, thanks @sardell This is an

[GitHub] [metron] anandsubbu commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API

2019-08-29 Thread GitBox
anandsubbu commented on issue #1489: METRON-2221: Notebook import fails through Zeppelin REST API URL: https://github.com/apache/metron/pull/1489#issuecomment-526184609 Travis issue seems unrelated to this PR. Retry #2 This

[GitHub] [metron] anandsubbu opened a new pull request #1489: METRON-2221: Notebook import fails through Zeppelin REST API

2019-08-29 Thread GitBox
anandsubbu opened a new pull request #1489: METRON-2221: Notebook import fails through Zeppelin REST API URL: https://github.com/apache/metron/pull/1489 ## Contributor Comments This PR modifies the zeppelin notebook import methods to use `curl` instead of `python-requests`. ##

[GitHub] [metron] anandsubbu closed pull request #1489: METRON-2221: Notebook import fails through Zeppelin REST API

2019-08-29 Thread GitBox
anandsubbu closed pull request #1489: METRON-2221: Notebook import fails through Zeppelin REST API URL: https://github.com/apache/metron/pull/1489 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [metron] ruffle1986 edited a comment on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-08-29 Thread GitBox
ruffle1986 edited a comment on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495#issuecomment-526122189 Tested it manually and everything worked fine. That's a nice one actually. +1 (non-binding) 

[GitHub] [metron] ruffle1986 edited a comment on issue #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input

2019-08-29 Thread GitBox
ruffle1986 edited a comment on issue #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input URL: https://github.com/apache/metron/pull/1477#issuecomment-526119013 Tested it manually. Worked fine for me. Well done!  +1 (non-binding)

[GitHub] [metron] tigerquoll commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-29 Thread GitBox
tigerquoll commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-526140555 For the test script: full dev still needed another supervisor slot in Storm to allow the squid enrichment

[GitHub] [metron] ruffle1986 commented on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time

2019-08-29 Thread GitBox
ruffle1986 commented on issue #1495: METRON-2211: [UI] Alerts UI should optionally render timestamp in local time URL: https://github.com/apache/metron/pull/1495#issuecomment-526122189 Tested it manually and everything worked fine. That's a nice one actually. +1 

[GitHub] [metron] ruffle1986 commented on issue #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input

2019-08-29 Thread GitBox
ruffle1986 commented on issue #1477: METRON-2199: [UI] Add ability to turn off query building in Alerts UI search input URL: https://github.com/apache/metron/pull/1477#issuecomment-526119013 Tested it manually. Worked fine for me. Well done!  +1

[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-28 Thread GitBox
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-525960987 I was getting classpath issues with my PR that now seem to be fixed with

[GitHub] [metron] mmiklavc commented on issue #1498: METRON-2238: Streaming enrichments regression

2019-08-28 Thread GitBox
mmiklavc commented on issue #1498: METRON-2238: Streaming enrichments regression URL: https://github.com/apache/metron/pull/1498#issuecomment-525885493 Ran through the streaming enrichment case as well as the basic squid parser case. Looks good to me, +1.

[GitHub] [metron] mmiklavc commented on issue #1498: METRON-2238: Streaming enrichments regression

2019-08-28 Thread GitBox
mmiklavc commented on issue #1498: METRON-2238: Streaming enrichments regression URL: https://github.com/apache/metron/pull/1498#issuecomment-525882099 I'm going to run through this test as well -

[GitHub] [metron] merrimanr commented on issue #1498: METRON-2238: Streaming enrichments regression

2019-08-28 Thread GitBox
merrimanr commented on issue #1498: METRON-2238: Streaming enrichments regression URL: https://github.com/apache/metron/pull/1498#issuecomment-525875507 As far as I know there are no modules that depend on `metron-parsing-storm`. If we focus on testing parser topologies then we should be

[GitHub] [metron] mmiklavc commented on issue #1498: METRON-2238: Streaming enrichments regression

2019-08-28 Thread GitBox
mmiklavc commented on issue #1498: METRON-2238: Streaming enrichments regression URL: https://github.com/apache/metron/pull/1498#issuecomment-525858316 What's our guarantee this change won't have implications in other places? What projects or other uber jars depend on this module?

[GitHub] [metron] nickwallen closed pull request #1492: METRON-2225: Upgrade to Solr 7.4.0

2019-08-28 Thread GitBox
nickwallen closed pull request #1492: METRON-2225: Upgrade to Solr 7.4.0 URL: https://github.com/apache/metron/pull/1492 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [metron] nickwallen commented on issue #1492: METRON-2225: Upgrade to Solr 7.4.0

2019-08-28 Thread GitBox
nickwallen commented on issue #1492: METRON-2225: Upgrade to Solr 7.4.0 URL: https://github.com/apache/metron/pull/1492#issuecomment-525829355 This has been merged into the feature branch as ad71c04. This is an automated

[GitHub] [metron] nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-08-28 Thread GitBox
nickwallen commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-525822179 > Here is a reference to the PR in master that obviates the need for these PRs - #1483

[GitHub] [metron] merrimanr commented on issue #1492: METRON-2225: Upgrade to Solr 7.4.0

2019-08-28 Thread GitBox
merrimanr commented on issue #1492: METRON-2225: Upgrade to Solr 7.4.0 URL: https://github.com/apache/metron/pull/1492#issuecomment-525796735 The latest commit updates the README for 7.4. This is an automated message from the

[GitHub] [metron] merrimanr opened a new pull request #1498: METRON-2238: Streaming enrichments regression

2019-08-28 Thread GitBox
merrimanr opened a new pull request #1498: METRON-2238: Streaming enrichments regression URL: https://github.com/apache/metron/pull/1498 ## Contributor Comments This PR fixes a small regression in the streaming enrichments use case. The issue happens specifically when a

[GitHub] [metron] nickwallen commented on issue #1490: METRON-2169: Upgrade to Kafka 2.0.0 and Storm 1.2.1

2019-08-28 Thread GitBox
nickwallen commented on issue #1490: METRON-2169: Upgrade to Kafka 2.0.0 and Storm 1.2.1 URL: https://github.com/apache/metron/pull/1490#issuecomment-525733917 This has been merged into the feature branch as 15e5276 This is

[GitHub] [metron] nickwallen closed pull request #1490: METRON-2169: Upgrade to Kafka 2.0.0 and Storm 1.2.1

2019-08-28 Thread GitBox
nickwallen closed pull request #1490: METRON-2169: Upgrade to Kafka 2.0.0 and Storm 1.2.1 URL: https://github.com/apache/metron/pull/1490 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-27 Thread GitBox
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-525465143 I just merged this PR with master, which includes the latest Maven changes from

[GitHub] [metron] mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-27 Thread GitBox
mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-525102320 ## Test Plan ### Enrichments This will cover enrichments, threat intel, and the bulk loading

[GitHub] [metron] mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-27 Thread GitBox
mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-525102320 ## Test Plan ### Enrichments This will cover enrichments, threat intel, and the bulk loading

[GitHub] [metron] mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-27 Thread GitBox
mmiklavc edited a comment on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-525102320 ## Test Plan ### Enrichments This will cover enrichments, threat intel, and the bulk loading

[GitHub] [metron] mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table

2019-08-27 Thread GitBox
mmiklavc commented on issue #1483: METRON-2217 Migrate current HBase client from HTableInterface to Table URL: https://github.com/apache/metron/pull/1483#issuecomment-525451558 @tigerquoll - Needed to update my enrichment config - I used stellar expression groups and forgot to update my

[GitHub] [metron] mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch

2019-08-27 Thread GitBox
mmiklavc commented on issue #1497: METRON-2231 Revert METRON-2175, METRON-2176, METRON-2177 in HDP 3.1 upgrade feature branch URL: https://github.com/apache/metron/pull/1497#issuecomment-525441376 Looks like we've got some merge conflicts with the Kafka PR that just went in. Here

<    5   6   7   8   9   10   11   12   13   14   >