Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1292
This should get added to the README.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/12
This is now ready for review, but if #21 gets in first we should update
some of the new files in that to use bro 2.6 instead of 2.5.5.
I also would like to get a 0.3
Github user JonZeolla commented on the pull request:
https://github.com/apache/metron/commit/ba9ddda6d742a0df96e24a1573f44482020c25fb#commitcomment-31583772
In metron-contrib/metron-docker/compose/kafkazk/Dockerfile:
In metron-contrib/metron-docker/compose/kafkazk/Dockerfile
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238848648
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
@ottobackwards for permissions I would do something like 0755
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238844401
--- Diff: docker/scripts/cleanup_containers.sh ---
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238844199
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238844073
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
Is there a reason the scripts in `scripts/` have inconsistent permissions?
Should `example_script.sh` have execute, or maybe even just call it
`run_test.sh` off the bat?
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238825786
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238824961
--- Diff: docker/run_test.sh.template ---
@@ -0,0 +1,199 @@
+#!/usr/bin/env bash
--- End diff --
Hmm ok, as long as it's
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238822684
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238822338
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238821774
--- Diff: docker/scripts/process_data_docker.sh ---
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238796266
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794511
--- Diff: docker/logs/bro-test-Tue_Dec__4_12:10:42_EST_2018.log ---
@@ -0,0 +1,2 @@
+Apache::Kafka - Writes logs to Kafka (dynamic
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238797889
--- Diff: docker/scripts/create_docker_network.sh ---
@@ -0,0 +1,73 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798965
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794488
--- Diff: docker/logs/bro-test-Tue_Dec__4_12:12:39_EST_2018.log ---
@@ -0,0 +1,3 @@
+Apache::Kafka - Writes logs to Kafka (dynamic
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238795456
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238795569
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798495
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238797994
--- Diff: docker/scripts/destroy_docker_network.sh ---
@@ -0,0 +1,71 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798480
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798456
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798567
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798518
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238798536
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238797481
--- Diff: docker/scripts/consume_bro_kafka.sh ---
@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794358
--- Diff: docker/logs/bro-test-Tue_Dec__4_11:58:05_EST_2018.log ---
@@ -0,0 +1,2 @@
+Apache::Kafka - Writes logs to Kafka (dynamic
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794286
--- Diff: docker/logs/bro-test-Tue_Dec__4_11:52:34_EST_2018.log ---
@@ -0,0 +1,2 @@
+Apache::Kafka - Writes logs to Kafka (dynamic
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794530
--- Diff: docker/logs/bro-test-Tue_Dec__4_12:03:04_EST_2018.log ---
@@ -0,0 +1,4 @@
+Apache::Kafka - Writes logs to Kafka (dynamic
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238793284
--- Diff: docker/in_docker_scripts/process_data_dir.sh ---
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794457
--- Diff: docker/logs/bro-test-Tue_Dec__4_13:26:18_EST_2018.log ---
@@ -0,0 +1,8 @@
+Running unit tests for "/root/code"
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238796550
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794421
--- Diff: docker/logs/bro-test-Tue_Dec__4_13:36:33_EST_2018.log ---
@@ -0,0 +1,8 @@
+Running unit tests for "/root/code"
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794676
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r23879
--- Diff: docker/logs/bro-test-Tue_Dec__4_13:28:12_EST_2018.log ---
@@ -0,0 +1,7 @@
+Running unit tests for "/root/code"
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238794306
--- Diff: docker/logs/bro-test-Tue_Dec__4_11:54:46_EST_2018.log ---
@@ -0,0 +1,2 @@
+Apache::Kafka - Writes logs to Kafka (dynamic
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238793117
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238795001
--- Diff: docker/run_test.sh.template ---
@@ -0,0 +1,199 @@
+#!/usr/bin/env bash
--- End diff --
Do we need this file?
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238430863
--- Diff: docker/in_docker_scripts/build_bro.sh ---
@@ -0,0 +1,31 @@
+#!/usr/bin/env bash
--- End diff --
Shouldn't we
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238429098
--- Diff: docker/containers/bro-localbuild-container/Dockerfile ---
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1287
Specifically my issue is that when I attempt to connect to a kafka broker
as a part of the bro plugin via `node1:6667` it fails because it's not
listening at the IP that hostmanager inserts
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/20
I wish I had more time to work on this, but it may be a while before I
could revisit. What I found was that if any of the `delete`s are duplicated it
segfaults on exit. From some
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/1287
METORN-1915: Disable vagrant hostmanager in the development guest
## Contributor Comments
This makes node1 resolve to 127.0.0.1 inside of the VM, instead of
192.168.66.121 by not modifying
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1283
+1 by inspection, the current approach works well enough for me
---
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/1282
METRON-1881: Update the bro plugin used in metron development
## Contributor Comments
Once the metron-bro-plugin-kafka v0.3 is released, this will move full-dev
to use
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1261
@mmiklavc probably at some point. I assume it would require some cleanup
for various scripts at the same time.
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236335016
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236253176
--- Diff: metron-deployment/development/centos6_docker_build/README.md ---
@@ -0,0 +1,89 @@
+
+Metron on CentOS 6 Built in Docker
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236255405
--- Diff:
metron-deployment/development/centos6_docker_build/ansible/inventory/group_vars/all
---
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236251472
--- Diff:
metron-deployment/development/centos6_docker_build/run_docker_only.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236257483
--- Diff:
metron-deployment/development/centos6_docker_build/docker_run_ansible.sh ---
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236249643
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236250814
--- Diff:
metron-deployment/development/centos6_docker_build/docker_run_ansible.sh ---
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236250204
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236252613
--- Diff: metron-deployment/development/centos6_docker_build/README.md ---
@@ -0,0 +1,89 @@
+
+Metron on CentOS 6 Built in Docker
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236251967
--- Diff: metron-deployment/development/docker/README.md ---
@@ -45,12 +45,4 @@ This provides a Docker Container containing all of the
prerequisites
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236252426
--- Diff: metron-deployment/development/centos6_docker_build/README.md ---
@@ -0,0 +1,89 @@
+
+Metron on CentOS 6 Built in Docker
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236249808
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236254476
--- Diff:
metron-deployment/development/centos6_docker_build/ansible/inventory/group_vars/all
---
@@ -0,0 +1,86 @@
+#
+# Licensed to the Apache
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236251269
--- Diff:
metron-deployment/development/centos6_docker_build/run_docker_only.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236251078
--- Diff:
metron-deployment/development/centos6_docker_build/run_docker_only.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236247445
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236250996
--- Diff:
metron-deployment/development/centos6_docker_build/run_docker_only.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1261#discussion_r236253505
--- Diff:
metron-deployment/development/centos6_docker_build/build_and_run.sh ---
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1277
+1 by inspection
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1273
From what I can tell, `include_tasks` was [added in
2.4.0](https://github.com/ansible/ansible/blob/stable-2.4/CHANGELOG.md#major-changes)
and the patch versions only include bugfixes. Can you
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/19
METRON-1885: Remove version from bro plugin btest
## Contributor Comments
This changes the show-plugin btest so that it should be compatible with bro
2.5-2.7 (as far as we
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
Sounds good, I'm inclined to accept but there is a little bit of
housekeeping to take care of first. Can you please take a look the "For all
changes" section of our P
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
So, I did put together a PR meant to handle this @ metron-bro-plugin-kafka#8
Do you happen to know if your approach is more generally accepted? It
feels somewhat strange
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1237
Yup, that was actually how I found METRON-1826 was an issue. Sorry, I
should have noted that.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1261
I'm going to take a stab at a further look next week. For now I gave it a
quick run-up and it was successful.
---
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/1260
METRON-1868: metron-committer-common incorrectly checking CHOSEN_REPO
## Contributor Comments
I found a minor bug when trying to use `prepare-commit` against the
metron-bro-plugin-kafka repo
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1171
Yup, my testing was all successful. I didn't review it thoroughly enough to
suggest it gets merged as is but I have no reason to hold it back.
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/17#discussion_r232435113
--- Diff: README.md ---
@@ -12,24 +12,72 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Okay, pushed that fix and merged in master.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1171
Yes, I outlined the specifics in my prior comments
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1171
+0 only performed functional testing.
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r232405844
--- Diff: README.md ---
@@ -11,6 +11,32 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r232405751
--- Diff: README.md ---
@@ -11,6 +11,32 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Suggested order of review: #16 -> #2 -> #17 -> #13
---
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/17
METRON-1866: Improve metron-bro-plugin-kafka documentation
## Contributor Comments
This depends on METRON-1304. Pure documentation change
You can merge this pull request
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Note that this one now depends on apache/metron-bro-plugin-kafka#16 to work
properly because I split out the btest bugfix.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Good to go on this one @nickwallen
---
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/16
METRON-1865: Fix metron-bro-plugin-kafka tests
## Contributor Comments
This fixes the btests which were unintentionally broken as a part of
apache/metron-bro-plugin-kafka#6
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/15
This should be resolved by apache/metron-bro-plugin-kafka#2 as it currently
stands, since it adds the `bro-pkg` example in the documentation and `btest`
fix which isn't otherwise
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
In looking through the PR, this is mostly related to the include/exclude
functionality yes, but you are right that it may look like there are some other
things included because
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
https://github.com/apache/metron-bro-plugin-kafka/pull/2#issuecomment-429502420
is still accurate for testing. I'll edit the initial comment to add it.
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1248#discussion_r228693677
--- Diff: dev-utilities/committer-utils/prepare-commit ---
@@ -16,242 +16,31 @@
# limitations under the License.
#
-# not likely
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1248#discussion_r228619906
--- Diff: dev-utilities/committer-utils/metron-committer-common ---
@@ -0,0 +1,353 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron/pull/1248#discussion_r228614878
--- Diff: dev-utilities/committer-utils/prepare-commit ---
@@ -16,242 +16,31 @@
# limitations under the License.
#
-# not likely
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/13
The upstream apache/metron#1238 has been merged.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1238
Took a stab at better explaining how sensors work in the dev environments
and how to use them.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1238
@nickwallen any concerns with my doc update?
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1238
Right, I was actually considering documenting that a bit better. I'll add
something
[here](https://github.com/apache/metron/tree/master/metron-deployment/development/centos6#working-with-metron
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/2
Based on the recent release discussions I'd like to get this in.
@nickwallen do you have any additional feedback?
---
Github user JonZeolla commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r225629223
--- Diff: README.md ---
@@ -11,6 +11,32 @@ This software is a part of the [Apache
Metron](http://metron.apache.org/) projec
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1197
Any idea why this is failing?
```
Running org.apache.metron.profiler.storm.integration.ProfilerIntegrationTest
2018-09-28 14:02:45 ERROR FluxTopologyComponent:198
1 - 100 of 156 matches
Mail list logo
