Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
Thanks for the taking the time you did to submit the PR @dopheide-esnet.
-1
Filling out the template to say "Yes reviewer, I tested, built, and check
the lic e
Github user dopheide-esnet commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
Please understand that I did that pull request for 20 different packages
precisely because it wasn't too time consuming. If it were a major change,
a new feature or some
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
Sounds good, I'm inclined to accept but there is a little bit of
housekeeping to take care of first. Can you please take a look the "For all
changes" section of our PR template and
Github user dopheide-esnet commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
I chatted with Siwek about it and this is merged into bro-aux as the
template for future users of init-plugin.
So itâs accepted in that regard as at least a short
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
So, I did put together a PR meant to handle this @ metron-bro-plugin-kafka#8
Do you happen to know if your approach is more generally accepted? It
feels somewhat strange to
