[GitHub] metron issue #1009: METRON-1549: Add empty object test to WriterBoltIntegrat...

2018-05-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1009 +1 ---

[GitHub] metron issue #1009: METRON-1549: Add empty object test to WriterBoltIntegrat...

2018-05-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1009 +1 This looks good. Thanks! ---

[GitHub] metron issue #1009: METRON-1549: Add empty object test to WriterBoltIntegrat...

2018-05-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1009 I think this is good. My work on the builder/Processor stuff was a decent attempt to reduce duplicate code in the integration tests without a total rethink. I think what we see across the

[GitHub] metron issue #1009: METRON-1549: Add empty object test to WriterBoltIntegrat...

2018-05-10 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1009 @nickwallen and @ottobackwards - I extracted the common setup components into one parameterized method. I opted for setting private test class fields with the components rather than invoking