Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1036
+1
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1036
@mmiklavc Are you good with this?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1036
+1 that looks great
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1036
I ran this up in full dev and everything worked as expected. +1 pending
approval from other reviewers.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1036
Undid refactors. This should include only what is needed.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1036
Yeah, I have mixed reactions. I think refactoring opportunistically is
damned useful, but if it becomes excessive it can make it hard to review and
make it hard for those with open branches in
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1036
I want to take a step back a moment here. I think there are some useful,
clarifying refactorings in this PR. I'm generally in favor of refactoring
improvements e.g. "handleTick(tuple)" that sum up
