Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
Closing PR now that this is merged into the feature branch.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1037
This looks good to me. +1 by inspection
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
Index removed from rest calls. I spun up full dev and confirmed both ES and
Solr still work as expected, and that the calls do not pass along index
anymore. Feature branch merged in to resolve
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1037
I agree with you @justinleet, we should drop the optional index from the
query.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
Kick Travis for cache bug
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
@cestella For that indexString thing, we could do a couple things
- Leave it as-is for now, and fix both when they need to be.
- Figure out how to fix it and fix both here.
- Drop
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
I haven't been able to reproduce Solr not making the delete call, and given
that the code is the same between ES and Solr, I'm inclined to call it a
browser issue.
I have spun this back
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
I believe the Travis issues have been resolved by the commit yesterday
reverting a log level change in testing.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
The ES not updating appears to be a preexisting issue, and I will file
another bug.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
Sidenote, I've also seen this branch fail several times on Travis with some
testing issues around ZK, so even when the existing problems get solved, I'd
like to dig into that more before
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
Having spun up #1040, it looks like the rest API indexString weirdness
might be outside the scope of this PR, but I'll want to dig in a bit more
before promising that.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
@cestella I have, yes, but it'll need to happen again because there's an
issue in ES, and issue in Solr, and a general issue.
The easiest way to go about it is generally to just spin up
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1037
Did you specifically run this up in the UI backed by both solr and ES?
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1037
This can be tested both on via REST API and via the UI, although as noted
above there is UI instability for right now.
It should work for both ES and Solr (although right now Solr
14 matches
Mail list logo
