[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user HeartSaVioR commented on the issue: https://github.com/apache/metron/pull/1039 @cestella Thanks for merging! Would you mind to mark Apache issue as resolved (with assigning issue to me) too? Thanks in advance! ---

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1039 Ok, the 1.2.2 change was run through some performance tests and I'm +1 on this; thanks for the contribution! ---

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user HeartSaVioR commented on the issue: https://github.com/apache/metron/pull/1039 Just updated the version. There's no change in pom.xml between 1.2.1 and 1.2.2, hence no change in transitive dependencies. Two files (KafkaSpoutRetryExponentialBackoff.java

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user HeartSaVioR commented on the issue: https://github.com/apache/metron/pull/1039 @anandsubbu Thanks for doing sanity & performance tests. @cestella Thanks for reviewing. STORM-2994: Before the patch, KafkaSpout cannot commit `null tuple`, which

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1039 I think I'm ready to +1 this. I wouldn't mind going to 1.2.2. Of those, I'm most concerned about STORM-2994. Can you characterize the risk of that happening? ---

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/1039 I ran a few performance tests comparing ver 1.1.0 and 1.2.1 on the enrichment topology using the

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user HeartSaVioR commented on the issue: https://github.com/apache/metron/pull/1039 Would you mind if I propose upgrading storm-kafka-client version to 1.2.2? There's no feature addition on storm-kafka-client but three issues were fixed. *

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1039 I'm holding a +1 on this until we've gotten a chance to performance test this to ensure there's no unexpected issues. I'll keep everyone informed here when that's done. ---

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1039 I ran this up in full-dev and data flowed through just fine with no errors in the storm logs for any of the topologies. ---

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user cestella commented on the issue: https://github.com/apache/metron/pull/1039 So, this is awesome! I'll spin it up in full-dev and test it out for you today. ---

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user HeartSaVioR commented on the issue: https://github.com/apache/metron/pull/1039 I've rebased to change commit titles slightly, so the build is re-triggered. The build was succeed before rebasing. Travis build in my folk:

[GitHub] metron issue #1039: METRON-1588 Migrate storm-kafka-client to 1.2.1

Github user HeartSaVioR commented on the issue: https://github.com/apache/metron/pull/1039 I've seen Travis CI succeeded in my fork, but unfortunately I don't know how to do manual test with full dev. Much appreciated if reviewers could do the manual validation phase. ---