Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1040
Closing PR that's in the feature branch
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1040
@cestella Before I merge this in, are you okay with this PR doing this for
the existing constant?
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1040
That looks good @justinleet Yeah, I think that key deserves to be in
SolrConstants.
+1 by inspection, pending moving the constant.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1040
@cestella Check out the adjustment for the trim and see how you feel about
it.
Where should solr.zookeeper live? I was a going to drop it in
SolrConstants, but discovered it currently
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1040
I think `solrDao.getSolrClient()` is easier to understand and if I had to
choose I would use that. Very minor though.
For integration testing I think it will take a non-trivial amount of
