Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@nickwallen @tiborm Sorry for the ongoing nature of this PR, but I've made
two small but important updates:
* The first has to do with rxjs import statements that weren't updated
automatically
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1096
@sardell Checked your latest updates and looks straightforward to me. Still
good to go from my side.
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1096
@justinleet @sardell Just to double check I made a full dev rebuild after
fix for metron.spec added. UI builds fine and looks healthy.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@nickwallen I've added the last of my changes. Almost all were related to
review feedback, but I did notice a deprecated class still being imported while
applying these feedback updates. My last 3
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@nickwallen Will do.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@justinleet I tested locally and ran into the same thing. Thanks for
catching this! The spec file has been updated.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1096
@sardell Seems like we are still adding in changes. Let us know when this
has stabilized and is ready to be reviewed.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1096
@sardell To get this running in full dev, I had to change a line in the
metron.spec file for the RPMs to build properly.
`%attr(0644,root,root) %{metron_home}/web/alerts-ui/*.bundle.css`
Github user ruffle1986 commented on the issue:
https://github.com/apache/metron/pull/1096
It has turned out that Angular's changed the way how it renders templates
by default in version 6. Earlier, it preserved whitespaces by default but in
version 6 the `preservedWhitespace` option
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
@justinleet I completely agree. This PR is pretty big, so submitting the
`npm ci` fix in a separate PR would mitigate our risk if trying to include it
in the next release. I created a separate ASF
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1096
Could we migrate the `npm ci` change from [this
discussion](https://lists.apache.org/thread.html/d0da3647f2955b4257c3eb0d89235779aed64a58097b416a18de6cd9@%3Cdev.metron.apache.org%3E)
out to a
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1096
@sardell Can you deconflict this?
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1096
Reviewed +1
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1096
Closing and reopening to re-run Travis.
---
14 matches
Mail list logo
