Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1122
@sardell this is merged. Can you close?
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1122
+1, this there's good stuff here. Thanks!
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1122
The unit tests look good to me. I am +1 contingent on the issues that
@justinleet found are fixed with the recent commits.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@justinleet No problem at all. Those conflicts have now been resolved.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1122
@sardell Heads up, looks like you have some merge conflicts to take care
off.
Thanks for taking care of those, that's a great fix to have in!
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@justinleet Thanks for the feedback. I've updated the panel component to
disable the submit button and display the progress bar on search submit rather
than first response from REST.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1122
Couple quick comments on this after spinning it up.
1. The progress bar doesn't show up until the job submission returns.
However, because this is a MapReduce job, it can take a few seco
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@merrimanr I've increased test coverage in the pcap service to cover all
functions there. I also removed that large set of test pdml data and replaced
it with mock data.
---
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@merrimanr No problem. I began work on the service tests yesterday and
should have time to finish things up later today.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1122
Thanks for the recent changes @sardell. I think we're almost there. Do
you mind taking a look at pcap.service.spec.ts? As far as I can tell only
getPackets is tested and it contains a large amo
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1122
Opened a PR for pcap-packet-line.component.spec.ts. Component covered with
unit test. Size of test data aligned to the needs of the unit tests and shared
across pcap-packet and pcap-packet-line compo
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@merrimanr All tests should run fine now. As @ruffle1986 pointed out, I
accidentally left a focused describe method in my tests, which causes Jasmine
to only execute focused describe blocks. I have
Github user ruffle1986 commented on the issue:
https://github.com/apache/metron/pull/1122
@merrimanr Yes. accidentally, we forgot to change `fdescribe` for
`describe` in the pcap-list component's test file before performing the commit.
It means that the runner runs those tests only.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1122
I tested this in full dev and I think it's working well from a functional
perspective.
I do believe the tests are still lacking though. Here are the issues I
found:
- When I run
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1122
@mmiklavc I've updated my PR description to include a testing section with
steps to reproduce. Please let me know if I can clarify any further.
@justinleet An empty results message is now in
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1122
Right now there's no UI indication that a job has completed with no
results. The download bar finishes, and disappears leaving the user to wonder
where results are. Can we improve that portion
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1122
> Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
>
> Have you included steps or a guide to how the change may be verified and
tested man
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1122
Due to a bug in apache rat, our license checking component, it's ignoring
all license checks on typescript files. I have submitted a PR to up the rat
plugin version and have fixed it in master #11
18 matches
Mail list logo
