[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-29 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 Closed as it is addressed in METRON-1738 ---

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-29 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 closing as it addressed in METRON-1738 ---

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1134 Should this be closed out? ---

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-15 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 I am fine wuth closing this PR as this is currently implemented in REST. When pcap gets its own start/stop script in Ambari we can move the code from REST to respective file. ---

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-14 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1134 The REST component in Ambari is currently responsible for setting up Pcap HDFS directories. It looks like this PR duplicates some of that. I think we will have a dedicated Pcap Ambari component

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-14 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 Non Kerberized pcap topology runs under 'storm' which requires write under the 'hadoop' group so we should provide mode 0775 when the cluster is un secure and mode 0755 when the cluster is secure as

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-10 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 @mmiklavc I see the 'storm' user as the owner of pcap topology in non-kerberized setup, where as the 'metron' as the owner in kerberized setup. IMHO The pcap should have 'metron' as owner of the to

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-09 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/1134 @mmiklavc - in my setup, I have seen that non-kerb requires storm:hadoop permissions, while kerberized needs metron:hadoop for PCAP to write into HDFS. ---

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-08 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1134 @anandsubbu @MohanDV - if we set this to metron:hadoop will that cover both cases? If it does, I would request you make this change in the feature branch. It should work for both kerberized/non-ker

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-08 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/1134 > metron:metron did not allow pcap topology to write as the Storm user. Yup @mmiklavc .. on a non-kerberized cluster, I faced the same issue. ---

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-08 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 Thanks for pointing this out @merrimanr, Yes this will overwrite the the #1019 . If the feature branch is not getting to master sooner then we can keep this change and rebase the feature branch els

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-07 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1134 Good catch @merrimanr https://github.com/apache/metron/pull/1019/files#diff-72aaf03b3dda189de983e94bc8dfcb64R119 When I was testing queries in some other feature branch PR's, I had to

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1134 Just FYI, this work was already done in https://github.com/apache/metron/pull/1019. I do not see much value in merging this into master since it will likely be overwritten when the pcap feature

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-02 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1134 @mmiklavc can you please floor this PR, I have create follow-on Jira [METRON‌-1709 ](https://issues.apache.org/jira/browse/METRON-1709). ---

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-08-01 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1134 See comment here - https://github.com/apache/metron/pull/1132#issuecomment-409656807 I'm +1 via inspection pending a follow-on Jira being created, having it linked to this Jira, and also l

[GitHub] metron issue #1134: METRON-1696: Create the HDFS directory for pcap sequence...

2018-07-31 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1134 @MohanDV thanks for the contribution! I actually have the same concern/thoughts on this PR as I made on @anandsubbu's here - https://github.com/apache/metron/pull/1132#issuecomment-409447590. I thi