Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1142
Thanks for the review!
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1142
This has been merged. Can you close @tiborm?
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1142
+1 pending Travis, thanks for the fixes, this is a great quality of life
improvement!
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1142
You're right. Copy paste issue. Fixed. Thanks!
---
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1142
Thanks, Justin! I replaced the regexp for IP validation and added new tests
to cover that functionality. Nice catch!
I was unable to reproduce the port validation issue you reported.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1142
Hmm, the port errors seem to have been a browser caching issue on the page.
I looked at again and it validate ports properly. Sorry for the false alarm.
---
