[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1165 Thank you guys for the reivew! It seems there is too many issue with the PR. I'm going to close it and open a new one after we fixed the merge issues etc. ---

[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1165 @tiborm - I'm a little uneasy about the merge conflicts and commit history, as pointed out by @merrimanr. The number of changes *seems* relatively small, but per Ryan's review it looks like we had

[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1165 I tested this in full dev and it is not working. The From date is `1969-12-31 18:00:00` and the To date says `Invalid date`. The Src and Dst port fields are also populated with 0. It al

[GitHub] metron issue #1165: METRON-1724: Date/time validation missing in PCAP query

2018-08-15 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1165 Thanks for reviewing! Please test this PR carefully becasue of the large amount of merge conflicts we solved part of this. We tested manually too, but it would be great to double check. All