[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-20 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/1201 Hi @nickwallen , I would like to create a fresh pull request based on these changes. Could you go ahead and merge this please ? ---

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1201 I want to hold off on the merge until we get the pcap properties change sorted on this. @anandsubbu is opening a re-opening a PR on that. ---

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1201 +1 Looks great. Thanks a bunch for the contribution. ---

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1201 > @MohanDV ... pull request 1132. It will be a duplicate effort here. Gotcha. I was not aware of the other PR. That will work. ---

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-20 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1201 @nickwallen having separate panel for PCAP configs is been addressed in the pull request [1132](https://github.com/apache/metron/pull/1132). It will be a duplicate effort here. ---

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1201 The configuration elements for PCAP are still under Metron > Configs > REST. Now that you've added stop/start, I think it would make sense to pull those out into its own component/panel, like th

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1201 Can you merge this with master? It is hard to tell what is part of this PR. ---

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-19 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/1201 @nickwallen It's my bad I dint run this up in Full Dev, I verified my scripts on a 12 node cluster. I did the required changes to support the Full dev deploymwnt and updated the pull request. ---

[GitHub] metron issue #1201: METRON-1709 : Added the required scripts to start / stop...

2018-09-18 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1201 I am not able to spin-up the Full Dev environment with this. It keeps failing here. Have you run this up in Full Dev? ``` TASK [ambari_config : Deploy cluster with Ambari; http://node1:8