[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-04-05 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/942 That works for me. I just wanted to get some community discussion around this. ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-04-20 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/942 Do we think we've reached consensus on this? It seems like avoiding the mixed scenarios is a good thing from a performance perspective, which is key to something like this which will be use

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-04-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/942 I think so. ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-04-24 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/942 If we've reached consensus can I get +1 for this ? ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-05-08 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/942 +1 by inspection, lgtm ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-05-08 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/942 Thanks @cestella . Can you please merge this pull request. ---