Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/967
Still looks fine - tests now passing with 977, lgtm. +1
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
@mmiklavc This is ready to go if you don't mind taking another look at
this. This is not much different than what you have already reviewed.
Since your original review I added another s
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
This should go in after #977
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
The problem is somewhere in Storm's windowing functionality. The time that
it initially recognizes is too far in the future and causes it to mark the
messages sent in as expired. This only occur
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
Of course, now the integration tests don't want to fail.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
Trying to get the integration test to fail again.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
Reopen to trigger CI again
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
I am not sure what is going on. Those tests have never failed when run
under my own Github account.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/967
...Except for the test timeout in Travis
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/967
My +1 still stands. Tests are good, readable.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
Ok fixed that. Had to pull that out my local stash.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/967
Crank. I just noticed that the unit tests that I wrote for this didn't get
added to this branch. Let me correct that. I had added some unit tests
specifically for this.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/967
+1 via inspection
---
13 matches
Mail list logo
