GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/1266
METRON-1875: Expose configurable global settings in the Alerts UI
## Contributor Comments
This PR exposes a JSON file that can be used to configure the Alerts UI.
Properties in this file are
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234283406
--- Diff:
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundat
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287609
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.spec.ts
---
@@ -31,12 +31,20 @@ import { UpdateService
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287807
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.spec.ts
---
@@ -32,6 +32,14 @@ import { UpdateService } f
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287914
--- Diff: metron-interface/metron-alerts/src/app/app.module.ts ---
@@ -48,13 +48,11 @@ import { GlobalConfigService } from
'./service/global-config.service'
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288056
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.spec.ts ---
@@ -33,6 +33,7 @@ import { PcapStatusResponse } from
'../model/pcap-
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288083
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -25,6 +25,7 @@ import { HttpUtil } from '../../utils/httpUtil';
im
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288118
--- Diff: metron-interface/metron-alerts/src/app/service/alerts.service.ts
---
@@ -22,14 +22,15 @@ import {Alert} from '../model/alert';
import { HttpC
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288233
--- Diff:
metron-interface/metron-alerts/src/app/service/global-config.service.ts ---
@@ -21,14 +21,15 @@ import { Injectable } from '@angular/core';
i
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288029
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.spec.ts
---
@@ -28,6 +28,7 @@ import { PcapRequest } from '../model/p
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288184
--- Diff:
metron-interface/metron-alerts/src/app/service/authentication.service.ts ---
@@ -22,26 +22,28 @@ import {Router} from '@angular/router';
impo
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288308
--- Diff: metron-interface/metron-alerts/src/app/service/search.service.ts
---
@@ -30,6 +30,7 @@ import { RestError } from '../model/rest-error';
impor
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288335
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -28,6 +28,7 @@ import {Utils} from '../utils/utils';
import {Patch} f
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288280
--- Diff:
metron-interface/metron-alerts/src/app/service/meta-alert.service.ts ---
@@ -26,14 +26,15 @@ import {Alert} from '../model/alert';
import { H
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234289363
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -47,47 +48,47 @@ export class PcapService {
public submitRequest
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234293206
--- Diff:
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Found
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234296496
--- Diff:
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software Foundat
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1266
---
18 matches
Mail list logo
