[GitHub] [incubator-milagro-crypto-c] gimer edited a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer edited a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689097354 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-milagro-crypto-c] gimer commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689097354 I closed pull request, there's still something wrong, that I'm trying to figure out, will get back with results

[GitHub] [incubator-milagro-crypto-c] gimer removed a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer removed a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689094520 Eh, there's still a bug in the patch. I've assumed every curve has it's own `rom_fields` file (that is _usually_ the case except for `NUMS512E` vs

[GitHub] [incubator-milagro-crypto-c] gimer commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689094520 Eh, there's still a bug in the patch. I've assumed every curve has it's own `rom_fields` file (that is _usually_ the case except for `NUMS512E` vs `NUMS512W`

[GitHub] [incubator-milagro-crypto-c] gimer closed pull request #86: Msvc compilation

2020-09-08 Thread GitBox
gimer closed pull request #86: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-milagro-crypto-c] gimer commented on pull request #86: Msvc compilation

2020-09-08 Thread GitBox
gimer commented on pull request #86: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/86#issuecomment-689032683 I see compilation succeeded, but generating docs failed, will try to check what's going on This

[GitHub] [incubator-milagro-crypto-c] gimer opened a new pull request #86: Msvc compilation

2020-09-08 Thread GitBox
gimer opened a new pull request #86: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/86 details explained in issue #85 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-milagro-crypto-c] kealan commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
kealan commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688982540 It looks good to me. A single pull request would be ok. This is an automated message from the Apache

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
giorgiozoppi commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688938557 Ok i trust Matt work. He is really good person and professional :) This is an automated message

[GitHub] [incubator-milagro-crypto-c] gimer edited a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer edited a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688924815 a) correct me if I'm wrong, but there are no building instructions for ms vs b) answering @giorgiozoppi > VS2019 supports C99 and i suppose C11

[GitHub] [incubator-milagro-crypto-c] gimer edited a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer edited a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688924815 a) correct me if I'm wrong, but there are no building instructions for ms vs b) > VS2019 supports C99 and i suppose C11 I wish that was the

[GitHub] [incubator-milagro-crypto-c] gimer commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688924815 a) correct me if I'm wrong, but there are no building instructions for ms vs b) > VS2019 supports C99 and i suppose C11 I wish that was the case, msdn:

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi removed a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
giorgiozoppi removed a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688913239 VS2019 supports C99 and i suppose C11 This is an automated message from the Apache Git

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
giorgiozoppi commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688913239 VS2019 supports C99 and i suppose C11 This is an automated message from the Apache Git Service.

[GitHub] [incubator-milagro-crypto-c] gimer opened a new issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer opened a new issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85 Hello, We've prepared bunch of changes that enable milagro compilation in MS Visual Studio. The changes can be divided into 3 groups: 1. trivial name<->type clash 2.