howardkitto opened a new issue #40: CreateIdentity() should be private Method URL: https://github.com/apache/incubator-milagro-dta/issues/40 A DTA should only store its own identity secrets. We should remove the public endpoint for creating Identities. The logic for creating identities should be something like this... 1. When the daemon starts up check if the config has and identity AND the secret keys are present (If there is an identity in config but no secret keys in the local store then they will have to be restored from back up) 3. If there is no id in config (e.g. the DTA is running for the first time) then run createIdentity()
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@milagro.apache.org For additional commands, e-mail: issues-h...@milagro.apache.org