[GitHub] [incubator-milagro-MPC] sonarcloud[bot] removed a comment on issue #37: Review suggestions from Mike

2020-04-15 Thread GitBox
sonarcloud[bot] removed a comment on issue #37: Review suggestions from Mike URL: https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-613918020 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC&pullRequest=

[GitHub] [incubator-milagro-MPC] sonarcloud[bot] commented on issue #37: Review suggestions from Mike

2020-04-15 Thread GitBox
sonarcloud[bot] commented on issue #37: Review suggestions from Mike URL: https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-614041731 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC&pullRequest=37&resol

[GitHub] [incubator-milagro-crypto-c] samuele-andreoli merged pull request #80: Review suggestions from Mike

2020-04-16 Thread GitBox
samuele-andreoli merged pull request #80: Review suggestions from Mike URL: https://github.com/apache/incubator-milagro-crypto-c/pull/80 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-milagro-MPC] sonarcloud[bot] removed a comment on issue #37: Review suggestions from Mike

2020-04-16 Thread GitBox
sonarcloud[bot] removed a comment on issue #37: Review suggestions from Mike URL: https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-614041731 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC&pullRequest=

[GitHub] [incubator-milagro-MPC] sonarcloud[bot] commented on issue #37: Review suggestions from Mike

2020-04-16 Thread GitBox
sonarcloud[bot] commented on issue #37: Review suggestions from Mike URL: https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-614573113 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC&pullRequest=37&resol

[GitHub] [incubator-milagro-MPC] samuele-andreoli merged pull request #37: Review suggestions from Mike

2020-04-16 Thread GitBox
samuele-andreoli merged pull request #37: Review suggestions from Mike URL: https://github.com/apache/incubator-milagro-MPC/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi opened a new issue #81: Support of BGV scheme inside milagro

2020-04-17 Thread GitBox
giorgiozoppi opened a new issue #81: Support of BGV scheme inside milagro URL: https://github.com/apache/incubator-milagro-crypto-c/issues/81 Due to the advanced in cloud computing and storage data, a full homomorphic encryption is desired In a nutshell, a fully homomorphic encryption

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi opened a new pull request #82: Added security checks:

2020-04-17 Thread GitBox
giorgiozoppi opened a new pull request #82: Added security checks: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/82 - Removed sprintf for octect/utils conversion - Closed file descriptor for tests (first part) -

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #21: SHA hash might be not initialized correctly

2020-04-17 Thread GitBox
giorgiozoppi commented on issue #21: SHA hash might be not initialized correctly URL: https://github.com/apache/incubator-milagro-crypto-c/issues/21#issuecomment-615490813 The security-checks PR closes this. This is an automa

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi closed issue #21: SHA hash might be not initialized correctly

2020-04-17 Thread GitBox
giorgiozoppi closed issue #21: SHA hash might be not initialized correctly URL: https://github.com/apache/incubator-milagro-crypto-c/issues/21 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-milagro-crypto-c] blenessy opened a new issue #83: Name for Julia bindings

2020-04-20 Thread GitBox
blenessy opened a new issue #83: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/83 Hi guys! Thanks a lot for this wonderful lib! I managed to generate the necessary [bindings](https://github.com/blenessy/AMCL.jl) and expose the complete API of this lib in Julia

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #18: Copying

2020-04-20 Thread GitBox
kirk-baird opened a new pull request #18: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/18 # What has been changed - Copying has been replaced with the compiler optimised `Clone` trait. - Unnecessary variables have been removed where possible. - Constructors

[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on issue #14: Cargo fmt and doc tests fail

2020-04-20 Thread GitBox
kirk-baird commented on issue #14: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/14#issuecomment-616892254 Note `cargo fmt` will work if we call it from `src/` This is an automated message from the Apac

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #19: Improve benchmarking

2020-04-20 Thread GitBox
kirk-baird opened a new issue #19: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/19 # What is the issue Benchmarking currently consists of one file `BenchtestALL.rs`. Thus should be updated to the `cargo bench` format. # Steps to resolve - Move the

[GitHub] [incubator-milagro-crypto-rust] kealan commented on issue #18: Copying

2020-04-21 Thread GitBox
kealan commented on issue #18: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/18#issuecomment-617045455 Hi Kirk There are some conflicts that need resolving for this PR This is an automated message from th

[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on issue #18: Copying

2020-04-21 Thread GitBox
kirk-baird commented on issue #18: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/18#issuecomment-617477819 I've merged `develop` and resolved all of the conflicts so it is ready for merging. This is an a

[GitHub] [incubator-milagro-crypto-c] blenessy commented on issue #83: Name for Julia bindings

2020-04-26 Thread GitBox
blenessy commented on issue #83: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/83#issuecomment-619500510 Going with `MilagroCrypto` then. This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on pull request #82: Added security checks:

2020-04-28 Thread GitBox
giorgiozoppi commented on pull request #82: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/82#issuecomment-620777821 Looks like we have cover all stop. It is perfectly fine to have a %80 of coverage for a complex project like this. Could you relax a bit! -

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi edited a comment on pull request #82: Added security checks:

2020-04-28 Thread GitBox
giorgiozoppi edited a comment on pull request #82: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/82#issuecomment-620777821 Looks like we have cover all stop. It is perfectly fine to have a %80 of coverage for a complex project like this. Could you relax a bit? --

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #20: Hash-to-curve 07

2020-05-03 Thread GitBox
kirk-baird opened a new issue #20: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/20 # What is the issue The BLS standard has updated to [hash-to-curve-07](https://tools.ietf.org/html/draft-irtf-cfrg-hash-to-curve-07). These are breaking changes and need t

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #21: Update to hash-to-curve version 7 for BLS381

2020-05-03 Thread GitBox
kirk-baird opened a new pull request #21: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/21 # Issue Addressed #20 # What has been changed `sgn0` is to be used as parity for field elements. Slight change and DST length to prevent potential length at

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #22: Update hash-to-curve for curves other than BLS381

2020-05-03 Thread GitBox
kirk-baird opened a new issue #22: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/22 # Issue Hash-to-curve functionality has been implemented for BLS381 however it has not been implemented for any other curves. # ToDo Implement `hash-to-curve` for a

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #23: Fix ecp tostring

2020-05-03 Thread GitBox
kirk-baird opened a new pull request #23: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/23 # Issue `ECP::tostring()` was not calling affine before printing the (x, y) coordinates and so they were out by the `Z` factor. # Fix Call `affine()` before ou

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #24: Caching Decoded Objects

2020-05-04 Thread GitBox
kirk-baird opened a new issue #24: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/24 # What is the Issue Many results are converted from raw data (i.e. ints / bytes) many times. These results could be cached to reduce rework. These results can be cached as

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #25: Encoding / Decoding for BLS381

2020-05-04 Thread GitBox
kirk-baird opened a new issue #25: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/25 # What is the issue The standard states the BLS381 should use `points_to_octets` (i.e. ECPx from bytes) in accordance with the ZCash [specification](https://github.com/zkcrypto/

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #26: BLS Specifications Core Operations

2020-05-04 Thread GitBox
kirk-baird opened a new issue #26: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/26 # What is the issue The [BLS-Signature-Standard-v02](https://tools.ietf.org/html/draft-irtf-cfrg-bls-signature-02#section-2) states a range of core operations that need to be im

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #27: BLS Schemes

2020-05-04 Thread GitBox
kirk-baird opened a new issue #27: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/27 # What is the issue There are 3 BLS Schemes in the [BLS-Signature-Standard-v02](https://tools.ietf.org/html/draft-irtf-cfrg-bls-signature-02#section-3). * Basic * Message A

[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on issue #3: BLS Standard

2020-05-04 Thread GitBox
kirk-baird commented on issue #3: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/3#issuecomment-623765043 I've split this into multiple parts and thus closing this in favour of: #22 #25 #26 #27 --

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #28: Rom cleanup

2020-05-04 Thread GitBox
kirk-baird opened a new pull request #28: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/28 # What has been changed Clean up some of the mod files that are initialising empty arrays. Fix mutability from #23 -

[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on pull request #28: Rom cleanup

2020-05-06 Thread GitBox
kirk-baird commented on pull request #28: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/28#issuecomment-624514858 @kealan do you think we would be able to merge this one? This is an automated message from

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #29: Bls core operations and beginnings of an API

2020-05-06 Thread GitBox
kirk-baird opened a new pull request #29: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/29 # Issues Addressed #26 (For BLS381 only) #27 (For BLS381 only) # Additional Comments Replaces #28 This standard will first be implemented for BLS12-3

[GitHub] [incubator-milagro-crypto-rust] kirk-baird edited a comment on pull request #28: Rom cleanup

2020-05-06 Thread GitBox
kirk-baird edited a comment on pull request #28: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/28#issuecomment-624514858 @kealan do you think we would be able to merge this one? #Edit: On second thought never mind I'll close in favour of #29

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #30: Tests HKDF for SHA2-384

2020-05-08 Thread GitBox
kirk-baird opened a new issue #30: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30 # What is the issue There are currently no tests for SHA2-384 (`HASH384`). # What needs to be done Tests need to be written, unfortunately SHA2-384 does not have tes

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #31: Serialisation

2020-05-08 Thread GitBox
kirk-baird opened a new pull request #31: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/31 # Issue Addressed #25 # What has been changes Implementation of the [ZCash](https://github.com/zkcrypto/pairing/blob/master/src/bls12_381/README.md#serializat

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #32: Add compression for `tobytes()` for `ECP` over extensions larger than 1

2020-05-08 Thread GitBox
kirk-baird opened a new issue #32: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/32 # What is the issue Currently `ECP::tobytes()` is the only one with point compression It should be added for `ECP2`, `ECP4`, `ECP8` to half the size of the bytes required.

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #33: Zero all required secrets

2020-05-10 Thread GitBox
kirk-baird opened a new issue #33: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/33 # What is the issue Items such as secret keys should be zeroed before the memory is freed. This can be acomplished through the crate [zeroize](https://docs.rs/zeroize/1.1.

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #34: BLS12-381 Optimise co-factor clearing for G1

2020-05-11 Thread GitBox
kirk-baird opened a new issue #34: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/34 # What is the issue `hash_to_curve()` uses an inefficient cofactor clearing method on G1. # ToDo Consider using `pair::g1mul()` for this. -

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #36: Fuzz BLS381 Serialization

2020-05-14 Thread GitBox
kirk-baird opened a new pull request #36: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/36 # What has been done Fuzz targets for BLS12-381 serialisation have been added to ensure there are no panics in the serialization functions. Fuzzers can be run as foll

[GitHub] [incubator-milagro-MPC] samuele-andreoli opened a new pull request #38: Review ncc

2020-05-15 Thread GitBox
samuele-andreoli opened a new pull request #38: URL: https://github.com/apache/incubator-milagro-MPC/pull/38 Address the findings in the NCC review. * Add UserID and AdditionalData to Schnorr Proofs, double Schnorr Proofs, and the NIZKP of factoring to make them non-replayable. *

[GitHub] [incubator-milagro-MPC] sonarcloud[bot] commented on pull request #38: Review ncc

2020-05-15 Thread GitBox
sonarcloud[bot] commented on pull request #38: URL: https://github.com/apache/incubator-milagro-MPC/pull/38#issuecomment-629102717 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC&pullRequest=38&resolved=false&types=BUG)

[GitHub] [incubator-milagro-MPC] sonarcloud[bot] removed a comment on pull request #38: Review ncc

2020-05-15 Thread GitBox
sonarcloud[bot] removed a comment on pull request #38: URL: https://github.com/apache/incubator-milagro-MPC/pull/38#issuecomment-629102717 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC&pullRequest=38&resolved=false&type

[GitHub] [incubator-milagro-MPC] sonarcloud[bot] commented on pull request #38: Review ncc

2020-05-15 Thread GitBox
sonarcloud[bot] commented on pull request #38: URL: https://github.com/apache/incubator-milagro-MPC/pull/38#issuecomment-629192629 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC&pullRequest=38&resolved=false&types=BUG)

[GitHub] [incubator-milagro-MPC] samuele-andreoli merged pull request #38: Review ncc

2020-05-19 Thread GitBox
samuele-andreoli merged pull request #38: URL: https://github.com/apache/incubator-milagro-MPC/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #37: Subgroup Checks BLS12-381

2020-05-19 Thread GitBox
kirk-baird opened a new issue #37: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/37 # What is the issue Subgroup checks are currently being performed using GLV method for G1 and GS method for G2. This may perform incorrect scalar multiplications for point

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #38: Update modules, bug fixes and rust edition to 2018

2020-05-21 Thread GitBox
kirk-baird opened a new pull request #38: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/38 # What has been done * There was a bug in the curve `fp512bn` on 32 bit OS which would stop it from compiling. * Update rust edition to 2018 * Clean up module dependen

[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #38: Update modules, bug fixes and rust edition to 2018

2020-05-22 Thread GitBox
kealan merged pull request #38: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #36: Fuzz BLS381 Serialization

2020-05-22 Thread GitBox
kealan merged pull request #36: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi merged pull request #82: Added security checks:

2020-05-26 Thread GitBox
giorgiozoppi merged pull request #82: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #10: SonarReport: File is not close

2020-05-26 Thread GitBox
giorgiozoppi commented on issue #10: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/10#issuecomment-634461959 fixed with security checks. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi closed issue #10: SonarReport: File is not close

2020-05-26 Thread GitBox
giorgiozoppi closed issue #10: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #39: Update benches

2020-06-09 Thread GitBox
kirk-baird opened a new pull request #39: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/39 # What has been updated - Benchmarking has been updated to use `cargo bench` though it does not cover all bls functionality yet. - BLS381 SWU constants have been converte

[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #39: Update benches

2020-06-09 Thread GitBox
kealan merged pull request #39: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new issue #40: Straight Line hash-to-curve

2020-06-09 Thread GitBox
kirk-baird opened a new issue #40: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/40 # What is the issue? Hash to curve is currently not constant time. # What needs to be done? Update - SSWU to be straight line. - Make `sgn0()` constant time.

[GitHub] [incubator-milagro-crypto-js] davidkhala opened a new issue #28: official npm publication

2020-07-03 Thread GitBox
davidkhala opened a new issue #28: URL: https://github.com/apache/incubator-milagro-crypto-js/issues/28 While I search on npm.js about nodejs package available for this MCJS. I could only find modules that possibly published by fans from forked version It should be better to have a

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #41: Remove lazy static and other dependencies

2020-07-27 Thread GitBox
kirk-baird opened a new pull request #41: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/41 # What has been changed `lazy_static` and other dependencies have been remove such that `amcl` is stand alone. Note there are still dev dependencies for testing and b

[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #42: Inline operations with large return values

2020-07-29 Thread GitBox
kealan merged pull request #42: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #42: Inline operations with large return values

2020-07-29 Thread GitBox
kirk-baird opened a new pull request #42: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/42 # What has been Changed Operations with a large return value have been set to `#[inline(always)]` so as to reduce the amount of copying to and from the stack for function ca

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #43: Tests big

2020-07-29 Thread GitBox
kirk-baird opened a new pull request #43: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/43 # What has been changed Begin writing tests for `Big` Add rust-doc comments for functions in `Big` Change some function names to match rust formatting. --

[GitHub] [incubator-milagro] davidkhala opened a new issue #32: Where is Milagro Golang now

2020-07-31 Thread GitBox
davidkhala opened a new issue #32: URL: https://github.com/apache/incubator-milagro/issues/32 In the previous archived repos https://github.com/apache/incubator-milagro-crypto/tree/master/version3/go I see there are golang implementation there. Where is it migrated to now?

[GitHub] [incubator-milagro-crypto-c] samuele-andreoli opened a new pull request #84: make comp CT and check octet max len in toHex

2020-08-03 Thread GitBox
samuele-andreoli opened a new pull request #84: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-milagro-crypto-c] samuele-andreoli merged pull request #84: make comp CT and check octet max len in toHex

2020-08-04 Thread GitBox
samuele-andreoli merged pull request #84: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #24: Modern C++17 Wrapper.

2020-08-04 Thread GitBox
giorgiozoppi commented on issue #24: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/24#issuecomment-668504708 we move on this. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-milagro-crypto-c] gimer opened a new issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer opened a new issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85 Hello, We've prepared bunch of changes that enable milagro compilation in MS Visual Studio. The changes can be divided into 3 groups: 1. trivial name<->type clash 2. varia

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
giorgiozoppi commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688913239 VS2019 supports C99 and i suppose C11 This is an automated message from the Apache Git Service.

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi removed a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
giorgiozoppi removed a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688913239 VS2019 supports C99 and i suppose C11 This is an automated message from the Apache Git S

[GitHub] [incubator-milagro-crypto-c] gimer commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688924815 a) correct me if I'm wrong, but there are no building instructions for ms vs b) > VS2019 supports C99 and i suppose C11 I wish that was the case, msdn:

[GitHub] [incubator-milagro-crypto-c] gimer edited a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer edited a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688924815 a) correct me if I'm wrong, but there are no building instructions for ms vs b) > VS2019 supports C99 and i suppose C11 I wish that was the case,

[GitHub] [incubator-milagro-crypto-c] gimer edited a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer edited a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688924815 a) correct me if I'm wrong, but there are no building instructions for ms vs b) answering @giorgiozoppi > VS2019 supports C99 and i suppose C11 I

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
giorgiozoppi commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688938557 Ok i trust Matt work. He is really good person and professional :) This is an automated message

[GitHub] [incubator-milagro-crypto-c] kealan commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
kealan commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688982540 It looks good to me. A single pull request would be ok. This is an automated message from the Apache G

[GitHub] [incubator-milagro-crypto-c] gimer opened a new pull request #86: Msvc compilation

2020-09-08 Thread GitBox
gimer opened a new pull request #86: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/86 details explained in issue #85 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-milagro-crypto-c] gimer commented on pull request #86: Msvc compilation

2020-09-08 Thread GitBox
gimer commented on pull request #86: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/86#issuecomment-689032683 I see compilation succeeded, but generating docs failed, will try to check what's going on This i

[GitHub] [incubator-milagro-crypto-c] gimer closed pull request #86: Msvc compilation

2020-09-08 Thread GitBox
gimer closed pull request #86: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-milagro-crypto-c] gimer commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689094520 Eh, there's still a bug in the patch. I've assumed every curve has it's own `rom_fields` file (that is _usually_ the case except for `NUMS512E` vs `NUMS512W` whic

[GitHub] [incubator-milagro-crypto-c] gimer removed a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer removed a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689094520 Eh, there's still a bug in the patch. I've assumed every curve has it's own `rom_fields` file (that is _usually_ the case except for `NUMS512E` vs `NUMS51

[GitHub] [incubator-milagro-crypto-c] gimer commented on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689097354 I closed pull request, there's still something wrong, that I'm trying to figure out, will get back with results ---

[GitHub] [incubator-milagro-crypto-c] gimer edited a comment on issue #85: Enable MSVC compilation

2020-09-08 Thread GitBox
gimer edited a comment on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-689097354 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #85: Enable MSVC compilation

2020-09-14 Thread GitBox
giorgiozoppi commented on issue #85: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-692265281 @gimer we had an interesting chat at C++Con with msvc team members, they are stating that in th next version they will support C11 features but not optional fea

[GitHub] [incubator-milagro-crypto-rust] gimer opened a new issue #44: Hash-to-curve test vectors are "invisible" on windows

2020-09-16 Thread GitBox
gimer opened a new issue #44: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/44 Due to `:` in filenames, which windows treats as separator for [ADS](https://docs.microsoft.com/en-us/archive/blogs/askcore/alternate-data-streams-in-ntfs). Git is correctly checking

[GitHub] [incubator-milagro-crypto-rust] jon-chuang commented on issue #37: Subgroup Checks BLS12-381

2020-09-22 Thread GitBox
jon-chuang commented on issue #37: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/37#issuecomment-696665334 Hi, we are utilising batch subgroup checks that involve adding to random buckets and repeating to exponentially decrease a bounded error. Stay tuned at Zexe for

[GitHub] [incubator-milagro-crypto-rust] mratsim commented on issue #37: Subgroup Checks BLS12-381

2020-09-22 Thread GitBox
mratsim commented on issue #37: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/37#issuecomment-696739320 See my comment https://github.com/status-im/nim-beacon-chain/issues/1715#issuecomment-696595037 And the "spec-like" notation at https://github.com/pairingwg

[GitHub] [incubator-milagro-crypto-rust] jon-chuang commented on issue #37: Subgroup Checks BLS12-381

2020-09-22 Thread GitBox
jon-chuang commented on issue #37: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/37#issuecomment-696665334 Hi, we are utilising batch subgroup checks that involve adding to random buckets and repeating to exponentially decrease a bounded error. Stay tuned at Zexe for

[GitHub] [incubator-milagro-crypto-rust] mratsim commented on issue #37: Subgroup Checks BLS12-381

2020-09-22 Thread GitBox
mratsim commented on issue #37: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/37#issuecomment-696739320 See my comment https://github.com/status-im/nim-beacon-chain/issues/1715#issuecomment-696595037 And the "spec-like" notation at https://github.com/pairingwg

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #45: Update to bls signatures standard v4

2020-09-29 Thread GitBox
kirk-baird opened a new pull request #45: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/45 # What has been changed BLS12-381 has been updated to version 4 of the BLS signatures standard. The changes are to prevent SK = 0 being a valid key. Also hash to curv

[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #43: Tests big

2020-09-30 Thread GitBox
kealan merged pull request #43: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-milagro-crypto-rust] kealan commented on pull request #45: Update to bls signatures standard v4

2020-09-30 Thread GitBox
kealan commented on pull request #45: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/45#issuecomment-701218944 Hi Kirk There are some conflicts that need to be resolved This is an automated message from th

[GitHub] [incubator-milagro-crypto-rust] mratsim opened a new issue #46: Fused sqrt and invsqrt

2020-09-30 Thread GitBox
mratsim opened a new issue #46: URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/46 In Fp2 sqrt implementation you compute separately square root and inverse square root see https://github.com/apache/incubator-milagro-crypto-rust/blob/7c65ce1f23b906c17e97c479bcf90122b2ed

[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on pull request #45: Update to bls signatures standard v4

2020-09-30 Thread GitBox
kirk-baird commented on pull request #45: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/45#issuecomment-701829810 > Hi Kirk There are some conflicts that need to be resolved Should all be resolved now :) --

[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #45: Update to bls signatures standard v4

2020-10-01 Thread GitBox
kealan merged pull request #45: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #47: Reject secret key zero

2020-10-01 Thread GitBox
kirk-baird opened a new pull request #47: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/47 # What has been done - Reject the a secret key that is zero - Add additional tests for `secret_key_from_bytes()` Signed-off-by: Kirk Baird --

[GitHub] [incubator-milagro-crypto-rust] kealan commented on pull request #47: Reject secret key zero

2020-10-09 Thread GitBox
kealan commented on pull request #47: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/47#issuecomment-706150408 Hi Kirk Could you please email me of connect with me on linkedin as I would like to ask you something https://www.linkedin.com/in/kealan-mccusker-10979426/

[GitHub] [incubator-milagro-crypto-rust] kealan commented on pull request #47: Reject secret key zero

2020-10-09 Thread GitBox
kealan commented on pull request #47: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/47#issuecomment-706150408 Hi Kirk Could you please email me of connect with me on linkedin as I would like to ask you something https://www.linkedin.com/in/kealan-mccusker-10979426/

[GitHub] [incubator-milagro-crypto-rust] kealan merged pull request #47: Reject secret key zero

2020-10-11 Thread GitBox
kealan merged pull request #47: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi closed issue #69: Rust Based Crypto Library (AMCL)

2020-10-14 Thread GitBox
giorgiozoppi closed issue #69: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #9: SonarCube review.

2020-10-14 Thread GitBox
giorgiozoppi commented on issue #9: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/9#issuecomment-708440677 i added this so i close this as well. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi closed issue #9: SonarCube review.

2020-10-14 Thread GitBox
giorgiozoppi closed issue #9: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on issue #69: Rust Based Crypto Library (AMCL)

2020-10-14 Thread GitBox
giorgiozoppi commented on issue #69: URL: https://github.com/apache/incubator-milagro-crypto-c/issues/69#issuecomment-708440411 we have this i close this issue This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-milagro-crypto-rust] kirk-baird opened a new pull request #48: Make naming windows friendly

2020-11-09 Thread GitBox
kirk-baird opened a new pull request #48: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/48 # What has been done - Renamed files to remove `:` such that they are windows friendly. - Update tests accordingly --

[GitHub] [incubator-milagro-crypto-rust] kirk-baird commented on pull request #48: Make naming windows friendly

2020-11-09 Thread GitBox
kirk-baird commented on pull request #48: URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/48#issuecomment-724442310 Solves #44 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-milagro-crypto-c] kealan opened a new pull request #87: fix typo

2020-12-02 Thread GitBox
kealan opened a new pull request #87: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/87 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

<    1   2   3   4   5   6   7   8   >