[GitHub] [nifi] woutifier-t commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
woutifier-t commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r368851237 ## File path:

[jira] [Commented] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2020-01-20 Thread Dariusz Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019888#comment-17019888 ] Dariusz Chmielewski commented on NIFI-7012: --- Thank you. Let me know if I can help with anything.

[jira] [Commented] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2020-01-20 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019790#comment-17019790 ] Andy LoPresto commented on NIFI-7012: - I was able to reproduce the issue. Will try to resolve it. >

[jira] [Assigned] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2020-01-20 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto reassigned NIFI-7012: --- Assignee: Andy LoPresto > Using sensitive parameter in sensitive property of

[jira] [Created] (NIFI-7048) Unit tests should not fail if JAVA_HOME set incorrectly

2020-01-20 Thread Andy LoPresto (Jira)
Andy LoPresto created NIFI-7048: --- Summary: Unit tests should not fail if JAVA_HOME set incorrectly Key: NIFI-7048 URL: https://issues.apache.org/jira/browse/NIFI-7048 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on issue #656: MINIFI-1013 Used soci library.

2020-01-20 Thread GitBox
am-c-p-p commented on issue #656: MINIFI-1013 Used soci library. URL: https://github.com/apache/nifi-minifi-cpp/pull/656#issuecomment-576458801 @bakaid I made modifications by removing s_outputFormatJSON, s_outputFormatJSONPretty from OutputFormat.h since they don't need to be exposed.

[jira] [Commented] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2020-01-20 Thread Dariusz Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019682#comment-17019682 ] Dariusz Chmielewski commented on NIFI-7012: --- Can anyone confirm if it's reproducible? For some

[jira] [Updated] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2020-01-20 Thread Dariusz Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dariusz Chmielewski updated NIFI-7012: -- Description: To simulate this add a new InvokeScriptedProcessor to your flow with

[jira] [Updated] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2020-01-20 Thread Dariusz Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dariusz Chmielewski updated NIFI-7012: -- Component/s: Core Framework > Using sensitive parameter in sensitive property of

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368678166 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6 +647,17

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368678139 ## File path: extensions/librdkafka/PublishKafka.h ## @@ -193,121 +186,150

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368678090 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -99,6 +99,14 @@

[GitHub] [nifi] tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r368657405 ## File path:

[GitHub] [nifi] tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r368658975 ## File path:

[GitHub] [nifi] tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r368659695 ## File path:

[GitHub] [nifi] tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r368672071 ## File path:

[GitHub] [nifi] tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
tpalfy commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r368646980 ## File path:

[GitHub] [nifi-minifi-cpp] bakaid commented on issue #656: MINIFI-1013 Used soci library.

2020-01-20 Thread GitBox
bakaid commented on issue #656: MINIFI-1013 Used soci library. URL: https://github.com/apache/nifi-minifi-cpp/pull/656#issuecomment-576349582 @am-c-p-p I have tested the functionality of the PR on the following branch: https://github.com/bakaid/nifi-minifi-cpp/commits/minifi-1013-soci-test

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368600603 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6 +647,17

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368599433 ## File path: extensions/librdkafka/PublishKafka.h ## @@ -193,121 +186,150

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368584995 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6 +647,17

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368582441 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6 +647,17

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368581719 ## File path: extensions/librdkafka/PublishKafka.h ## @@ -193,121

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368581179 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -99,6 +99,14

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368581257 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368580497 ## File path: extensions/librdkafka/PublishKafka.h ## @@ -193,121 +186,150

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368579443 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6 +647,17

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368579900 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -99,6 +99,14 @@

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368568039 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368570789 ## File path: extensions/librdkafka/PublishKafka.h ## @@ -193,121

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368575021 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -639,6

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368569213 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -99,6 +99,14

[GitHub] [nifi] woutifier-t commented on issue #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
woutifier-t commented on issue #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#issuecomment-576290956 The build is failing because of some http/https issue with maven (I believe unrelated to the commits in this

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-20 Thread GitBox
arpadboda closed pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709 This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi-minifi-cpp] szaszm edited a comment on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm edited a comment on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#issuecomment-576289051 What is your opinion on using `const` by default, i.e. always, unless there's a reason not to?

[GitHub] [nifi-minifi-cpp] szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm commented on issue #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712#issuecomment-576289051 What is your opinion on using `const` by default? Pros: * extra static analysis -> bugs caught

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka

2020-01-20 Thread GitBox
szaszm opened a new pull request #712: MINIFICPP-1047 Add property "Drop empty flow files" to PublishKafka URL: https://github.com/apache/nifi-minifi-cpp/pull/712 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the

[GitHub] [nifi] woutifier-t commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor.

2020-01-20 Thread GitBox
woutifier-t commented on a change in pull request #3977: NIFI-7007 Add update functionality to the PutCassandraRecord processor. URL: https://github.com/apache/nifi/pull/3977#discussion_r368522537 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #710: WIP: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and

2020-01-20 Thread GitBox
szaszm commented on a change in pull request #710: WIP: MINIFICPP - 1110, - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r368467670 ## File path: extensions/opc/src/fetchopc.cpp ## @@ -93,14 +93,12

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-20 Thread GitBox
am-c-p-p commented on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#issuecomment-576176249 I built installer, installed, server was running, log created under {installedDir}/Log. LGTM.

[GitHub] [nifi-minifi-cpp] am-c-p-p edited a comment on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-20 Thread GitBox
am-c-p-p edited a comment on issue #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#issuecomment-576176249 On Windows, I built installer, installed, server was running, log created under {installedDir}/Log. LGTM.