[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-15 Thread GitBox
arpadboda commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455522730 ## File path: libminifi/test/unit/TimeUtilTests.cpp ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-15 Thread GitBox
arpadboda commented on a change in pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840#discussion_r455522730 ## File path: libminifi/test/unit/TimeUtilTests.cpp ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #836: MINIFICPP-1248 Create unit tests for the ConsumeWindowsEventLog processor

2020-07-15 Thread GitBox
arpadboda closed pull request #836: URL: https://github.com/apache/nifi-minifi-cpp/pull/836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi] esecules commented on pull request #4401: NIFI-7622 Use param context name from inside nested versioned PG when…

2020-07-15 Thread GitBox
esecules commented on pull request #4401: URL: https://github.com/apache/nifi/pull/4401#issuecomment-659026103 This exception only gets thrown when you're pulling the flow from the registry. It would be better if it blocked versioning it to the registry in the first place.

[jira] [Updated] (NIFI-7645) Implement AMQPRecord processors

2020-07-15 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-7645: -- Description: Reimplement PublishAMQP / ConsumeAMQP processors * support record oriented

[jira] [Updated] (NIFI-7645) Implement AMQPRecord processors

2020-07-15 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-7645: -- Component/s: Extensions > Implement AMQPRecord processors > --- > >

[jira] [Commented] (NIFI-6312) AMQP processors seem to have thread cleanup issues

2020-07-15 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158707#comment-17158707 ] Peter Turcsanyi commented on NIFI-6312: --- Opened a PR ([https://github.com/apache/nifi/pull/4411])

[jira] [Updated] (NIFI-6312) AMQP processors seem to have thread cleanup issues

2020-07-15 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-6312: -- Status: Patch Available (was: Open) > AMQP processors seem to have thread cleanup issues >

[GitHub] [nifi] turcsanyip opened a new pull request #4411: NIFI-6312: Improved connection handling in AMQP processors

2020-07-15 Thread GitBox
turcsanyip opened a new pull request #4411: URL: https://github.com/apache/nifi/pull/4411 Disable connection automatic recovery which can lead to uncontrolled/stale threads. Handle the recovery in the processors instead. Use poisoning in case of errors, then discarding and recreating

[jira] [Assigned] (NIFI-6312) AMQP processors seem to have thread cleanup issues

2020-07-15 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi reassigned NIFI-6312: - Assignee: Peter Turcsanyi > AMQP processors seem to have thread cleanup issues >

[jira] [Created] (NIFI-7645) Implement AMQPRecord processors

2020-07-15 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-7645: - Summary: Implement AMQPRecord processors Key: NIFI-7645 URL: https://issues.apache.org/jira/browse/NIFI-7645 Project: Apache NiFi Issue Type: Improvement

[jira] [Commented] (NIFI-7628) Parameter context in multi tenant environment

2020-07-15 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158700#comment-17158700 ] Bryan Bende commented on NIFI-7628: --- You can also have read/write policies on parameter contexts, in

[jira] [Created] (NIFI-7644) New Relic reporting task

2020-07-15 Thread Ihar Hulevich (Jira)
Ihar Hulevich created NIFI-7644: --- Summary: New Relic reporting task Key: NIFI-7644 URL: https://issues.apache.org/jira/browse/NIFI-7644 Project: Apache NiFi Issue Type: New Feature

[jira] [Updated] (NIFI-7643) Unpackcontent writing absolute path property does not make sense

2020-07-15 Thread Jira
[ https://issues.apache.org/jira/browse/NIFI-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Bunth updated NIFI-7643: -- Description: Steps to reproduce: # Create a tar or zip file with some arbitrary content in its root.

[jira] [Created] (NIFI-7643) Unpackcontent writing absolute path property does not make sense

2020-07-15 Thread Jira
Tamás Bunth created NIFI-7643: - Summary: Unpackcontent writing absolute path property does not make sense Key: NIFI-7643 URL: https://issues.apache.org/jira/browse/NIFI-7643 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #836: MINIFICPP-1248 Create unit tests for the ConsumeWindowsEventLog processor

2020-07-15 Thread GitBox
arpadboda commented on pull request #836: URL: https://github.com/apache/nifi-minifi-cpp/pull/836#issuecomment-658855469 @fgerlits : The stringutils part seems to fail on gcc: https://travis-ci.org/github/apache/nifi-minifi-cpp/jobs/708347373

[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #821: MINIFICPP-1251 - Implement and test RetryFlowFile processor

2020-07-15 Thread GitBox
arpadboda commented on pull request #821: URL: https://github.com/apache/nifi-minifi-cpp/pull/821#issuecomment-658816200 @hunyadi-dev : could you rebase and push? The changes look good to me, but I would like to see it build on Win without errors.

[GitHub] [nifi] goosalex opened a new pull request #4410: NIFI-7642: Improve batching into FlowFiles under high latency conditions

2020-07-15 Thread GitBox
goosalex opened a new pull request #4410: URL: https://github.com/apache/nifi/pull/4410 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Improves receiving large batches of Kafka messages

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #840: MINIFICPP-1293 Fix the failing PropertyTests

2020-07-15 Thread GitBox
fgerlits opened a new pull request #840: URL: https://github.com/apache/nifi-minifi-cpp/pull/840 See https://issues.apache.org/jira/browse/MINIFICPP-1293 for the description of the bug. Description of the change: instead of using `mktime` and adjusting by the time zone offset, use

[GitHub] [nifi] goosalex closed pull request #4409: Nifi 7642 - Wire KafkaConsumer properties instead of magic numbers to improve batching into fewer FlowFiles under high latency conditions

2020-07-15 Thread GitBox
goosalex closed pull request #4409: URL: https://github.com/apache/nifi/pull/4409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #833: MINIFICPP-1272 - Graceful shutdown on flow update

2020-07-15 Thread GitBox
arpadboda commented on a change in pull request #833: URL: https://github.com/apache/nifi-minifi-cpp/pull/833#discussion_r455083609 ## File path: libminifi/src/core/ProcessGroup.cpp ## @@ -412,6 +414,18 @@ void ProcessGroup::drainConnections() { } } +std::size_t

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #833: MINIFICPP-1272 - Graceful shutdown on flow update

2020-07-15 Thread GitBox
arpadboda commented on a change in pull request #833: URL: https://github.com/apache/nifi-minifi-cpp/pull/833#discussion_r455083106 ## File path: libminifi/test/flow-tests/FlowControllerTests.cpp ## @@ -119,7 +107,125 @@ TEST_CASE("Flow shutdown drains connections",

[GitHub] [nifi] goosalex opened a new pull request #4409: Nifi 7642 - Wire KafkaConsumer properties instead of magic numbers to improve batching into fewer FlowFiles under high latency conditions

2020-07-15 Thread GitBox
goosalex opened a new pull request #4409: URL: https://github.com/apache/nifi/pull/4409 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Improves receiving large batches of Kafka messages

[jira] [Updated] (NIFI-7628) Parameter context in multi tenant environment

2020-07-15 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7628: - Component/s: SDLC Flow Versioning > Parameter context in multi tenant

[jira] [Commented] (NIFI-7628) Parameter context in multi tenant environment

2020-07-15 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158178#comment-17158178 ] Pierre Villard commented on NIFI-7628: -- Not sure to understand the request here. A parameter context

[jira] [Updated] (NIFI-7628) Parameter context in multi tenant environment

2020-07-15 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7628: - Issue Type: Improvement (was: Bug) > Parameter context in multi tenant environment >

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #838: MINIFICPP-1183 Fix Windows compile errors

2020-07-15 Thread GitBox
arpadboda closed pull request #838: URL: https://github.com/apache/nifi-minifi-cpp/pull/838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (NIFIREG-344) ClientUtils reads "Content-Disposition" before checking status code

2020-07-15 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFIREG-344: Fix Version/s: (was: 0.7.0) > ClientUtils reads "Content-Disposition" before checking status

[jira] [Updated] (NIFIREG-292) Add database implementations of UserGroupProvider and AccessPolicyProvider

2020-07-15 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFIREG-292: Fix Version/s: (was: 0.7.0) > Add database implementations of UserGroupProvider and

[jira] [Resolved] (NIFIREG-321) Integrate nifi-registry-revsion into REST API and service layers

2020-07-15 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-321. - Resolution: Fixed > Integrate nifi-registry-revsion into REST API and service layers >

[jira] [Created] (NIFIREG-404) Perform release manager activities for 0.7.0 release

2020-07-15 Thread Bryan Bende (Jira)
Bryan Bende created NIFIREG-404: --- Summary: Perform release manager activities for 0.7.0 release Key: NIFIREG-404 URL: https://issues.apache.org/jira/browse/NIFIREG-404 Project: NiFi Registry

[jira] [Resolved] (NIFIREG-381) Skip integration tests in Github CI/Actions

2020-07-15 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFIREG-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-381. - Resolution: Fixed > Skip integration tests in Github CI/Actions >

[jira] [Updated] (NIFI-7642) KafkaConsumers: Improve batching into fewer FlowFiles under high latency conditions

2020-07-15 Thread Alex Goos (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Goos updated NIFI-7642: Summary: KafkaConsumers: Improve batching into fewer FlowFiles under high latency conditions (was:

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r455004287 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -540,111 +481,97 @@ void ProcessSession::import(const std::string& source,

[jira] [Created] (MINIFICPP-1294) Move stream ref counting to the ResourceClaim class

2020-07-15 Thread Adam Debreceni (Jira)
Adam Debreceni created MINIFICPP-1294: - Summary: Move stream ref counting to the ResourceClaim class Key: MINIFICPP-1294 URL: https://issues.apache.org/jira/browse/MINIFICPP-1294 Project: Apache

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r455004287 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -540,111 +481,97 @@ void ProcessSession::import(const std::string& source,

[jira] [Updated] (NIFI-7642) KafkaConsumers: Improve batching into fewer FlowFiles under high latency conditios

2020-07-15 Thread Alex Goos (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Goos updated NIFI-7642: Labels: kafka (was: ) > KafkaConsumers: Improve batching into fewer FlowFiles under high latency >

[jira] [Created] (NIFI-7642) KafkaConsumers: Improve batching into fewer FlowFiles under high latency conditios

2020-07-15 Thread Alex Goos (Jira)
Alex Goos created NIFI-7642: --- Summary: KafkaConsumers: Improve batching into fewer FlowFiles under high latency conditios Key: NIFI-7642 URL: https://issues.apache.org/jira/browse/NIFI-7642 Project: Apache

[jira] [Created] (NIFI-7641) NullPointerException with ExecuteFlumeSource

2020-07-15 Thread Pierre Villard (Jira)
Pierre Villard created NIFI-7641: Summary: NullPointerException with ExecuteFlumeSource Key: NIFI-7641 URL: https://issues.apache.org/jira/browse/NIFI-7641 Project: Apache NiFi Issue Type:

[jira] [Created] (NIFI-7640) HandleHttpRequest - define temporary files location

2020-07-15 Thread Pierre Villard (Jira)
Pierre Villard created NIFI-7640: Summary: HandleHttpRequest - define temporary files location Key: NIFI-7640 URL: https://issues.apache.org/jira/browse/NIFI-7640 Project: Apache NiFi Issue

[GitHub] [nifi] KuKuDeCheng commented on pull request #4326: NIFI-7519:Add a ExecuteSQL property on DBCPConnectionPool

2020-07-15 Thread GitBox
KuKuDeCheng commented on pull request #4326: URL: https://github.com/apache/nifi/pull/4326#issuecomment-658667516 > I'm not change about github checks error. > I run this check successful on my compute. You need update DatabaseRecordSinkTest.java. Add your ExecuteSQL property

[jira] [Updated] (NIFI-7635) Fix StandardConfigurationContext to read the default property value from its ComponentNode instance

2020-07-15 Thread Peter Gyori (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gyori updated NIFI-7635: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Fix StandardConfigurationContext

[GitHub] [nifi] pgyori commented on pull request #4408: NIFI-7635: StandardConfigurationContext.getProperty() gets the proper…

2020-07-15 Thread GitBox
pgyori commented on pull request #4408: URL: https://github.com/apache/nifi/pull/4408#issuecomment-658628455 Thank you, @markap14 ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454874069 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -540,111 +481,97 @@ void ProcessSession::import(const std::string& source,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454874069 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -540,111 +481,97 @@ void ProcessSession::import(const std::string& source,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454871893 ## File path: extensions/rocksdb-repos/FlowFileRepository.cpp ## @@ -148,22 +148,27 @@ void FlowFileRepository::prune_stored_flowfiles() {

[jira] [Commented] (NIFI-6061) PutDatabaseRecord does not properly handle BLOB/CLOB fields

2020-07-15 Thread ZhangCheng (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157981#comment-17157981 ] ZhangCheng commented on NIFI-6061: -- For Oracle TIMESTAMP field, when PutDatabaseRecord tries to insert it

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454824460 ## File path: libminifi/include/core/Repository.h ## @@ -228,6 +232,8 @@ class Repository : public virtual core::SerializableComponent,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454842291 ## File path: libminifi/include/core/FlowFile.h ## @@ -35,9 +35,56 @@ namespace minifi { namespace core { class FlowFile : public

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454839615 ## File path: libminifi/test/persistence-tests/PersistenceTests.cpp ## @@ -0,0 +1,218 @@ +/** + * + * Licensed to the Apache Software

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454836324 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -540,111 +481,97 @@ void ProcessSession::import(const std::string& source,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454834083 ## File path: libminifi/src/FlowFileRecord.cpp ## @@ -118,28 +110,27 @@ FlowFileRecord::~FlowFileRecord() { logger_->log_debug("Delete

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454833537 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -248,35 +237,27 @@ void ProcessSession::penalize(const std::shared_ptr ) { void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454833537 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -248,35 +237,27 @@ void ProcessSession::penalize(const std::shared_ptr ) { void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454833537 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -248,35 +237,27 @@ void ProcessSession::penalize(const std::shared_ptr ) { void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454833537 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -248,35 +237,27 @@ void ProcessSession::penalize(const std::shared_ptr ) { void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454831606 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -211,15 +206,6 @@ std::shared_ptr ProcessSession::clone(const std::shared_ptr ) {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #807: MINIFICPP-1228 - Resource ownership refactor + flowFile-owning processors.

2020-07-15 Thread GitBox
adamdebreceni commented on a change in pull request #807: URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r454824460 ## File path: libminifi/include/core/Repository.h ## @@ -228,6 +232,8 @@ class Repository : public virtual core::SerializableComponent,