[
https://issues.apache.org/jira/browse/NIFI-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261747#comment-17261747
]
ZhangCheng commented on NIFI-8101:
--
Hi [~mattyb149],happy new year!
Firstly ,it would be
exceptionfactory commented on pull request #4734:
URL: https://github.com/apache/nifi/pull/4734#issuecomment-757089861
@turcsanyip The other use of `AvroTypeUtil.LOGICAL_TYPE_DATE` was in the
`normalizeValue()`, which was causing the problem with `ConvertRecord`. The
use of `new java.sql.
exceptionfactory commented on pull request #4729:
URL: https://github.com/apache/nifi/pull/4729#issuecomment-757076803
Thanks for the review and testing @thenatog!
This is an automated message from the Apache Git Service.
To
thenatog commented on pull request #4729:
URL: https://github.com/apache/nifi/pull/4729#issuecomment-757070464
Looks good to me, I set up a cluster using a BCFKS keystore and again just
using JKS to check backwards compatibility. Also created a InvokeHTTP processor
using BCFKS as the keyst
MikeThomsen commented on a change in pull request #4739:
URL: https://github.com/apache/nifi/pull/4739#discussion_r554147955
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
MikeThomsen commented on a change in pull request #4739:
URL: https://github.com/apache/nifi/pull/4739#discussion_r554147729
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
Jon Kessler created NIFI-8126:
-
Summary: Include Total Queued Duration in metrics reported via
ConnectionStatus
Key: NIFI-8126
URL: https://issues.apache.org/jira/browse/NIFI-8126
Project: Apache NiFi
[
https://issues.apache.org/jira/browse/NIFI-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-8120:
--
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available
[
https://issues.apache.org/jira/browse/NIFI-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261457#comment-17261457
]
ASF subversion and git services commented on NIFI-8120:
---
Commit a402
[
https://issues.apache.org/jira/browse/NIFI-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261456#comment-17261456
]
ASF subversion and git services commented on NIFI-8120:
---
Commit a402
asfgit closed pull request #4747:
URL: https://github.com/apache/nifi/pull/4747
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Bryan Bende created NIFI-8125:
-
Summary: Provide a way to prefer JWT when client cert is present
Key: NIFI-8125
URL: https://issues.apache.org/jira/browse/NIFI-8125
Project: Apache NiFi
Issue Typ
arpadboda closed pull request #969:
URL: https://github.com/apache/nifi-minifi-cpp/pull/969
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
urbandan commented on a change in pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#discussion_r554047254
##
File path:
nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceConnector.java
##
@@ -0,
thenatog commented on pull request #4729:
URL: https://github.com/apache/nifi/pull/4729#issuecomment-756837064
Reviewing
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/MINIFICPP-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gyimesi resolved MINIFICPP-1396.
--
Resolution: Fixed
> Create FetchS3Object processor
> --
exceptionfactory commented on pull request #4747:
URL: https://github.com/apache/nifi/pull/4747#issuecomment-756821716
@turcsanyip Thanks for the review and detailed feedback. I pushed an update
incorporating your recommendations.
-
exceptionfactory commented on a change in pull request #4747:
URL: https://github.com/apache/nifi/pull/4747#discussion_r554015927
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java
szaszm closed pull request #895:
URL: https://github.com/apache/nifi-minifi-cpp/pull/895
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
exceptionfactory commented on a change in pull request #4747:
URL: https://github.com/apache/nifi/pull/4747#discussion_r554015409
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java
arpadboda closed pull request #970:
URL: https://github.com/apache/nifi-minifi-cpp/pull/970
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
turcsanyip commented on a change in pull request #4747:
URL: https://github.com/apache/nifi/pull/4747#discussion_r554009142
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java
##
szaszm commented on pull request #973:
URL: https://github.com/apache/nifi-minifi-cpp/pull/973#issuecomment-756767879
A bit more info after trying to build this PR:
```
szaszm@szaszm-pc:~/nifi-minifi-cpp-2/cmake-build-relwithdebinfo-gcc-large$
find -name libsoci_odbc.a
./extension
arpadboda commented on pull request #973:
URL: https://github.com/apache/nifi-minifi-cpp/pull/973#issuecomment-756765763
> Not debian, but I get this error when trying to build this PR with SQL
enabled
> `make[2]: *** No rule to make target
'extensions/sql/thirdparty/iodbc-install//lib6
szaszm commented on pull request #973:
URL: https://github.com/apache/nifi-minifi-cpp/pull/973#issuecomment-756763519
Not debian, but I get this error when trying to build this PR with SQL
enabled
```make[2]: *** No rule to make target
'extensions/sql/thirdparty/iodbc-install//lib64/lib
urbandan commented on a change in pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#discussion_r553786280
##
File path:
nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSinkTask.java
##
@@ -0,0 +1,28
moranr commented on pull request #4563:
URL: https://github.com/apache/nifi/pull/4563#issuecomment-756752576
@NissimShiman – good catch. That style text is used elsewhere in that way,
so I'd say you're correct to apply here as well. Looks good to me; thanks for
your work and attention to d
heritamas commented on a change in pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#discussion_r553931809
##
File path:
nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/StatelessNiFiSourceTask.java
##
@@ -0,0 +1
exceptionfactory commented on pull request #4749:
URL: https://github.com/apache/nifi/pull/4749#issuecomment-756743075
Thanks for the review and testing @turcsanyip!
This is an automated message from the Apache Git Service.
T
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553914086
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,582 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553912946
##
File path: libminifi/include/core/FlowFile.h
##
@@ -134,7 +135,9 @@ class FlowFile : public CoreComponent, public
ReferenceContainer {
*
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553912615
##
File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp
##
@@ -0,0 +1,590 @@
+
+/**
+ * Licensed to the Apache Software Foundation (ASF)
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553912267
##
File path: extensions/librdkafka/docker_tests/CMakeLists.txt
##
@@ -0,0 +1,36 @@
+#
Review comment:
I mean these will sit in docker,
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553911182
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,582 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553906593
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,115 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553906593
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,115 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553906201
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553905938
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553901711
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #895:
URL: https://github.com/apache/nifi-minifi-cpp/pull/895#discussion_r553901250
##
File path: extensions/civetweb/processors/ListenHTTP.cpp
##
@@ -211,7 +211,7 @@ void ListenHTTP::onSchedule(core::ProcessContext *context,
c
szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553897459
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,115 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553895379
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,115 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553893682
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553893682
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553891631
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,115 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553890971
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,115 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553890911
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,115 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553890229
##
File path: extensions/librdkafka/rdkafka_utils.h
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev closed pull request #911:
URL: https://github.com/apache/nifi-minifi-cpp/pull/911
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553882120
##
File path: libminifi/test/TestBase.cpp
##
@@ -62,78 +63,51 @@ TestPlan::~TestPlan() {
for (auto& processor : configured_processors_) {
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553877982
##
File path: libminifi/include/utils/ProcessorConfigUtils.h
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553877279
##
File path: libminifi/include/core/TypedValues.h
##
@@ -106,6 +106,8 @@ class TimePeriodValue : public TransformableValue, public
state::resp
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553871478
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,553 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553850276
##
File path: libminifi/include/utils/ProcessorConfigUtils.h
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/NIFI-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261121#comment-17261121
]
fossilfuelsbeer commented on NIFI-1193:
---
[https://fossilfuelsbeer.com/|https://fossi
lfrancke closed pull request #1941:
URL: https://github.com/apache/nifi/pull/1941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553806575
##
File path: libminifi/include/utils/ProcessorConfigUtils.h
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
lfrancke closed pull request #2985:
URL: https://github.com/apache/nifi/pull/2985
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r553796377
##
File path: libminifi/include/utils/ProcessorConfigUtils.h
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
59 matches
Mail list logo
