[GitHub] [nifi] exceptionfactory commented on a change in pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
exceptionfactory commented on a change in pull request #5301: URL: https://github.com/apache/nifi/pull/5301#discussion_r686422538 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-neo4j-cypher-service/src/main/java/org/apache/nifi/graph/Neo4jCypherClientService.java ## @@

[GitHub] [nifi] github-actions[bot] closed pull request #2231: NIFI-4521 MS SQL CDC Processor

2021-08-10 Thread GitBox
github-actions[bot] closed pull request #2231: URL: https://github.com/apache/nifi/pull/2231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nifi] MikeThomsen commented on pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
MikeThomsen commented on pull request #5301: URL: https://github.com/apache/nifi/pull/5301#issuecomment-896384437 @exceptionfactory I think we're good now on your feedback. Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nifi] MikeThomsen commented on a change in pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
MikeThomsen commented on a change in pull request #5301: URL: https://github.com/apache/nifi/pull/5301#discussion_r686384633 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-neo4j-3x-cypher-service/src/main/java/org/apache/nifi/graph/Neo4JCypher3xClientService.java ## @@

[GitHub] [nifi] MikeThomsen commented on a change in pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
MikeThomsen commented on a change in pull request #5301: URL: https://github.com/apache/nifi/pull/5301#discussion_r686381039 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-neo4j-3x-cypher-service-nar/src/main/resources/META-INF/NOTICE ## @@ -0,0 +1,152 @@

[GitHub] [nifi] MikeThomsen commented on a change in pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
MikeThomsen commented on a change in pull request #5301: URL: https://github.com/apache/nifi/pull/5301#discussion_r686380831 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-neo4j-3x-cypher-service/src/main/java/org/apache/nifi/graph/Neo4JCypher3xClientService.java ## @@

[GitHub] [nifi] MikeThomsen commented on pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
MikeThomsen commented on pull request #5301: URL: https://github.com/apache/nifi/pull/5301#issuecomment-896371714 > This looks good, just wondering if we should keep the existing service at the existing version and add 2 new services for 3.x and 4.x, or is the existing version just too

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5195: NIFI-8752: Automatic diagnostic at NiFi restart/stop

2021-08-10 Thread GitBox
exceptionfactory commented on a change in pull request #5195: URL: https://github.com/apache/nifi/pull/5195#discussion_r686331538 ## File path: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java ## @@ -303,6 +303,18 @@ public static final

[GitHub] [nifi] exceptionfactory commented on pull request #5274: NIFI-6615 Add Azure Sensitive Property Provider

2021-08-10 Thread GitBox
exceptionfactory commented on pull request #5274: URL: https://github.com/apache/nifi/pull/5274#issuecomment-896316807 @emiliosetiadarma Thanks for addressing the current feedback. This looks close to completion. Can you rebase on main and squash your commits? The current branch includes

[jira] [Updated] (NIFI-8980) Integrate KerberosUserService with Kafka processors

2021-08-10 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-8980: -- Assignee: Bryan Bende Status: Patch Available (was: Open) > Integrate KerberosUserService with

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
exceptionfactory commented on a change in pull request #5301: URL: https://github.com/apache/nifi/pull/5301#discussion_r686291672 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-neo4j-3x-cypher-service/pom.xml ## @@ -0,0 +1,104 @@ +http://maven.apache.org/POM/4.0.0;

[GitHub] [nifi] mattyb149 commented on pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
mattyb149 commented on pull request #5301: URL: https://github.com/apache/nifi/pull/5301#issuecomment-896296299 This looks good, just wondering if we should keep the existing service at the existing version and add 2 new services for 3.x and 4.x, or is the existing version just too

[jira] [Updated] (NIFI-5936) MockProcessSession remove() does not report a "DROP" provenance event

2021-08-10 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-5936: --- Status: Patch Available (was: In Progress) > MockProcessSession remove() does not report a "DROP"

[jira] [Assigned] (NIFI-5936) MockProcessSession remove() does not report a "DROP" provenance event

2021-08-10 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-5936: -- Assignee: Matt Burgess > MockProcessSession remove() does not report a "DROP" provenance event

[GitHub] [nifi] mattyb149 opened a new pull request #5302: NIFI-5936: Added DROP provenance event to MockProcessSession.remove to match real impl

2021-08-10 Thread GitBox
mattyb149 opened a new pull request #5302: URL: https://github.com/apache/nifi/pull/5302 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Aligns the behavior between MockProcessSession

[jira] [Updated] (NIFI-9021) MiNiFi Java flows can't use ListenHttp

2021-08-10 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9021: --- Resolution: Fixed Status: Resolved (was: Patch Available) > MiNiFi Java flows can't

[jira] [Commented] (NIFI-9021) MiNiFi Java flows can't use ListenHttp

2021-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396868#comment-17396868 ] ASF subversion and git services commented on NIFI-9021: --- Commit

[jira] [Updated] (NIFI-9021) MiNiFi Java flows can't use ListenHttp

2021-08-10 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9021: --- Affects Version/s: 1.15.0 1.14.0 > MiNiFi Java flows can't use

[GitHub] [nifi] asfgit closed pull request #5292: NIFI-9021: Add javax.servlet-api to MiNiFi assembly

2021-08-10 Thread GitBox
asfgit closed pull request #5292: URL: https://github.com/apache/nifi/pull/5292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (NIFI-8209) The Apache Nifi 1.12.1 Neo4JCypherClientService controller service hangs indefinitely attempting to connect to Neo4j 4.2.3

2021-08-10 Thread freddie Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396864#comment-17396864 ] freddie Burgess commented on NIFI-8209: --- Thanks so much Mike for helping to resolve this issue!!

[GitHub] [nifi] gresockj commented on a change in pull request #5288: NIFI-9009: Created VerifiableProcessor, VerifiableControllerService, …

2021-08-10 Thread GitBox
gresockj commented on a change in pull request #5288: URL: https://github.com/apache/nifi/pull/5288#discussion_r685219160 ## File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java ## @@

[GitHub] [nifi] MikeThomsen commented on pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
MikeThomsen commented on pull request #5301: URL: https://github.com/apache/nifi/pull/5301#issuecomment-896244875 Docker commands for setting up the integration testing: ``` docker run --name neo4j_3 -p 7687:7687 -p 7474:7474 neo4j:3.5.22 ``` ``` docker run --name

[GitHub] [nifi] MikeThomsen opened a new pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2021-08-10 Thread GitBox
MikeThomsen opened a new pull request #5301: URL: https://github.com/apache/nifi/pull/5301 …ntroller service along release lines. This was necessary because Neo4J broke compatibility in their client drivers for Java between 3.X and 4.X at the Java API level. Thank you for

[jira] [Commented] (NIFI-8209) The Apache Nifi 1.12.1 Neo4JCypherClientService controller service hangs indefinitely attempting to connect to Neo4j 4.2.3

2021-08-10 Thread Mike Thomsen (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396841#comment-17396841 ] Mike Thomsen commented on NIFI-8209: [~fburgess] I'm in the process of (hopefully) finishing up a PR

[jira] [Updated] (NIFI-8917) Create profiles to exclude ancillary modules from build

2021-08-10 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean updated NIFI-8917: Status: Patch Available (was: In Progress) > Create profiles to exclude ancillary modules from build >

[jira] [Assigned] (NIFI-8917) Create profiles to exclude ancillary modules from build

2021-08-10 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean reassigned NIFI-8917: --- Assignee: Mark Bean > Create profiles to exclude ancillary modules from build >

[jira] [Comment Edited] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2021-08-10 Thread Eduardo Mota Fontes (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396759#comment-17396759 ] Eduardo Mota Fontes edited comment on NIFI-7012 at 8/10/21, 4:58 PM: -

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5254: NIFI-8950: Added ability to optionally use a file-system backed Conte…

2021-08-10 Thread GitBox
exceptionfactory commented on a change in pull request #5254: URL: https://github.com/apache/nifi/pull/5254#discussion_r686148027 ## File path:

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5254: NIFI-8950: Added ability to optionally use a file-system backed Conte…

2021-08-10 Thread GitBox
exceptionfactory commented on a change in pull request #5254: URL: https://github.com/apache/nifi/pull/5254#discussion_r686146845 ## File path: nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/flow/TriggerResult.java ## @@ -57,11 +58,18 @@ *

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
fgerlits commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r686129649 ## File path: extensions/standard-processors/processors/AttributesToJSON.cpp ## @@ -0,0 +1,174 @@ +/** + * @file AttributesToJSON.cpp + *

[GitHub] [nifi] markap14 commented on pull request #5254: NIFI-8950: Added ability to optionally use a file-system backed Conte…

2021-08-10 Thread GitBox
markap14 commented on pull request #5254: URL: https://github.com/apache/nifi/pull/5254#issuecomment-896140784 Thanks guys, a lot of really good feedback here! I pushed a new commit that addresses everything mentioned, I believe (aside from those comments that I replied directly to). --

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
fgerlits commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r686119287 ## File path: docker/test/integration/features/attributes_to_json.feature ## @@ -0,0 +1,15 @@ +Feature: Writing attribute data using

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
fgerlits commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r686131553 ## File path: extensions/standard-processors/tests/unit/AttributesToJSONTests.cpp ## @@ -0,0 +1,293 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi] markap14 commented on a change in pull request #5254: NIFI-8950: Added ability to optionally use a file-system backed Conte…

2021-08-10 Thread GitBox
markap14 commented on a change in pull request #5254: URL: https://github.com/apache/nifi/pull/5254#discussion_r686126976 ## File path: nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/repository/StatelessFileSystemRepository.java

[GitHub] [nifi] markap14 commented on a change in pull request #5254: NIFI-8950: Added ability to optionally use a file-system backed Conte…

2021-08-10 Thread GitBox
markap14 commented on a change in pull request #5254: URL: https://github.com/apache/nifi/pull/5254#discussion_r686127030 ## File path: nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/engine/StatelessEngineConfiguration.java ## @@ -32,6 +33,11 @@

[GitHub] [nifi] markap14 commented on a change in pull request #5254: NIFI-8950: Added ability to optionally use a file-system backed Conte…

2021-08-10 Thread GitBox
markap14 commented on a change in pull request #5254: URL: https://github.com/apache/nifi/pull/5254#discussion_r686126942 ## File path: nifi-stateless/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/flow/TriggerResult.java ## @@ -57,11 +58,18 @@ * Provides

[jira] [Commented] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2021-08-10 Thread Eduardo Mota Fontes (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396759#comment-17396759 ] Eduardo Mota Fontes commented on NIFI-7012: --- This happened to me in two ways in NiFi 1.14: when

[jira] [Updated] (NIFI-7012) Using sensitive parameter in sensitive property of InvokeScriptedProcessor causes Jetty shutdown on NiFi restart

2021-08-10 Thread Eduardo Mota Fontes (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eduardo Mota Fontes updated NIFI-7012: -- Affects Version/s: 1.14.0 > Using sensitive parameter in sensitive property of

[GitHub] [nifi] markap14 commented on a change in pull request #5254: NIFI-8950: Added ability to optionally use a file-system backed Conte…

2021-08-10 Thread GitBox
markap14 commented on a change in pull request #5254: URL: https://github.com/apache/nifi/pull/5254#discussion_r686124374 ## File path: nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/repository/StatelessFileSystemRepository.java

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1154: MINIFICPP-1623 Minifi daemonset chart

2021-08-10 Thread GitBox
lordgamez commented on a change in pull request #1154: URL: https://github.com/apache/nifi-minifi-cpp/pull/1154#discussion_r686110080 ## File path: charts/stable/minifi-daemonset/templates/_helpers.tpl ## @@ -0,0 +1,56 @@ +{{/* vim: set filetype=mustache: */}} +{{/* +Expand

[jira] [Created] (MINIFICPP-1626) Upgrade PCAP++ to a more recent release

2021-08-10 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-1626: -- Summary: Upgrade PCAP++ to a more recent release Key: MINIFICPP-1626 URL: https://issues.apache.org/jira/browse/MINIFICPP-1626 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
lordgamez commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685967526 ## File path: extensions/standard-processors/tests/unit/AttributesToJSONTests.cpp ## @@ -0,0 +1,194 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
lordgamez commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685967417 ## File path: extensions/standard-processors/processors/AttributesToJSON.cpp ## @@ -0,0 +1,162 @@ +/** + * @file AttributesToJSON.cpp + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
lordgamez commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685967212 ## File path: extensions/standard-processors/processors/AttributesToJSON.h ## @@ -0,0 +1,103 @@ +/** + * @file AttributesToJSON.h + *

[jira] [Created] (NIFI-9039) ConsumeJMS 1.11.4 : Stop consume or Not release Connection

2021-08-10 Thread Mayki (Jira)
Mayki created NIFI-9039: --- Summary: ConsumeJMS 1.11.4 : Stop consume or Not release Connection Key: NIFI-9039 URL: https://issues.apache.org/jira/browse/NIFI-9039 Project: Apache NiFi Issue Type: Bug

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
fgerlits commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685792101 ## File path: libminifi/include/core/FlowFile.h ## @@ -310,6 +311,10 @@ struct SpecialFlowAttribute { static const std::string

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
fgerlits commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685788434 ## File path: extensions/standard-processors/tests/unit/AttributesToJSONTests.cpp ## @@ -0,0 +1,194 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
fgerlits commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685788434 ## File path: extensions/standard-processors/tests/unit/AttributesToJSONTests.cpp ## @@ -0,0 +1,194 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
lordgamez commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685784529 ## File path: libminifi/include/core/FlowFile.h ## @@ -310,6 +311,10 @@ struct SpecialFlowAttribute { static const std::string

[jira] [Updated] (MINIFICPP-1479) Rework integration tests for HashContent

2021-08-10 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1479: -- Fix Version/s: (was: 1.0.0) 0.11.0 > Rework integration

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

2021-08-10 Thread GitBox
lordgamez commented on a change in pull request #1137: URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r685766461 ## File path: extensions/standard-processors/tests/unit/AttributesToJSONTests.cpp ## @@ -0,0 +1,194 @@ +/** + * + * Licensed to the Apache