[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749995971 ## File path: libminifi/include/utils/file/FileView.h ## @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi] mikayla-yang commented on pull request #5476: NIFI-9259: Adding GeohashRecord Processor

2021-11-15 Thread GitBox
mikayla-yang commented on pull request #5476: URL: https://github.com/apache/nifi/pull/5476#issuecomment-969502105 Thank you @exceptionfactory for the comments! I have made changes accordingly. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nifi] mikayla-yang commented on a change in pull request #5476: NIFI-9259: Adding GeohashRecord Processor

2021-11-15 Thread GitBox
mikayla-yang commented on a change in pull request #5476: URL: https://github.com/apache/nifi/pull/5476#discussion_r749781535 ## File path: nifi-nar-bundles/nifi-geohash-bundle/nifi-geohash-processors/src/main/java/org/apache/nifi/processors/geohash/GeohashRecord.java ## @@

[GitHub] [nifi] mikayla-yang commented on a change in pull request #5476: NIFI-9259: Adding GeohashRecord Processor

2021-11-15 Thread GitBox
mikayla-yang commented on a change in pull request #5476: URL: https://github.com/apache/nifi/pull/5476#discussion_r749780399 ## File path: nifi-nar-bundles/nifi-geohash-bundle/nifi-geohash-processors/src/main/java/org/apache/nifi/processors/geohash/GeohashRecord.java ## @@

[jira] [Updated] (NIFI-7862) Add UpdateDatabaseTable processor to optionally create the target table and/or columns if they don't exist

2021-11-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7862: --- Status: Patch Available (was: In Progress) > Add UpdateDatabaseTable processor to optionally create

[GitHub] [nifi] mattyb149 opened a new pull request #5523: NIFI-7862: Add UpdateDatabaseTable processor for auto table structure updates

2021-11-15 Thread GitBox
mattyb149 opened a new pull request #5523: URL: https://github.com/apache/nifi/pull/5523 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Adds functionality like UpdateHive3Table to

[jira] [Updated] (NIFI-9379) Update NiFi Registery extension manifest model

2021-11-15 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-9379: -- Status: Patch Available (was: In Progress) > Update NiFi Registery extension manifest model >

[GitHub] [nifi] bbende opened a new pull request #5522: NIFI-9379 Update NiFi Registery extension manifest model with latest changes from manifests

2021-11-15 Thread GitBox
bbende opened a new pull request #5522: URL: https://github.com/apache/nifi/pull/5522 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[jira] [Created] (NIFI-9379) Update NiFi Registery extension manifest model

2021-11-15 Thread Bryan Bende (Jira)
Bryan Bende created NIFI-9379: - Summary: Update NiFi Registery extension manifest model Key: NIFI-9379 URL: https://issues.apache.org/jira/browse/NIFI-9379 Project: Apache NiFi Issue Type:

[jira] [Commented] (NIFI-8101) Improvement PutDatabaseRecord for refresh table schema cache

2021-11-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444100#comment-17444100 ] Matt Burgess commented on NIFI-8101: As a workaround, the Table Schema Cache Size can be set to zero,

[jira] [Updated] (NIFI-9378) Create assembly of extension manifests from all NARs included in the build

2021-11-15 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-9378: -- Status: Patch Available (was: In Progress) > Create assembly of extension manifests from all NARs

[GitHub] [nifi] bbende opened a new pull request #5521: NIFI-9378 Create new artifact in nifi-assembly that packages all exte…

2021-11-15 Thread GitBox
bbende opened a new pull request #5521: URL: https://github.com/apache/nifi/pull/5521 …nsion manifests. This produces a new artifact during building of `nifi-assembly` - `nifi-1.16.0-SNAPSHOT-manifests.zip`. This must be done from `nifi-assembly` since that is where the

[jira] [Created] (NIFI-9378) Create assembly of extension manifests from all NARs included in the build

2021-11-15 Thread Bryan Bende (Jira)
Bryan Bende created NIFI-9378: - Summary: Create assembly of extension manifests from all NARs included in the build Key: NIFI-9378 URL: https://issues.apache.org/jira/browse/NIFI-9378 Project: Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
szaszm commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749623631 ## File path: libminifi/include/utils/file/FileView.h ## @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
szaszm commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749609775 ## File path: libminifi/src/utils/file/FileUtils.cpp ## @@ -48,6 +48,44 @@ uint64_t computeChecksum(const std::string _name, uint64_t

[jira] [Commented] (NIFI-7835) SFTP processors (maybe other too) proxy doesn't use credentials

2021-11-15 Thread Wiktor Kubicki (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444045#comment-17444045 ] Wiktor Kubicki commented on NIFI-7835: -- [~exceptionfactory] as i thought.. But i tried using java

[jira] [Commented] (NIFI-7835) SFTP processors (maybe other too) proxy doesn't use credentials

2021-11-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444039#comment-17444039 ] David Handermann commented on NIFI-7835: The custom SocketFactory implementation that NiFi uses

[jira] [Commented] (NIFI-9344) Conduct 1.15 Release

2021-11-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444034#comment-17444034 ] ASF subversion and git services commented on NIFI-9344: --- Commit 1895064 from Joe

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1215: MINIFICPP-1685 reduce CI usage

2021-11-15 Thread GitBox
szaszm commented on a change in pull request #1215: URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#discussion_r749594447 ## File path: .github/workflows/ci.yml ## @@ -151,31 +151,10 @@ jobs: cd build export CC=clang export CXX=clang++

[jira] [Updated] (NIFI-7835) SFTP processors (maybe other too) proxy doesn't use credentials

2021-11-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-7835: --- Affects Version/s: 1.15.0 > SFTP processors (maybe other too) proxy doesn't use credentials >

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1215: MINIFICPP-1685 reduce CI usage

2021-11-15 Thread GitBox
szaszm commented on pull request #1215: URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#issuecomment-969210157 There was an email thread about the topic a few months ago, and someone submitted statistics, but I can't find them now. MiNiFi C++ was running for about as long as nifi

[jira] [Commented] (NIFI-9344) Conduct 1.15 Release

2021-11-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444031#comment-17444031 ] ASF subversion and git services commented on NIFI-9344: --- Commit 1895063 from Joe

[GitHub] [nifi] thenatog commented on pull request #5493: NIFI-8806 - Refactoring ListenTCP to use netty.

2021-11-15 Thread GitBox
thenatog commented on pull request #5493: URL: https://github.com/apache/nifi/pull/5493#issuecomment-969145241 Updated as per latest code review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] exceptionfactory commented on a change in pull request #3890: NIFI-6871: Added HikariCPConnectionPool controller service

2021-11-15 Thread GitBox
exceptionfactory commented on a change in pull request #3890: URL: https://github.com/apache/nifi/pull/3890#discussion_r749508246 ## File path: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/pom.xml ## @@ -68,6 +68,11 @@

[jira] [Resolved] (NIFI-9077) Add H2 Database Password Change Instructions for Registry

2021-11-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-9077. Fix Version/s: 1.16.0 Resolution: Fixed > Add H2 Database Password Change

[jira] [Updated] (NIFI-9077) Add H2 Database Password Change Instructions for Registry

2021-11-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9077: --- Summary: Add H2 Database Password Change Instructions for Registry (was: Apache NiFi

[jira] [Commented] (NIFI-9077) Apache NiFi Registry documentation - H2 database change password manual

2021-11-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443940#comment-17443940 ] ASF subversion and git services commented on NIFI-9077: --- Commit

[GitHub] [nifi] exceptionfactory closed pull request #5328: NIFI-9077 [nifi-registry docs] H2 database password change manual

2021-11-15 Thread GitBox
exceptionfactory closed pull request #5328: URL: https://github.com/apache/nifi/pull/5328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (NIFI-5821) ExecuteScript should say Python is really Jython running

2021-11-15 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443937#comment-17443937 ] Joe Witt commented on NIFI-5821: This JIRA/request makes sense. Just needs someone to contribute/review

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
fgerlits commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749462278 ## File path: libminifi/src/utils/file/FileUtils.cpp ## @@ -48,6 +48,44 @@ uint64_t computeChecksum(const std::string _name, uint64_t

[jira] [Commented] (NIFI-7862) Allow PutDatabaseRecord to optionally create the target table and/or columns if they don't exist

2021-11-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443910#comment-17443910 ] Matt Burgess commented on NIFI-7862: Per the discussion in NIFI-8101, this Jira will be used to track

[jira] [Updated] (NIFI-7862) Add UpdateDatabaseTable processor to optionally create the target table and/or columns if they don't exist

2021-11-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7862: --- Summary: Add UpdateDatabaseTable processor to optionally create the target table and/or columns if

[jira] [Assigned] (NIFI-7862) Allow PutDatabaseRecord to optionally create the target table and/or columns if they don't exist

2021-11-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-7862: -- Assignee: Matt Burgess > Allow PutDatabaseRecord to optionally create the target table and/or

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1215: MINIFICPP-1685 reduce CI usage

2021-11-15 Thread GitBox
adamdebreceni commented on pull request #1215: URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#issuecomment-969020095 I welcome this change, although it would be nice to quantify how much is "quite a lot" or more importantly what is our target/limit CI time, obviously the less we

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749424218 ## File path: libminifi/include/core/extension/Utils.h ## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (NIFI-5821) ExecuteScript should say Python is really Jython running

2021-11-15 Thread Ryan Hendrickson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Hendrickson updated NIFI-5821: --- Description: ExecuteScript drop-down should say "jython" or "Python (jython)" ... Something

[jira] [Commented] (NIFI-5821) ExecuteScript should say Python is really Jython running

2021-11-15 Thread Ryan Hendrickson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443889#comment-17443889 ] Ryan Hendrickson commented on NIFI-5821: +1.. someone ran into an issue with this recently.. >

[jira] [Updated] (NIFI-5821) ExecuteScript should say Python is really Jython running

2021-11-15 Thread Ryan Hendrickson (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Hendrickson updated NIFI-5821: --- Description: Code executed in the ExecuteScript processor, when Python is selected, is

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1215: MINIFICPP-1685 reduce CI usage

2021-11-15 Thread GitBox
adam-markovics commented on a change in pull request #1215: URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#discussion_r749414107 ## File path: .github/workflows/ci.yml ## @@ -151,31 +151,10 @@ jobs: cd build export CC=clang export

[jira] [Updated] (MINIFICPP-1685) Reduce CI load: remove less important CI jobs

2021-11-15 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1685: Fix Version/s: 0.11.0 > Reduce CI load: remove less important CI jobs >

[jira] [Updated] (MINIFICPP-1685) Reduce CI load: remove less important CI jobs

2021-11-15 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1685: Status: Patch Available (was: In Progress)

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #1215: MINIFICPP-1685 reduce CI usage

2021-11-15 Thread GitBox
szaszm opened a new pull request #1215: URL: https://github.com/apache/nifi-minifi-cpp/pull/1215 remove ubuntu 18.04 reduce ubuntu 20.04 clang scope remove fedora and debian docker builds https://issues.apache.org/jira/browse/MINIFICPP-1685 MiNiFi C++ uses quite a lot of

[jira] [Commented] (NIFI-7835) SFTP processors (maybe other too) proxy doesn't use credentials

2021-11-15 Thread Rodolphe DUPUY (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443875#comment-17443875 ] Rodolphe DUPUY commented on NIFI-7835: -- Hello, This issue still remain. Do you have any news please

[jira] [Created] (MINIFICPP-1685) Reduce CI load: remove less important CI jobs

2021-11-15 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-1685: --- Summary: Reduce CI load: remove less important CI jobs Key: MINIFICPP-1685 URL: https://issues.apache.org/jira/browse/MINIFICPP-1685 Project: Apache NiFi MiNiFi

[GitHub] [nifi] ChrisSamo632 commented on a change in pull request #5213: NIFI-8779 correct Docker build scripts

2021-11-15 Thread GitBox
ChrisSamo632 commented on a change in pull request #5213: URL: https://github.com/apache/nifi/pull/5213#discussion_r749398006 ## File path: nifi-docker/dockerhub/pom.xml ## @@ -24,17 +24,26 @@ openjdk 8-jre + +1.14.0

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
szaszm commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749391603 ## File path: libminifi/include/core/extension/Utils.h ## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749382872 ## File path: libminifi/include/core/extension/Utils.h ## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749382571 ## File path: libminifi/include/core/extension/Utils.h ## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749382467 ## File path: libminifi/include/core/extension/Utils.h ## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5213: NIFI-8779 correct Docker build scripts

2021-11-15 Thread GitBox
exceptionfactory commented on a change in pull request #5213: URL: https://github.com/apache/nifi/pull/5213#discussion_r749378261 ## File path: nifi-docker/dockerhub/pom.xml ## @@ -24,17 +24,26 @@ openjdk 8-jre + +1.14.0

[jira] [Updated] (NIFI-9362) ListFTP / ListSFTP may occasionally duplicate files when Primary Node changes

2021-11-15 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-9362: - Affects Version/s: 1.15.0 1.13.2 1.13.1

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5362: NIFI-9149 to NIFI-9163 (JUnit 5 refactor)

2021-11-15 Thread GitBox
exceptionfactory commented on a change in pull request #5362: URL: https://github.com/apache/nifi/pull/5362#discussion_r705764678 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
szaszm commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749355359 ## File path: libminifi/include/utils/file/FileView.h ## @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5350: NIFI-9085 through NIFI-9095 (JUnit refactor of multiple modules)

2021-11-15 Thread GitBox
exceptionfactory commented on a change in pull request #5350: URL: https://github.com/apache/nifi/pull/5350#discussion_r749350885 ## File path:

[jira] [Resolved] (NIFI-830) For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL

2021-11-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-830. --- Fix Version/s: 1.16.0 Resolution: Fixed > For GET requests, InvokeHTTP should set the

[jira] [Commented] (NIFI-830) For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL

2021-11-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443826#comment-17443826 ] ASF subversion and git services commented on NIFI-830: -- Commit

[GitHub] [nifi] asfgit closed pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL

2021-11-15 Thread GitBox
asfgit closed pull request #5475: URL: https://github.com/apache/nifi/pull/5475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adam-markovics commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749214852 ## File path: libminifi/include/core/extension/Utils.h ## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
szaszm commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749253532 ## File path: cmake/Extensions.cmake ## @@ -22,10 +22,31 @@ define_property(GLOBAL PROPERTY EXTENSION-OPTIONS set_property(GLOBAL PROPERTY

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749251629 ## File path: cmake/Extensions.cmake ## @@ -22,10 +22,31 @@ define_property(GLOBAL PROPERTY EXTENSION-OPTIONS set_property(GLOBAL

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
szaszm commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749244836 ## File path: cmake/Extensions.cmake ## @@ -22,10 +22,31 @@ define_property(GLOBAL PROPERTY EXTENSION-OPTIONS set_property(GLOBAL PROPERTY

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749145857 ## File path: cmake/Extensions.cmake ## @@ -22,10 +22,31 @@ define_property(GLOBAL PROPERTY EXTENSION-OPTIONS set_property(GLOBAL

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1211: MINIFICPP-1676 - Verify build id of extension before load

2021-11-15 Thread GitBox
adamdebreceni commented on a change in pull request #1211: URL: https://github.com/apache/nifi-minifi-cpp/pull/1211#discussion_r749136836 ## File path: libminifi/include/utils/file/FileView.h ## @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under