[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-15 Thread GitBox
adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r807642361 ## File path: CMakeLists.txt ## @@ -611,6 +612,11 @@ if (ENABLE_KUBERNETES) createExtension(KUBERNETES-EXTENSIONS "KUBERNETES EXTENSIONS

[jira] [Updated] (NIFI-9692) Upgrade Apache Commons Lang3 to 3.12.0

2022-02-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9692: --- Status: Patch Available (was: Open) > Upgrade Apache Commons Lang3 to 3.12.0 > --

[GitHub] [nifi] exceptionfactory opened a new pull request #5773: NIFI-9692 Upgrade Apache Commons Lang3 to 3.12.0

2022-02-15 Thread GitBox
exceptionfactory opened a new pull request #5773: URL: https://github.com/apache/nifi/pull/5773 Description of PR NIFI-9692 Upgrades Apache Commons Lang3 to 3.12.0 and moves version management to the root Maven configuration. Numerous modules referenced various versions o

[GitHub] [nifi] thenatog commented on pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord

2022-02-15 Thread GitBox
thenatog commented on pull request #5701: URL: https://github.com/apache/nifi/pull/5701#issuecomment-1041019167 I tested out these changes and they look good to me. I wasn't sure if we want to include the changes mi-volodin suggested as well. -- This is an automated message from the Apac

[GitHub] [nifi] Lehel44 commented on a change in pull request #5752: NIFI-9657 Create MoveADLS processor

2022-02-15 Thread GitBox
Lehel44 commented on a change in pull request #5752: URL: https://github.com/apache/nifi/pull/5752#discussion_r807469916 ## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/MoveAzureDataLakeStorage.java

[GitHub] [nifi] Lehel44 commented on a change in pull request #5752: NIFI-9657 Create MoveADLS processor

2022-02-15 Thread GitBox
Lehel44 commented on a change in pull request #5752: URL: https://github.com/apache/nifi/pull/5752#discussion_r807467521 ## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/MoveAzureDataLakeStorage.java

[GitHub] [nifi] Lehel44 commented on a change in pull request #5752: NIFI-9657 Create MoveADLS processor

2022-02-15 Thread GitBox
Lehel44 commented on a change in pull request #5752: URL: https://github.com/apache/nifi/pull/5752#discussion_r807466008 ## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/MoveAzureDataLakeStorage.java

[GitHub] [nifi] Lehel44 commented on a change in pull request #5752: NIFI-9657 Create MoveADLS processor

2022-02-15 Thread GitBox
Lehel44 commented on a change in pull request #5752: URL: https://github.com/apache/nifi/pull/5752#discussion_r807464958 ## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/MoveAzureDataLakeStorage.java

[GitHub] [nifi] lawye1973 commented on pull request #5767: NIFI-9694 : Correct FetchS3Object.java for provenance data URL

2022-02-15 Thread GitBox
lawye1973 commented on pull request #5767: URL: https://github.com/apache/nifi/pull/5767#issuecomment-1041003935 > @pvillard31 , I'd created the jira ticket, and updated the title. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Created] (NIFI-9694) FetchS3Object provenance URL is hardcoded

2022-02-15 Thread Law Yaw Eng (Jira)
Law Yaw Eng created NIFI-9694: - Summary: FetchS3Object provenance URL is hardcoded Key: NIFI-9694 URL: https://issues.apache.org/jira/browse/NIFI-9694 Project: Apache NiFi Issue Type: Improvement

[GitHub] [nifi] MikeThomsen commented on a change in pull request #5301: NIFI-8209 Added Neo4J 4.X and 3.X clients by splitting the current co…

2022-02-15 Thread GitBox
MikeThomsen commented on a change in pull request #5301: URL: https://github.com/apache/nifi/pull/5301#discussion_r807452791 ## File path: nifi-nar-bundles/nifi-graph-bundle/nifi-neo4j-cypher-service/pom.xml ## @@ -79,7 +79,7 @@ org.neo4j.driver

[jira] [Created] (NIFI-9693) Errot posting to Elasticsearch 8.0

2022-02-15 Thread Rory Sibbley (Jira)
Rory Sibbley created NIFI-9693: -- Summary: Errot posting to Elasticsearch 8.0 Key: NIFI-9693 URL: https://issues.apache.org/jira/browse/NIFI-9693 Project: Apache NiFi Issue Type: Bug Affects

[jira] [Created] (NIFI-9692) Upgrade Apache Commons Lang3 to 3.12.0

2022-02-15 Thread David Handermann (Jira)
David Handermann created NIFI-9692: -- Summary: Upgrade Apache Commons Lang3 to 3.12.0 Key: NIFI-9692 URL: https://issues.apache.org/jira/browse/NIFI-9692 Project: Apache NiFi Issue Type: Impr

[jira] [Resolved] (NIFI-9282) Support running with Java 17

2022-02-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-9282. Fix Version/s: 1.16.0 Resolution: Fixed Using Azul Zulu JDK 17.0.2 on Ubuntu Linux 21

[GitHub] [nifi] sardell commented on pull request #5666: NIFI-9580: UI work for framework-level retry in Processors

2022-02-15 Thread GitBox
sardell commented on pull request #5666: URL: https://github.com/apache/nifi/pull/5666#issuecomment-1040872242 @markap14 Thanks for taking a look! I updated the language used in the tooltips, and the default values you recommended are now the default returned from the backend (thanks @time

[GitHub] [nifi] mattyb149 closed pull request #5738: NIFI-9327: Added timewindow query to QueryNiFiReportingTask and MetricsEventReportingTask

2022-02-15 Thread GitBox
mattyb149 closed pull request #5738: URL: https://github.com/apache/nifi/pull/5738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [nifi] mattyb149 commented on pull request #5738: NIFI-9327: Added timewindow query to QueryNiFiReportingTask and MetricsEventReportingTask

2022-02-15 Thread GitBox
mattyb149 commented on pull request #5738: URL: https://github.com/apache/nifi/pull/5738#issuecomment-1040862324 Closing as it has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (NIFI-9058) AttributesToJSON filters out core attributes specified in attributes list

2022-02-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-9058. Fix Version/s: 1.16.0 Resolution: Fixed > AttributesToJSON filters out core attribute

[jira] [Commented] (NIFI-9058) AttributesToJSON filters out core attributes specified in attributes list

2022-02-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492880#comment-17492880 ] ASF subversion and git services commented on NIFI-9058: --- Commit 6788

[GitHub] [nifi] exceptionfactory closed pull request #5312: NIFI-9058 Core attributes shall not be filtered from Attributes List

2022-02-15 Thread GitBox
exceptionfactory closed pull request #5312: URL: https://github.com/apache/nifi/pull/5312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[jira] [Updated] (NIFI-9691) Create processors for joining record-oriented data with enrichment data

2022-02-15 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-9691: - Fix Version/s: 1.16.0 Status: Patch Available (was: Open) > Create processors for joining reco

[GitHub] [nifi] markap14 opened a new pull request #5772: NIFI-9691: Added ForkEnrichment, JoinEnrichment processors

2022-02-15 Thread GitBox
markap14 opened a new pull request #5772: URL: https://github.com/apache/nifi/pull/5772 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[jira] [Created] (NIFI-9691) Create processors for joining record-oriented data with enrichment data

2022-02-15 Thread Mark Payne (Jira)
Mark Payne created NIFI-9691: Summary: Create processors for joining record-oriented data with enrichment data Key: NIFI-9691 URL: https://issues.apache.org/jira/browse/NIFI-9691 Project: Apache NiFi

[jira] [Assigned] (NIFI-9690) UI - Update Connection Label to show when head of queue is penalized

2022-02-15 Thread Matt Gilman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-9690: - Assignee: Matt Gilman > UI - Update Connection Label to show when head of queue is penalized > --

[jira] [Created] (NIFI-9690) UI - Update Connection Label to show when head of queue is penalized

2022-02-15 Thread Matt Gilman (Jira)
Matt Gilman created NIFI-9690: - Summary: UI - Update Connection Label to show when head of queue is penalized Key: NIFI-9690 URL: https://issues.apache.org/jira/browse/NIFI-9690 Project: Apache NiFi

[jira] [Commented] (NIFI-9527) nifi-hive-nar fails to load because of the old snappy-java jar

2022-02-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492875#comment-17492875 ] ASF subversion and git services commented on NIFI-9527: --- Commit 7dfb

[jira] [Updated] (NIFI-9527) nifi-hive-nar fails to load because of the old snappy-java jar

2022-02-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-9527: --- Fix Version/s: 1.16.0 Resolution: Fixed Status: Resolved (was: Patch Available) > n

[GitHub] [nifi] mattyb149 closed pull request #5760: NIFI-9527 Upgrade snappy-java to 1.1.8.4

2022-02-15 Thread GitBox
mattyb149 closed pull request #5760: URL: https://github.com/apache/nifi/pull/5760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [nifi] mattyb149 commented on pull request #5760: NIFI-9527 Upgrade snappy-java to 1.1.8.4

2022-02-15 Thread GitBox
mattyb149 commented on pull request #5760: URL: https://github.com/apache/nifi/pull/5760#issuecomment-1040798837 +1 LGTM, verified reading to and writing from a Hive 1.2 table Avro-backed with Snappy compression. Thanks for the upgrade! Merging to main -- This is an automated message fro

[jira] [Commented] (NIFI-9475) Provide Framework-Level Retries for NiFi Relationships

2022-02-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492864#comment-17492864 ] ASF subversion and git services commented on NIFI-9475: --- Commit 63a5

[GitHub] [nifi] markap14 merged pull request #5593: NIFI-9475 Provide Framework-Level Retries for NiFi Relationships

2022-02-15 Thread GitBox
markap14 merged pull request #5593: URL: https://github.com/apache/nifi/pull/5593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Resolved] (NIFI-9475) Provide Framework-Level Retries for NiFi Relationships

2022-02-15 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-9475. -- Fix Version/s: 1.16.0 Resolution: Fixed > Provide Framework-Level Retries for NiFi Relationships

[GitHub] [nifi] markap14 commented on pull request #5593: NIFI-9475 Provide Framework-Level Retries for NiFi Relationships

2022-02-15 Thread GitBox
markap14 commented on pull request #5593: URL: https://github.com/apache/nifi/pull/5593#issuecomment-1040770012 Thanks for all your work on this @timeabarna ! Looks good to me at this point. Will merge. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (NIFI-9684) Starting a PG starts RPGs in sibling PGs as well

2022-02-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492849#comment-17492849 ] ASF subversion and git services commented on NIFI-9684: --- Commit 84b2

[jira] [Resolved] (NIFI-9684) Starting a PG starts RPGs in sibling PGs as well

2022-02-15 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-9684. -- Resolution: Fixed > Starting a PG starts RPGs in sibling PGs as well > -

[jira] [Updated] (NIFI-9684) Starting a PG starts RPGs in sibling PGs as well

2022-02-15 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-9684: - Fix Version/s: 1.16.0 > Starting a PG starts RPGs in sibling PGs as well > ---

[jira] [Assigned] (NIFI-9684) Starting a PG starts RPGs in sibling PGs as well

2022-02-15 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne reassigned NIFI-9684: Assignee: Tamas Palfy > Starting a PG starts RPGs in sibling PGs as well >

[GitHub] [nifi] markap14 merged pull request #5764: NIFI-9684 FIx: Starting a PG starts RPGs in sibling PGs as well

2022-02-15 Thread GitBox
markap14 merged pull request #5764: URL: https://github.com/apache/nifi/pull/5764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [nifi] markap14 commented on pull request #5764: NIFI-9684 FIx: Starting a PG starts RPGs in sibling PGs as well

2022-02-15 Thread GitBox
markap14 commented on pull request #5764: URL: https://github.com/apache/nifi/pull/5764#issuecomment-1040729587 Thanks for the fix @tpalfy ! I was able to verify that it's working as expected now. +1 will merge to main. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [nifi] markap14 opened a new pull request #5771: NIFI-9689: When all FlowFiles in a FlowFile Queue are penalized, do n…

2022-02-15 Thread GitBox
markap14 opened a new pull request #5771: URL: https://github.com/apache/nifi/pull/5771 …ot schedule the destination to run. Also expose this fact via the ConnectionStatusSnapshotDTO, as this allows the front-end to render this information to the user in order to avoid confusion when it ap

[jira] [Created] (NIFI-9689) Do not schedule processors when all FlowFiles are penalized

2022-02-15 Thread Mark Payne (Jira)
Mark Payne created NIFI-9689: Summary: Do not schedule processors when all FlowFiles are penalized Key: NIFI-9689 URL: https://issues.apache.org/jira/browse/NIFI-9689 Project: Apache NiFi Issue

[GitHub] [nifi] markobean commented on pull request #5743: NIFI-8899 - Add NiFi Registry version information to the Registry under an "about" button.

2022-02-15 Thread GitBox
markobean commented on pull request #5743: URL: https://github.com/apache/nifi/pull/5743#issuecomment-1040434810 I installed Registry to see how the UI reports the version. This is a good start. I'd like to recommend the UI dialog mimic the "About" dialog for Apache NiFi for a consistent l

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1261: MINIFICPP-1752 Remove the catch2 dependency from our the test infrast…

2022-02-15 Thread GitBox
szaszm closed pull request #1261: URL: https://github.com/apache/nifi-minifi-cpp/pull/1261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-15 Thread GitBox
szaszm commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r798799427 ## File path: extensions/aws/processors/ListS3.h ## @@ -33,6 +33,7 @@ namespace org { namespace apache { namespace nifi { namespace minifi { +

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1261: MINIFICPP-1752 Remove the catch2 dependency from our the test infrast…

2022-02-15 Thread GitBox
szaszm commented on pull request #1261: URL: https://github.com/apache/nifi-minifi-cpp/pull/1261#issuecomment-1040382220 During a pre-merge check, I got this compilation error: ``` /home/szaszm/nifi-minifi-cpp-3/extensions/expression-language/tests/ProcessContextExprTests.cpp:54:10:

[GitHub] [nifi] mattyb149 commented on pull request #5746: NIFI-6740: Add configuration options to specify NiFi/Bootstrap communication ports

2022-02-15 Thread GitBox
mattyb149 commented on pull request #5746: URL: https://github.com/apache/nifi/pull/5746#issuecomment-1040508165 +1 LGTM, verified the expected behavior. Thanks for the improvement! Merged to main -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [nifi] mattyb149 closed pull request #5746: NIFI-6740: Add configuration options to specify NiFi/Bootstrap communication ports

2022-02-15 Thread GitBox
mattyb149 closed pull request #5746: URL: https://github.com/apache/nifi/pull/5746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [nifi] bejancsaba commented on a change in pull request #5755: NIFI-9538: Add C2 heartbeat capability to minifi-c2-service

2022-02-15 Thread GitBox
bejancsaba commented on a change in pull request #5755: URL: https://github.com/apache/nifi/pull/5755#discussion_r806855762 ## File path: minifi/minifi-c2/minifi-c2-service/src/main/java/org/apache/nifi/minifi/c2/service/SimpleC2ProtocolService.java ## @@ -0,0 +1,120 @@ +/* +

[GitHub] [nifi] thenatog commented on pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord

2022-02-15 Thread GitBox
thenatog commented on pull request #5701: URL: https://github.com/apache/nifi/pull/5701#issuecomment-1040463251 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] asfgit closed pull request #5769: NIFI-9686: Renamed SNMP integration tests correctly

2022-02-15 Thread GitBox
asfgit closed pull request #5769: URL: https://github.com/apache/nifi/pull/5769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [nifi] nrnalamalpu commented on pull request #5291: NIFI-9036 - Add AWS MSK IAM support to Kafka processors

2022-02-15 Thread GitBox
nrnalamalpu commented on pull request #5291: URL: https://github.com/apache/nifi/pull/5291#issuecomment-1040277206 Can anyone please look into this PR and see if we can close this out? thanks -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-15 Thread GitBox
adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r806957651 ## File path: extensions/aws/processors/ListS3.h ## @@ -33,6 +33,7 @@ namespace org { namespace apache { namespace nifi { namespace mini

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1259: MINIFICPP-1748 - Modify log properties through the c2 protocol

2022-02-15 Thread GitBox
fgerlits closed pull request #1259: URL: https://github.com/apache/nifi-minifi-cpp/pull/1259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1255: MINIFICPP-1750 Fix C2 clear operation with corecomponentstate operand

2022-02-15 Thread GitBox
fgerlits closed pull request #1255: URL: https://github.com/apache/nifi-minifi-cpp/pull/1255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [nifi] markap14 merged pull request #5749: NIFI-9233 - Improve reliability of system integration tests

2022-02-15 Thread GitBox
markap14 merged pull request #5749: URL: https://github.com/apache/nifi/pull/5749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [nifi] mcgilman commented on pull request #5765: NIFI-9543: Add bring-to-front functionality to labels

2022-02-15 Thread GitBox
mcgilman commented on pull request #5765: URL: https://github.com/apache/nifi/pull/5765#issuecomment-1040309958 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1259: MINIFICPP-1748 - Modify log properties through the c2 protocol

2022-02-15 Thread GitBox
fgerlits commented on a change in pull request #1259: URL: https://github.com/apache/nifi-minifi-cpp/pull/1259#discussion_r806621990 ## File path: libminifi/include/properties/Properties.h ## @@ -29,16 +29,23 @@ #include "core/logging/Logger.h" #include "utils/ChecksumCalcu

[GitHub] [nifi] pvillard31 commented on pull request #5763: NIFI-9681 Upgrade Apache Commons DBCP to 2.9.0

2022-02-15 Thread GitBox
pvillard31 commented on pull request #5763: URL: https://github.com/apache/nifi/pull/5763#issuecomment-1039358787 Merged, thanks @exceptionfactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [nifi] asfgit closed pull request #5763: NIFI-9681 Upgrade Apache Commons DBCP to 2.9.0

2022-02-15 Thread GitBox
asfgit closed pull request #5763: URL: https://github.com/apache/nifi/pull/5763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [nifi] kevdoran closed pull request #5751: [NIFI-9554] Support building and running NiFi on arm64 platforms and consume nifi-fds 0.3.0

2022-02-15 Thread GitBox
kevdoran closed pull request #5751: URL: https://github.com/apache/nifi/pull/5751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [nifi] markap14 commented on pull request #5324: NIFI-9072: improvements to ValidateXML including validate XML in attr…

2022-02-15 Thread GitBox
markap14 commented on pull request #5324: URL: https://github.com/apache/nifi/pull/5324#issuecomment-1039315005 I think I would be more inclined to accept this PR than to introduce a separate ValidateXMLAttribute processor, as well. If there's concern about adding the character set propert

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1259: MINIFICPP-1748 - Modify log properties through the c2 protocol

2022-02-15 Thread GitBox
adamdebreceni commented on a change in pull request #1259: URL: https://github.com/apache/nifi-minifi-cpp/pull/1259#discussion_r806660908 ## File path: libminifi/include/properties/Properties.h ## @@ -29,16 +29,23 @@ #include "core/logging/Logger.h" #include "utils/Checksum

[GitHub] [nifi] turcsanyip commented on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

2022-02-15 Thread GitBox
turcsanyip commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1039276217 @tpalfy Please do not forget to add LICENCE / NOTICE files in the nar bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [nifi] mtien-apache commented on a change in pull request #5743: NIFI-8899 - Add NiFi Registry version information to the Registry under an "about" button.

2022-02-15 Thread GitBox
mtien-apache commented on a change in pull request #5743: URL: https://github.com/apache/nifi/pull/5743#discussion_r806129029 ## File path: nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/package.json ## @@ -66,6 +66,7 @@ "reset-css": "4.0.1",

[GitHub] [nifi] turcsanyip edited a comment on pull request #5692: NIFI-9609 Added nifi-snowflake-bundle with a SnowflakeConnectionPool.

2022-02-15 Thread GitBox
turcsanyip edited a comment on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1039276217 @tpalfy Please do not forget to add LICENSE / NOTICE files in the nar bundle. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [nifi] asfgit closed pull request #5766: NIFI-9685 Upgrade JNA to 5.10.0

2022-02-15 Thread GitBox
asfgit closed pull request #5766: URL: https://github.com/apache/nifi/pull/5766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [nifi] bbende commented on a change in pull request #5743: NIFI-8899 - Add NiFi Registry version information to the Registry under an "about" button.

2022-02-15 Thread GitBox
bbende commented on a change in pull request #5743: URL: https://github.com/apache/nifi/pull/5743#discussion_r806105957 ## File path: nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/VersionResource.java ## @@ -0,0 +1,63 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1253: MINIFICPP-1736 Add MiNiFi agent C2 operation capabilities to agent manifest

2022-02-15 Thread GitBox
szaszm commented on a change in pull request #1253: URL: https://github.com/apache/nifi-minifi-cpp/pull/1253#discussion_r806045280 ## File path: extensions/http-curl/tests/C2NullConfiguration.cpp ## @@ -72,15 +72,15 @@ class VerifyC2Server : public HTTPIntegrationBase {

[GitHub] [nifi] markap14 commented on a change in pull request #5593: NIFI-9475 Provide Framework-Level Retries for NiFi Relationships

2022-02-15 Thread GitBox
markap14 commented on a change in pull request #5593: URL: https://github.com/apache/nifi/pull/5593#discussion_r792878063 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractPort.java ## @

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1253: MINIFICPP-1736 Add MiNiFi agent C2 operation capabilities to agent manifest

2022-02-15 Thread GitBox
lordgamez commented on a change in pull request #1253: URL: https://github.com/apache/nifi-minifi-cpp/pull/1253#discussion_r805990249 ## File path: libminifi/src/FlowController.cpp ## @@ -431,8 +431,9 @@ int16_t FlowController::clearConnection(const std::string &connection) {

[GitHub] [nifi] joewitt commented on pull request #5247: NIFI-8927 - Add option to start/stop all controllers

2022-02-15 Thread GitBox
joewitt commented on pull request #5247: URL: https://github.com/apache/nifi/pull/5247#issuecomment-1039406858 We need to have more information on what has been verified here. What happens on a taxed system with many controller services? Does this cause blocking while that is happening?

[GitHub] [nifi] timeabarna commented on a change in pull request #5593: NIFI-9475 Provide Framework-Level Retries for NiFi Relationships

2022-02-15 Thread GitBox
timeabarna commented on a change in pull request #5593: URL: https://github.com/apache/nifi/pull/5593#discussion_r806488746 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/StandardFunnel.java

[GitHub] [nifi] mcgilman commented on pull request #5247: NIFI-8927 - Add option to start/stop all controllers

2022-02-15 Thread GitBox
mcgilman commented on pull request #5247: URL: https://github.com/apache/nifi/pull/5247#issuecomment-1039496144 @eduardofontes Thanks for the PR! The process of enabling and disabling Controller Services is complex. Currently, the NiFi UI supports enabling and disabling a single Controller

[GitHub] [nifi] ohnoitsyou commented on a change in pull request #5743: NIFI-8899 - Add NiFi Registry version information to the Registry under an "about" button.

2022-02-15 Thread GitBox
ohnoitsyou commented on a change in pull request #5743: URL: https://github.com/apache/nifi/pull/5743#discussion_r806146305 ## File path: nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/package.json ## @@ -66,6 +66,7 @@ "reset-css": "4.0.1", "r

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1152: MINIFICPP-1593 ProcFsMonitor to monitor /proc pseduo filesystem

2022-02-15 Thread GitBox
szaszm commented on a change in pull request #1152: URL: https://github.com/apache/nifi-minifi-cpp/pull/1152#discussion_r732604183 ## File path: extensions/procfs/CPPLINT.cfg ## @@ -0,0 +1 @@ +filter=-runtime/int Review comment: Is this still relevant? I didn't see any

[GitHub] [nifi] stevedlawrence commented on a change in pull request #5746: NIFI-6740: Add configuration options to specify NiFi/Bootstrap communication ports

2022-02-15 Thread GitBox
stevedlawrence commented on a change in pull request #5746: URL: https://github.com/apache/nifi/pull/5746#discussion_r806036801 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties ## @@ -244,6 +244,9 @@ ni

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1152: MINIFICPP-1593 ProcFsMonitor to monitor /proc pseduo filesystem

2022-02-15 Thread GitBox
szaszm commented on a change in pull request #1152: URL: https://github.com/apache/nifi-minifi-cpp/pull/1152#discussion_r807159061 ## File path: extensions/procfs/DiskStat.h ## @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[jira] [Commented] (NIFI-9233) Improve reliability of system integration tests

2022-02-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492770#comment-17492770 ] ASF subversion and git services commented on NIFI-9233: --- Commit 87cf

[GitHub] [nifi] markap14 merged pull request #5749: NIFI-9233 - Improve reliability of system integration tests

2022-02-15 Thread GitBox
markap14 merged pull request #5749: URL: https://github.com/apache/nifi/pull/5749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (NIFI-9680) Add "quick copy to clipboard" feature to component dialogs

2022-02-15 Thread Kevin Doran (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492768#comment-17492768 ] Kevin Doran commented on NIFI-9680: --- What if we added a component-level button/menu to c

[GitHub] [nifi] andrewmlim opened a new pull request #5770: NIFI-9687 Add additional documentation for nifi.cluster.node.protocol…

2022-02-15 Thread GitBox
andrewmlim opened a new pull request #5770: URL: https://github.com/apache/nifi/pull/5770 ….max.threads property to Admin Guide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Updated] (NIFI-9686) Unstable Build due to SetSNMPIntegrationTest

2022-02-15 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-9686: --- Fix Version/s: 1.16.0 Resolution: Fixed Status: Resolved (was: Patch Availab

[jira] [Commented] (NIFI-9686) Unstable Build due to SetSNMPIntegrationTest

2022-02-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492735#comment-17492735 ] ASF subversion and git services commented on NIFI-9686: --- Commit 5120

[GitHub] [nifi] asfgit closed pull request #5769: NIFI-9686: Renamed SNMP integration tests correctly

2022-02-15 Thread GitBox
asfgit closed pull request #5769: URL: https://github.com/apache/nifi/pull/5769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Updated] (NIFI-9688) Log Messages on Process Shutdown are Discarded due to Logging Deinitialize

2022-02-15 Thread Paul Grey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey updated NIFI-9688: Description: NiFi uses the SLF4J logging API [https://www.slf4j.org/] and the Logback implementation [https

[jira] [Created] (NIFI-9688) Log Messages on Process Shutdown are Discarded due to Logging Deinitialize

2022-02-15 Thread Paul Grey (Jira)
Paul Grey created NIFI-9688: --- Summary: Log Messages on Process Shutdown are Discarded due to Logging Deinitialize Key: NIFI-9688 URL: https://issues.apache.org/jira/browse/NIFI-9688 Project: Apache NiFi

[jira] [Updated] (NIFI-6740) No way to configure bootstrap or nifi command/control ports

2022-02-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-6740: --- Fix Version/s: 1.16.0 Resolution: Fixed Status: Resolved (was: Patch Available) > N

[GitHub] [nifi] mattyb149 commented on pull request #5746: NIFI-6740: Add configuration options to specify NiFi/Bootstrap communication ports

2022-02-15 Thread GitBox
mattyb149 commented on pull request #5746: URL: https://github.com/apache/nifi/pull/5746#issuecomment-1040508165 +1 LGTM, verified the expected behavior. Thanks for the improvement! Merged to main -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [nifi] mattyb149 closed pull request #5746: NIFI-6740: Add configuration options to specify NiFi/Bootstrap communication ports

2022-02-15 Thread GitBox
mattyb149 closed pull request #5746: URL: https://github.com/apache/nifi/pull/5746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (NIFI-6740) No way to configure bootstrap or nifi command/control ports

2022-02-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492727#comment-17492727 ] ASF subversion and git services commented on NIFI-6740: --- Commit 4815

[jira] [Updated] (NIFI-6740) No way to configure bootstrap or nifi command/control ports

2022-02-15 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-6740: --- Status: Patch Available (was: Open) > No way to configure bootstrap or nifi command/control ports > -

[jira] [Assigned] (NIFI-9687) Add additional documentation for setting nifi.cluster.node.protocol.max.threads property

2022-02-15 Thread Andrew M. Lim (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew M. Lim reassigned NIFI-9687: --- Assignee: Andrew M. Lim > Add additional documentation for setting > nifi.cluster.node.proto

[jira] [Created] (NIFI-9687) Add additional documentation for setting nifi.cluster.node.protocol.max.threads property

2022-02-15 Thread Andrew M. Lim (Jira)
Andrew M. Lim created NIFI-9687: --- Summary: Add additional documentation for setting nifi.cluster.node.protocol.max.threads property Key: NIFI-9687 URL: https://issues.apache.org/jira/browse/NIFI-9687 Pr

[GitHub] [nifi] thenatog commented on pull request #5701: NIFI-9607: Honor Update Keys when Quoting Identifiers in PutDatabaseRecord

2022-02-15 Thread GitBox
thenatog commented on pull request #5701: URL: https://github.com/apache/nifi/pull/5701#issuecomment-1040463251 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (MINIFICPP-1752) Remove the catch2 dependency from our the test infrastructure

2022-02-15 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-1752. - Resolution: Fixed > Remove the catch2 dependency from our the test infrastructure > -

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1261: MINIFICPP-1752 Remove the catch2 dependency from our the test infrast…

2022-02-15 Thread GitBox
szaszm closed pull request #1261: URL: https://github.com/apache/nifi-minifi-cpp/pull/1261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [nifi] markobean commented on pull request #5743: NIFI-8899 - Add NiFi Registry version information to the Registry under an "about" button.

2022-02-15 Thread GitBox
markobean commented on pull request #5743: URL: https://github.com/apache/nifi/pull/5743#issuecomment-1040434810 I installed Registry to see how the UI reports the version. This is a good start. I'd like to recommend the UI dialog mimic the "About" dialog for Apache NiFi for a consistent l

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-15 Thread GitBox
szaszm commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r806978749 ## File path: CMakeLists.txt ## @@ -611,6 +612,11 @@ if (ENABLE_KUBERNETES) createExtension(KUBERNETES-EXTENSIONS "KUBERNETES EXTENSIONS" "This

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-15 Thread GitBox
adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r806966150 ## File path: CMakeLists.txt ## @@ -611,6 +612,11 @@ if (ENABLE_KUBERNETES) createExtension(KUBERNETES-EXTENSIONS "KUBERNETES EXTENSIONS

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1252: MINIFICPP-1686 - Processor destructors are not called

2022-02-15 Thread GitBox
adam-markovics commented on a change in pull request #1252: URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r806957651 ## File path: extensions/aws/processors/ListS3.h ## @@ -33,6 +33,7 @@ namespace org { namespace apache { namespace nifi { namespace mini

  1   2   >