[jira] [Updated] (NIFI-5378) NiFiProperties: Add check to validation to prevent startup when duplicate keys are encountered

2022-05-19 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean updated NIFI-5378: Affects Version/s: 1.16.1 Status: Patch Available (was: In Progress) > NiFiProperties: Add

[GitHub] [nifi] markobean opened a new pull request, #6061: NIFIDEVS-5378: prevent duplicate keys with different values in nifi.p…

2022-05-19 Thread GitBox
markobean opened a new pull request, #6061: URL: https://github.com/apache/nifi/pull/6061 …roperties # Summary When loading nifi.properties file, first check for duplicate key/value entries. Duplicate keys are allowed if their

[jira] [Assigned] (NIFI-5378) NiFiProperties: Add check to validation to prevent startup when duplicate keys are encountered

2022-05-19 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean reassigned NIFI-5378: --- Assignee: Mark Bean > NiFiProperties: Add check to validation to prevent startup when duplicate >

[jira] [Commented] (NIFI-10016) Unannounced change to flow.json.gz

2022-05-19 Thread Adam Taft (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539869#comment-17539869 ] Adam Taft commented on NIFI-10016: -- I don't disagree with this and sympathize with your perspective.

[GitHub] [nifi] github-actions[bot] closed pull request #5597: NIFI-8165 add record path support for message key

2022-05-19 Thread GitBox
github-actions[bot] closed pull request #5597: NIFI-8165 add record path support for message key URL: https://github.com/apache/nifi/pull/5597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] github-actions[bot] closed pull request #5621: NIFI-9512 Add git pull to Nifi Registry

2022-05-19 Thread GitBox
github-actions[bot] closed pull request #5621: NIFI-9512 Add git pull to Nifi Registry URL: https://github.com/apache/nifi/pull/5621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] exceptionfactory commented on pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on PR #6057: URL: https://github.com/apache/nifi/pull/6057#issuecomment-1132298273 Thanks for catching the snippet and sensitive parameter handling issues @markap14! I updated `StandardSnippetDAO` and `DtoFactory` to maintain the sensitive dynamic property names

[jira] [Updated] (NIFI-10038) Add Java 17 Platform to System Tests Workflow

2022-05-19 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10038: Status: Patch Available (was: Open) > Add Java 17 Platform to System Tests Workflow >

[GitHub] [nifi] exceptionfactory opened a new pull request, #6060: NIFI-10038 Add Java 17 to system-tests workflow

2022-05-19 Thread GitBox
exceptionfactory opened a new pull request, #6060: URL: https://github.com/apache/nifi/pull/6060 # Summary [NIFI-10038](https://issues.apache.org/jira/browse/NIFI-10038) Adds Ubuntu Java 17 as an additional platform to the GitHub system-tests workflow. # Tracking Please

[jira] [Updated] (NIFI-3869) Add HTTP/2 Support to HTTP Listening Processors

2022-05-19 Thread Nathan Gough (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Gough updated NIFI-3869: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Add HTTP/2 Support to HTTP

[jira] [Updated] (NIFI-3869) Add HTTP/2 Support to HTTP Listening Processors

2022-05-19 Thread Nathan Gough (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Gough updated NIFI-3869: --- Fix Version/s: 1.17.0 > Add HTTP/2 Support to HTTP Listening Processors >

[jira] [Commented] (NIFI-3869) Add HTTP/2 Support to HTTP Listening Processors

2022-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539795#comment-17539795 ] ASF subversion and git services commented on NIFI-3869: --- Commit

[GitHub] [nifi] thenatog closed pull request #6048: NIFI-3869 Add HTTP/2 support to ListenHTTP and HandleHttpRequest

2022-05-19 Thread GitBox
thenatog closed pull request #6048: NIFI-3869 Add HTTP/2 support to ListenHTTP and HandleHttpRequest URL: https://github.com/apache/nifi/pull/6048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] markap14 commented on pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
markap14 commented on PR #6057: URL: https://github.com/apache/nifi/pull/6057#issuecomment-1132168528 Also ran into an issue where I pushed that same flow into a nifi registry (built on the same branch) and then changed the sensitive property to use a sensitive parameter. When I checked

[GitHub] [nifi] thenatog commented on pull request #6048: NIFI-3869 Add HTTP/2 support to ListenHTTP and HandleHttpRequest

2022-05-19 Thread GitBox
thenatog commented on PR #6048: URL: https://github.com/apache/nifi/pull/6048#issuecomment-1132166287 Roger that, +1 from me will merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] markap14 commented on pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
markap14 commented on PR #6057: URL: https://github.com/apache/nifi/pull/6057#issuecomment-1132147795 @exceptionfactory I created an InvokeHTTP processor and set a breakpoint so that I could update the DTO to indicate that my newly added property was sensitive. This worked well! But

[jira] [Created] (NIFI-10038) Add Java 17 Platform to System Tests Workflow

2022-05-19 Thread David Handermann (Jira)
David Handermann created NIFI-10038: --- Summary: Add Java 17 Platform to System Tests Workflow Key: NIFI-10038 URL: https://issues.apache.org/jira/browse/NIFI-10038 Project: Apache NiFi

[GitHub] [nifi] exceptionfactory commented on pull request #6048: NIFI-3869 Add HTTP/2 support to ListenHTTP and HandleHttpRequest

2022-05-19 Thread GitBox
exceptionfactory commented on PR #6048: URL: https://github.com/apache/nifi/pull/6048#issuecomment-1132130583 > I tested this using _openssl s_client -alpn h2 -connect 127.0.0.1:8101 -status_ and _openssl s_client -alpn http/1.1 -connect 127.0.0.1:8101 -status_ commands on both ListenHTTP

[GitHub] [nifi] thenatog commented on pull request #6048: NIFI-3869 Add HTTP/2 support to ListenHTTP and HandleHttpRequest

2022-05-19 Thread GitBox
thenatog commented on PR #6048: URL: https://github.com/apache/nifi/pull/6048#issuecomment-1132126767 I tested this using _openssl s_client -alpn h2 -connect 127.0.0.1:8101 -status_ and _openssl s_client -alpn http/1.1 -connect 127.0.0.1:8101 -status_ commands on both ListenHTTP and

[GitHub] [nifi] exceptionfactory commented on pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on PR #6057: URL: https://github.com/apache/nifi/pull/6057#issuecomment-1132104446 Thanks for the initial feedback @markap14! Pushed an update implementing the changes. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (NIFI-5378) NiFiProperties: Add check to validation to prevent startup when duplicate keys are encountered

2022-05-19 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539742#comment-17539742 ] Mark Bean commented on NIFI-5378: - Reviving an old ticket. I think it is reasonable to not allow NiFi to

[GitHub] [nifi] exceptionfactory commented on pull request #6050: NIFI-8233 ListenHTTP - Add ability to filter incoming flowfile attributes

2022-05-19 Thread GitBox
exceptionfactory commented on PR #6050: URL: https://github.com/apache/nifi/pull/6050#issuecomment-1132076438 > I hear you. A user that asked me for this as they like using PostHTTP and didn't like following up with the UpdateAttribute, but you are correct. > > Still hopeful another

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on code in PR #6057: URL: https://github.com/apache/nifi/pull/6057#discussion_r877418237 ## nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/controllerservice/ControllerServiceApiValidationIT.java: ## @@ -150,4

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on code in PR #6057: URL: https://github.com/apache/nifi/pull/6057#discussion_r877417322 ## nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/NiFiClientUtil.java: ## @@ -768,6 +752,48 @@ public void

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on code in PR #6057: URL: https://github.com/apache/nifi/pull/6057#discussion_r877415864 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java: ## @@ -616,9 +616,10 @@

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on code in PR #6057: URL: https://github.com/apache/nifi/pull/6057#discussion_r877414967 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/ControllerServiceAuditor.java: ## @@ -144,13

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on code in PR #6057: URL: https://github.com/apache/nifi/pull/6057#discussion_r877414577 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/ComponentNode.java: ## @@ -190,6 +191,15

[GitHub] [nifi] NissimShiman commented on pull request #6050: NIFI-8233 ListenHTTP - Add ability to filter incoming flowfile attributes

2022-05-19 Thread GitBox
NissimShiman commented on PR #6050: URL: https://github.com/apache/nifi/pull/6050#issuecomment-1132071637 I hear you. A user that asked me for this as they like using PostHTTP and didn't like following up with the UpdateAttribute, but you are correct. Still hopeful another reviewer

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
exceptionfactory commented on code in PR #6057: URL: https://github.com/apache/nifi/pull/6057#discussion_r877413525 ## nifi-api/src/main/java/org/apache/nifi/documentation/AbstractDocumentationWriter.java: ## @@ -141,6 +142,7 @@ protected void writeBody(final

[GitHub] [nifi] markap14 commented on a diff in pull request #6057: NIFI-9958 Add Framework Support for Sensitive Dynamic Properties

2022-05-19 Thread GitBox
markap14 commented on code in PR #6057: URL: https://github.com/apache/nifi/pull/6057#discussion_r877399549 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java: ## @@ -616,9 +616,10 @@ Set

[GitHub] [nifi] NissimShiman commented on a diff in pull request #6059: NIFI-10037: When system test fails to cleanup flow, destroy the entir…

2022-05-19 Thread GitBox
NissimShiman commented on code in PR #6059: URL: https://github.com/apache/nifi/pull/6059#discussion_r877371995 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java: ## @@ -591,7

[GitHub] [nifi] NissimShiman commented on pull request #6059: NIFI-10037: When system test fails to cleanup flow, destroy the entir…

2022-05-19 Thread GitBox
NissimShiman commented on PR #6059: URL: https://github.com/apache/nifi/pull/6059#issuecomment-1132061588 A lot of subtle catches. Especially the one with potential changes in properties while looping over them (and the solution of making a copy to ensure integrity) +1 -- This is an

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6054: NIFI-10012 add XML and JSON parsing/writing for FlowEncryptor

2022-05-19 Thread GitBox
exceptionfactory commented on code in PR #6054: URL: https://github.com/apache/nifi/pull/6054#discussion_r877392930 ## nifi-commons/nifi-flow-encryptor/src/main/java/org/apache/nifi/flow/encryptor/XmlFlowEncryptor.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (NIFI-10037) Improve System Tests Resilience when one test fails

2022-05-19 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10037. - Fix Version/s: 1.17.0 1.16.2 Resolution: Fixed > Improve

[GitHub] [nifi] exceptionfactory closed pull request #6059: NIFI-10037: When system test fails to cleanup flow, destroy the entir…

2022-05-19 Thread GitBox
exceptionfactory closed pull request #6059: NIFI-10037: When system test fails to cleanup flow, destroy the entir… URL: https://github.com/apache/nifi/pull/6059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (NIFI-10037) Improve System Tests Resilience when one test fails

2022-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539725#comment-17539725 ] ASF subversion and git services commented on NIFI-10037: Commit

[jira] [Commented] (NIFI-10036) Make ElasticSearchClientImpl request URLs consistent with leading slash

2022-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539719#comment-17539719 ] ASF subversion and git services commented on NIFI-10036: Commit

[jira] [Resolved] (NIFI-10036) Make ElasticSearchClientImpl request URLs consistent with leading slash

2022-05-19 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10036. - Fix Version/s: 1.16.2 Resolution: Fixed > Make ElasticSearchClientImpl request

[GitHub] [nifi] exceptionfactory closed pull request #6058: NIFI-10036: Making Elasticsearch requests consistently lead with a /

2022-05-19 Thread GitBox
exceptionfactory closed pull request #6058: NIFI-10036: Making Elasticsearch requests consistently lead with a / URL: https://github.com/apache/nifi/pull/6058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi] turcsanyip commented on a diff in pull request #5944: NIFI-9892: Updated Azure storage related processors to adhere to NiFi…

2022-05-19 Thread GitBox
turcsanyip commented on code in PR #5944: URL: https://github.com/apache/nifi/pull/5944#discussion_r877361359 ## nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/FetchAzureBlobStorage_v12.java: ## @@ -109,11 +100,11

[GitHub] [nifi] markobean commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins

2022-05-19 Thread GitBox
markobean commented on PR #6035: URL: https://github.com/apache/nifi/pull/6035#issuecomment-1131972414 This looks really good. I could find nothing wrong with the expected behavior as well as compatibility issues which were well-thought out. Here are some of the tests I performed:

[GitHub] [nifi] thenatog commented on pull request #6048: NIFI-3869 Add HTTP/2 support to ListenHTTP and HandleHttpRequest

2022-05-19 Thread GitBox
thenatog commented on PR #6048: URL: https://github.com/apache/nifi/pull/6048#issuecomment-1131926982 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] nandorsoma commented on a diff in pull request #6034: NIFI-9916: ListenTrapSNMP USM parsing refactor.

2022-05-19 Thread GitBox
nandorsoma commented on code in PR #6034: URL: https://github.com/apache/nifi/pull/6034#discussion_r875817192 ## nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/utils/UsmReader.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1332: MINIFICPP-1831 - Download assets through the c2 protocol

2022-05-19 Thread GitBox
szaszm commented on code in PR #1332: URL: https://github.com/apache/nifi-minifi-cpp/pull/1332#discussion_r877257128 ## extensions/http-curl/tests/C2UpdateAssetTest.cpp: ## @@ -0,0 +1,260 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi] markap14 opened a new pull request, #6059: NIFI-10037: When system test fails to cleanup flow, destroy the entir…

2022-05-19 Thread GitBox
markap14 opened a new pull request, #6059: URL: https://github.com/apache/nifi/pull/6059 …e environment so that the next test starts in a healthy state. Name troubleshooting directories with the name of the test class to avoid ambiguity. Also added a log statement so that we know which

[jira] [Created] (NIFI-10037) Improve System Tests Resilience when one test fails

2022-05-19 Thread Mark Payne (Jira)
Mark Payne created NIFI-10037: - Summary: Improve System Tests Resilience when one test fails Key: NIFI-10037 URL: https://issues.apache.org/jira/browse/NIFI-10037 Project: Apache NiFi Issue

[jira] [Updated] (NIFI-10015) PutHDFS has so many daemon thread "LeaseRenewer"

2022-05-19 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10015: -- Resolution: Fixed Status: Resolved (was: Patch Available) > PutHDFS has so many

[jira] [Updated] (NIFI-10015) PutHDFS has so many daemon thread "LeaseRenewer"

2022-05-19 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10015: -- Fix Version/s: 1.17.0 > PutHDFS has so many daemon thread "LeaseRenewer" >

[jira] [Commented] (NIFI-10015) PutHDFS has so many daemon thread "LeaseRenewer"

2022-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539624#comment-17539624 ] ASF subversion and git services commented on NIFI-10015: Commit

[GitHub] [nifi] asfgit closed pull request #6051: NIFI-10015 Upgrade Hadoop from 3.3.0 to 3.3.2

2022-05-19 Thread GitBox
asfgit closed pull request #6051: NIFI-10015 Upgrade Hadoop from 3.3.0 to 3.3.2 URL: https://github.com/apache/nifi/pull/6051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] gresockj opened a new pull request, #6058: NIFI-10036: Making Elasticsearch requests consistently lead with a /

2022-05-19 Thread GitBox
gresockj opened a new pull request, #6058: URL: https://github.com/apache/nifi/pull/6058 # Summary [NIFI-10036](https://issues.apache.org/jira/browse/NIFI-10036) This changes `ElasticSearchClientServiceImpl` to submit all requests with a leading slash (/). The simplest

[jira] [Assigned] (NIFI-9677) LookUpRecord record path evaluation is "breaking" the next evaluation in case data is missing

2022-05-19 Thread Tamas Horvath (Jira)
[ https://issues.apache.org/jira/browse/NIFI-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Horvath reassigned NIFI-9677: --- Assignee: Tamas Horvath > LookUpRecord record path evaluation is "breaking" the next

[jira] [Created] (NIFI-10036) Make ElasticSearchClientImpl request URLs consistent with leading slash

2022-05-19 Thread Joe Gresock (Jira)
Joe Gresock created NIFI-10036: -- Summary: Make ElasticSearchClientImpl request URLs consistent with leading slash Key: NIFI-10036 URL: https://issues.apache.org/jira/browse/NIFI-10036 Project: Apache

[jira] [Assigned] (MINIFICPP-1843) Implement PutElasticsearchJson and ElasticSearchClientServiceImpl

2022-05-19 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink reassigned MINIFICPP-1843: -- Assignee: Martin Zink > Implement PutElasticsearchJson and

[jira] [Created] (MINIFICPP-1843) Implement PutElasticsearchJson and ElasticSearchClientServiceImpl

2022-05-19 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-1843: --- Summary: Implement PutElasticsearchJson and ElasticSearchClientServiceImpl Key: MINIFICPP-1843 URL: https://issues.apache.org/jira/browse/MINIFICPP-1843

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
szaszm commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r877083728 ## libminifi/include/utils/tls/CertificateUtils.h: ## @@ -43,14 +50,53 @@ struct X509_deleter { }; using X509_unique_ptr = std::unique_ptr; +struct

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
szaszm commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r877083728 ## libminifi/include/utils/tls/CertificateUtils.h: ## @@ -43,14 +50,53 @@ struct X509_deleter { }; using X509_unique_ptr = std::unique_ptr; +struct

[jira] [Updated] (MINIFICPP-1828) InvokeHTTP Attributes to Send empty value means "send all", but it should mean "send none" according to docs

2022-05-19 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1828: Resolution: Fixed Status: Resolved (was: Patch Available) > InvokeHTTP

[jira] [Updated] (MINIFICPP-1831) C2 asset download command

2022-05-19 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1831: Status: Patch Available (was: Open)

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
adamdebreceni commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r876913104 ## libminifi/src/controllers/SSLContextService.cpp: ## @@ -175,51 +176,31 @@ bool SSLContextService::configure_ssl_context(SSL_CTX *ctx) { } bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
adamdebreceni commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r876908856 ## libminifi/src/utils/tls/CertificateUtils.cpp: ## @@ -116,6 +143,110 @@ EVP_PKEY_unique_ptr extractPrivateKey(const PCCERT_CONTEXT certificate) { }

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
adamdebreceni commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r876876452 ## libminifi/include/utils/tls/CertificateUtils.h: ## @@ -43,14 +50,53 @@ struct X509_deleter { }; using X509_unique_ptr = std::unique_ptr; +struct

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
adamdebreceni commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r876758518 ## libminifi/src/controllers/SSLContextService.cpp: ## @@ -563,6 +559,89 @@ void SSLContextService::initializeProperties() {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
adamdebreceni commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r876758283 ## libminifi/src/controllers/SSLContextService.cpp: ## @@ -563,6 +559,89 @@ void SSLContextService::initializeProperties() {

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1336: MINIFICPP-1826 - Warn on expiring certificate

2022-05-19 Thread GitBox
adamdebreceni commented on code in PR #1336: URL: https://github.com/apache/nifi-minifi-cpp/pull/1336#discussion_r876746371 ## libminifi/include/utils/tls/CertificateUtils.h: ## @@ -43,14 +50,53 @@ struct X509_deleter { }; using X509_unique_ptr = std::unique_ptr; +struct

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1332: MINIFICPP-1831 - Download assets through the c2 protocol

2022-05-19 Thread GitBox
adamdebreceni commented on code in PR #1332: URL: https://github.com/apache/nifi-minifi-cpp/pull/1332#discussion_r876735094 ## extensions/http-curl/tests/C2UpdateAssetTest.cpp: ## @@ -0,0 +1,260 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (NIFI-10021) Apache Nifi Web Server keeps failing to start with Decryption exception

2022-05-19 Thread Andreas Adamides (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539376#comment-17539376 ] Andreas Adamides commented on NIFI-10021: - It was an issue with nifi.sensitive.props.key , thanks

[jira] [Resolved] (NIFI-10021) Apache Nifi Web Server keeps failing to start with Decryption exception

2022-05-19 Thread Andreas Adamides (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Adamides resolved NIFI-10021. - Resolution: Not A Problem > Apache Nifi Web Server keeps failing to start with