lizhizhou commented on PR #6416:
URL: https://github.com/apache/nifi/pull/6416#issuecomment-1360691610
@exceptionfactory Thanks for the review and all comments are resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/NIFI-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650021#comment-17650021
]
Paul Grey commented on NIFI-10997:
--
Controller service enable/disable also impacted.
>
exceptionfactory commented on code in PR #6798:
URL: https://github.com/apache/nifi/pull/6798#discussion_r1053708567
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##
@@ -372,4 +382,27 @@ pri
dan-s1 commented on code in PR #6798:
URL: https://github.com/apache/nifi/pull/6798#discussion_r1053707406
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##
@@ -372,4 +382,27 @@ private Sourc
exceptionfactory commented on code in PR #6798:
URL: https://github.com/apache/nifi/pull/6798#discussion_r1053696166
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##
@@ -372,4 +382,27 @@ pri
dan-s1 commented on code in PR #6798:
URL: https://github.com/apache/nifi/pull/6798#discussion_r1053680263
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##
@@ -372,4 +382,27 @@ private Sourc
dan-s1 commented on code in PR #6798:
URL: https://github.com/apache/nifi/pull/6798#discussion_r1053680263
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##
@@ -372,4 +382,27 @@ private Sourc
exceptionfactory commented on code in PR #6798:
URL: https://github.com/apache/nifi/pull/6798#discussion_r1053670702
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##
@@ -372,4 +382,27 @@ pri
[
https://issues.apache.org/jira/browse/NIFI-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649946#comment-17649946
]
ASF subversion and git services commented on NIFI-10984:
Commit 6
ottobackwards merged PR #6784:
URL: https://github.com/apache/nifi/pull/6784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apa
ottobackwards commented on PR #6784:
URL: https://github.com/apache/nifi/pull/6784#issuecomment-1360045744
LGTM, thanks for the contribution ;)
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/NIFI-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess reassigned NIFI-10998:
---
Assignee: Matt Burgess
> SplitJson does not honor latest setting for JsonPath Expression
> -
joewitt commented on PR #6685:
URL: https://github.com/apache/nifi/pull/6685#issuecomment-1360012142
sorry about that Mark - i have been thinking ever since I saw that note
before you were. My mistake.
I think if tests existed you should be able to add to them. Creating tests
where
Matt Burgess created NIFI-10998:
---
Summary: SplitJson does not honor latest setting for JsonPath
Expression
Key: NIFI-10998
URL: https://issues.apache.org/jira/browse/NIFI-10998
Project: Apache NiFi
NissimShiman commented on PR #6685:
URL: https://github.com/apache/nifi/pull/6685#issuecomment-1359998180
@joewitt I think that could be done. i.e. a unit test for this in
SnippetUtilsTest (
https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi
markobean commented on PR #6685:
URL: https://github.com/apache/nifi/pull/6685#issuecomment-1359924493
Reminder @joewitt - I did not merge because I am not a committer.
As far as unit tests, it may be reasonable to add, but this feels more like
an integration testing option. And mig
dan-s1 commented on PR #6798:
URL: https://github.com/apache/nifi/pull/6798#issuecomment-1359922428
@exceptionfactory So i ended up only removing the method setMessageReceiver.
With that, the only issue which remains is when there is a warning from
xsl:message for some reason its not redire
joewitt commented on PR #6685:
URL: https://github.com/apache/nifi/pull/6685#issuecomment-1359879872
Huh - i just noticed @markobean did review this. @markobean any reason you
didn't merge it?
Got ya on tests @NissimShiman . Do you think you could create a reasonable
test with reas
NissimShiman commented on PR #6685:
URL: https://github.com/apache/nifi/pull/6685#issuecomment-1359870811
@joewitt That is a fair point. For some reason this area of code is lightly
tested (i.e. there are no unit tests for the method this is called in. And
that goes for all the parent met
[
https://issues.apache.org/jira/browse/MINIFICPP-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1948:
--
Description:
Is it possible, when logging to spdlog, to add the output of the ident
Paul Grey created NIFI-10997:
Summary: Ensure auditing of process group / controller service
operations
Key: NIFI-10997
URL: https://issues.apache.org/jira/browse/NIFI-10997
Project: Apache NiFi
exceptionfactory commented on PR #6798:
URL: https://github.com/apache/nifi/pull/6798#issuecomment-1359749445
Thanks @dan-s1, I was expecting something related to the message output, but
on further review, I see the success and failure output scenarios, which seem
worth maintaining.
--
T
dan-s1 commented on PR #6798:
URL: https://github.com/apache/nifi/pull/6798#issuecomment-1359669064
@exceptionfactory They actually do assert behavior when terminate is used
whether the transform succeeds (terminate=no) or fails (terminate=yes).
--
This is an automated message from the
joewitt commented on PR #6685:
URL: https://github.com/apache/nifi/pull/6685#issuecomment-1359584735
Are there existing unit tests you could add to which would show the fix has
the intended result?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
fgerlits commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1053449250
##
libminifi/include/core/logging/LoggerConfiguration.h:
##
@@ -133,16 +132,21 @@ class LoggerConfiguration {
class LoggerImpl : public Logger {
publi
[
https://issues.apache.org/jira/browse/MINIFICPP-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1948:
--
Description:
Is it possible, when logging to spdlog, to add the output of the ident
szaszm commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1053362619
##
libminifi/include/core/logging/LoggerConfiguration.h:
##
@@ -133,16 +132,21 @@ class LoggerConfiguration {
class LoggerImpl : public Logger {
public:
szaszm commented on code in PR #1434:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#discussion_r1053418593
##
extensions/windows-event-log/wel/WindowsEventLog.cpp:
##
@@ -25,64 +25,67 @@
#include "UnicodeConversion.h"
#include "utils/Deleters.h"
#include "utils/gsl
martinzink commented on code in PR #1434:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#discussion_r1053418228
##
extensions/windows-event-log/wel/MetadataWalker.h:
##
@@ -95,16 +90,12 @@ class MetadataWalker : public pugi::xml_tree_walker {
const WindowsEventLog
martinzink commented on code in PR #1434:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#discussion_r1053416581
##
extensions/windows-event-log/wel/WindowsEventLog.cpp:
##
@@ -158,51 +159,59 @@ std::string
WindowsEventLogMetadataImpl::getEventData(EVT_FORMAT_MESSAGE_F
martinzink commented on code in PR #1434:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#discussion_r1053415102
##
libminifi/src/utils/OsUtils.cpp:
##
@@ -284,6 +284,22 @@ int64_t OsUtils::getTotalPagingFileSize() {
DWORDLONG total_paging_file_size = memory_info.ull
mr1716 opened a new pull request, #6799:
URL: https://github.com/apache/nifi/pull/6799
# Summary
[NIFI-10995](https://issues.apache.org/jira/browse/NIFI-10995)
# Tracking
Please complete the following tracking steps prio
[
https://issues.apache.org/jira/browse/NIFI-7686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649796#comment-17649796
]
Philipp Korniets commented on NIFI-7686:
this will be so helpfull
> Support multi
[
https://issues.apache.org/jira/browse/NIFI-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649751#comment-17649751
]
Josef Zahner commented on NIFI-10985:
-
We had a pretty similar issue when we upgraded
Josef Zahner created NIFI-10996:
---
Summary: CSV output with header - but always, even for 0 record
flowfiles
Key: NIFI-10996
URL: https://issues.apache.org/jira/browse/NIFI-10996
Project: Apache NiFi
[
https://issues.apache.org/jira/browse/NIFI-10995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike R reassigned NIFI-10995:
-
Assignee: Mike R
> Update Jetty Version To 9.4.50.v20221201
>
Mike R created NIFI-10995:
-
Summary: Update Jetty Version To 9.4.50.v20221201
Key: NIFI-10995
URL: https://issues.apache.org/jira/browse/NIFI-10995
Project: Apache NiFi
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/NIFI-10994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens M Kofoed updated NIFI-10994:
-
Description:
Comparing the new ListSMB proccessor to other ListXXX proccessors (FTP, SFTP,
FILE)
Jens M Kofoed created NIFI-10994:
Summary: Add file/path filter and search recursive in ListSMB
Key: NIFI-10994
URL: https://issues.apache.org/jira/browse/NIFI-10994
Project: Apache NiFi
Iss
[
https://issues.apache.org/jira/browse/NIFI-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649687#comment-17649687
]
Jens M Kofoed commented on NIFI-10964:
--
In FetchSFTP you have the following function
[
https://issues.apache.org/jira/browse/NIFI-10853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649671#comment-17649671
]
Jens M Kofoed commented on NIFI-10853:
--
The RouteOnAttribute takes in an expression
lizhizhou commented on code in PR #6416:
URL: https://github.com/apache/nifi/pull/6416#discussion_r1053102304
##
nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/main/java/org/apache/nifi/processors/PutIoTDBRecord.java:
##
@@ -0,0 +1,283 @@
+/*
+ * Licensed to the Ap
Eetami commented on code in PR #6782:
URL: https://github.com/apache/nifi/pull/6782#discussion_r1053077940
##
nifi-nar-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/src/main/java/org/apache/nifi/oauth2/StandardOauth2AccessTokenProvider.java:
###
43 matches
Mail list logo
