Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]

2023-12-27 Thread via GitHub
exceptionfactory commented on code in PR #8152: URL: https://github.com/apache/nifi/pull/8152#discussion_r1435330854 ## nifi-commons/nifi-utils/src/test/java/org/apache/nifi/retry/ExceptionExcludingRetryConditionTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] NIFI-12529: Enable/Disable Controller Service [nifi]

2023-12-27 Thread via GitHub
mcgilman commented on PR #8185: URL: https://github.com/apache/nifi/pull/8185#issuecomment-1870672940 Thanks for the review @rfellows! I've pushed a new commit addressing the items you outlined. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework

2023-12-27 Thread Rob Fellows (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit

[jira] [Created] (NIFI-12552) Add pagination to Summary tables

2023-12-27 Thread Rob Fellows (Jira)
Rob Fellows created NIFI-12552: -- Summary: Add pagination to Summary tables Key: NIFI-12552 URL: https://issues.apache.org/jira/browse/NIFI-12552 Project: Apache NiFi Issue Type: Sub-task

Re: [PR] NIFI-12529: Enable/Disable Controller Service [nifi]

2023-12-27 Thread via GitHub
rfellows commented on code in PR #8185: URL: https://github.com/apache/nifi/pull/8185#discussion_r1437221742 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/app.module.ts: ## @@ -56,7 +57,13 @@ import { MatDialogModule }

Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]

2023-12-27 Thread via GitHub
ravinarayansingh commented on code in PR #7544: URL: https://github.com/apache/nifi/pull/7544#discussion_r1437177360 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java: ## @@ -460,15

Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]

2023-12-27 Thread via GitHub
dan-s1 commented on code in PR #7544: URL: https://github.com/apache/nifi/pull/7544#discussion_r1437164753 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java: ## @@ -460,15 +488,18 @@

[jira] [Created] (NIFI-12551) Fix dialog resizing when changing tabs

2023-12-27 Thread Rob Fellows (Jira)
Rob Fellows created NIFI-12551: -- Summary: Fix dialog resizing when changing tabs Key: NIFI-12551 URL: https://issues.apache.org/jira/browse/NIFI-12551 Project: Apache NiFi Issue Type: Sub-task

Re: [PR] Nifi 12505 system diagnostics [nifi]

2023-12-27 Thread via GitHub
mcgilman commented on PR #8190: URL: https://github.com/apache/nifi/pull/8190#issuecomment-1870440114 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] NIFI-12529: Enable/Disable Controller Service [nifi]

2023-12-27 Thread via GitHub
rfellows commented on PR #8185: URL: https://github.com/apache/nifi/pull/8185#issuecomment-1870425764 reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (NIFI-12547) Fix issue with Property Editor Width

2023-12-27 Thread Rob Fellows (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12547: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-12547) Fix issue with Property Editor Width

2023-12-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800817#comment-17800817 ] ASF subversion and git services commented on NIFI-12547: Commit

Re: [PR] NIFI-12547: Set the width of the Property editor. [nifi]

2023-12-27 Thread via GitHub
rfellows merged PR #8188: URL: https://github.com/apache/nifi/pull/8188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] NIFI-12547: Set the width of the Property editor. [nifi]

2023-12-27 Thread via GitHub
rfellows commented on PR #8188: URL: https://github.com/apache/nifi/pull/8188#issuecomment-1870407007 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] NIFI-12394 when synching to a VersionedFlow, make sure processor references to new controller services are valid [nifi]

2023-12-27 Thread via GitHub
NissimShiman commented on PR #8184: URL: https://github.com/apache/nifi/pull/8184#issuecomment-1870398821 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (NIFI-12505) System Diagnostics

2023-12-27 Thread Rob Fellows (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12505: --- Status: Patch Available (was: In Progress) > System Diagnostics > -- > >

[PR] Nifi 12505 system diagnostics [nifi]

2023-12-27 Thread via GitHub
rfellows opened a new pull request, #8190: URL: https://github.com/apache/nifi/pull/8190 # Summary [NIFI-12505](https://issues.apache.org/jira/browse/NIFI-12505) * Added System Diagnostics dialog * Refactored Status History to follow the same pattern where we use one action

Re: [PR] NIFI-12529: Enable/Disable Controller Service [nifi]

2023-12-27 Thread via GitHub
rfellows commented on PR #8185: URL: https://github.com/apache/nifi/pull/8185#issuecomment-1870277075 will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] NIFI-12411: Update PublishAMQP to read AMQP headers value from FlowFile attributes and `amq$headers` string [nifi]

2023-12-27 Thread via GitHub
umarhussain15 commented on code in PR #8105: URL: https://github.com/apache/nifi/pull/8105#discussion_r1437011582 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -191,6 +204,19 @@ public class

Re: [PR] NIFI-12411: Update PublishAMQP to read AMQP headers value from FlowFile attributes and `amq$headers` string [nifi]

2023-12-27 Thread via GitHub
umarhussain15 commented on code in PR #8105: URL: https://github.com/apache/nifi/pull/8105#discussion_r1437008408 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java: ## @@ -58,36 +59,42 @@ + "that

[jira] [Created] (NIFI-12550) Support OIDC Device Authorization Grant for API

2023-12-27 Thread Igor Milavec (Jira)
Igor Milavec created NIFI-12550: --- Summary: Support OIDC Device Authorization Grant for API Key: NIFI-12550 URL: https://issues.apache.org/jira/browse/NIFI-12550 Project: Apache NiFi Issue

[jira] [Created] (NIFI-12549) Failing to change version when using parameter context provider

2023-12-27 Thread Gal Doron (Jira)
Gal Doron created NIFI-12549: Summary: Failing to change version when using parameter context provider Key: NIFI-12549 URL: https://issues.apache.org/jira/browse/NIFI-12549 Project: Apache NiFi