Re: [PR] NIFI-12501 Encrypt MiNiFi bootstrap properties [nifi]

2024-01-05 Thread via GitHub
briansolo1985 commented on code in PR #8151: URL: https://github.com/apache/nifi/pull/8151#discussion_r1442662592 ## minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/status/reporters/StatusLoggerTest.java: ## @@ -142,10 +144,7 @@ public void testError() {

Re: [PR] MINIFICPP-2264 GenerateFlowFile: 'Custom Text' should be reevaluated … [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
martinzink commented on code in PR #1706: URL: https://github.com/apache/nifi-minifi-cpp/pull/1706#discussion_r1442770133 ## extensions/standard-processors/processors/GenerateFlowFile.cpp: ## @@ -58,57 +58,69 @@ void generateData(std::vector& data, bool textData = false) { }

Re: [PR] MINIFICPP-2264 GenerateFlowFile: 'Custom Text' should be reevaluated … [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
martinzink commented on code in PR #1706: URL: https://github.com/apache/nifi-minifi-cpp/pull/1706#discussion_r1442772416 ## extensions/standard-processors/processors/GenerateFlowFile.cpp: ## @@ -58,57 +58,69 @@ void generateData(std::vector& data, bool textData = false) { }

Re: [PR] MINIFICPP-2229 Encrypt sensitive properties in the flow configuration [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
martinzink commented on PR #1708: URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#issuecomment-1878611363 I found a couple more properties we might wanna flag as sensitive https://github.com/fgerlits/nifi-minifi-cpp/blob/MINIFICPP-2229_Encrypt-sensitive-properties-in-the-flow

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
martinzink commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1418662196 ## cmake/MiNiFiOptions.cmake: ## @@ -122,6 +122,7 @@ add_minifi_option(ENABLE_KUBERNETES "Enables the Kubernetes extensions." ON) add_minifi_option(ENABLE_

Re: [PR] MINIFICPP-2264 GenerateFlowFile: 'Custom Text' should be reevaluated … [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
fgerlits commented on code in PR #1706: URL: https://github.com/apache/nifi-minifi-cpp/pull/1706#discussion_r1442836812 ## extensions/standard-processors/processors/GenerateFlowFile.cpp: ## @@ -57,58 +56,78 @@ void generateData(std::vector& data, bool textData = false) { }

Re: [PR] MINIFICPP-2217 - Implement jolt processor shift operation [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
martinzink commented on code in PR #1692: URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#discussion_r1442844633 ## extensions/standard-processors/processors/JoltTransformJSON.h: ## Review Comment: pinging @adamdebreceni in case he missed this comment -- This i

Re: [PR] MINIFICPP-2217 - Implement jolt processor shift operation [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
martinzink commented on PR #1692: URL: https://github.com/apache/nifi-minifi-cpp/pull/1692#issuecomment-1878629785 There are some conflicts, could you rebase and make sure the CI is green? (the current windows build errors seem to be related) -- This is an automated message from the Apach

Re: [PR] MINIFICPP-2229 Encrypt sensitive properties in the flow configuration [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
fgerlits commented on PR #1708: URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#issuecomment-1878680825 > I found a couple more properties we might wanna flag as sensitive Thanks! I have added them in d3228e93aa06a98189d08005ba4e4095ef007a04. -- This is an automated messag

Re: [PR] MINIFICPP-2244 Update MiNiFi C2 and tests to support NiFi 2.0 [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
szaszm closed pull request #1702: MINIFICPP-2244 Update MiNiFi C2 and tests to support NiFi 2.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/1702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINIFICPP-2275 Use utils::string instead of utils::StringUtils [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
szaszm closed pull request #1710: MINIFICPP-2275 Use utils::string instead of utils::StringUtils URL: https://github.com/apache/nifi-minifi-cpp/pull/1710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINIFICPP-2280 link CoreServices to libcURL to support macOS Sonoma [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
szaszm closed pull request #1711: MINIFICPP-2280 link CoreServices to libcURL to support macOS Sonoma URL: https://github.com/apache/nifi-minifi-cpp/pull/1711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINIFICPP-1951 - Prevent append overwriting resource [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
szaszm closed pull request #1640: MINIFICPP-1951 - Prevent append overwriting resource URL: https://github.com/apache/nifi-minifi-cpp/pull/1640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Updated] (MINIFICPP-2280) Curl crashes on macOS Sonoma

2024-01-05 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2280: --- Resolution: Fixed Status: Resolved (was: Patch Available) https://github.com/apa

[jira] [Updated] (MINIFICPP-2244) C2: Change JSON flow definition mimetype to application/json

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2244: Fix Version/s: 0.16.0 > C2: Change JSON flow definition mimetype to application/json >

[jira] [Resolved] (MINIFICPP-2244) C2: Change JSON flow definition mimetype to application/json

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2244. - Resolution: Done > C2: Change JSON flow definition mimetype to application/json > ---

[jira] [Resolved] (MINIFICPP-1951) Parallel DefragmentTexts should not rewrite each other's content

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-1951. - Resolution: Fixed > Parallel DefragmentTexts should not rewrite each other's content

[jira] [Updated] (MINIFICPP-1951) Parallel DefragmentTexts should not rewrite each other's content

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1951: Fix Version/s: 0.16.0 > Parallel DefragmentTexts should not rewrite each other's conten

[jira] [Updated] (MINIFICPP-2275) Use utils::string instead of utils::StringUtils

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2275: Fix Version/s: 0.16.0 > Use utils::string instead of utils::StringUtils > -

[jira] [Resolved] (MINIFICPP-2275) Use utils::string instead of utils::StringUtils

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2275. - Resolution: Done > Use utils::string instead of utils::StringUtils >

[jira] [Resolved] (MINIFICPP-2271) Upgrade AWS SDK C++ and add new AWS regions

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2271. - Resolution: Resolved > Upgrade AWS SDK C++ and add new AWS regions >

[jira] [Resolved] (MINIFICPP-2274) Ship Markdown docs in binary packages

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2274. - Resolution: Fixed > Ship Markdown docs in binary packages > -

[jira] [Assigned] (MINIFICPP-2274) Ship Markdown docs in binary packages

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz reassigned MINIFICPP-2274: --- Assignee: Marton Szasz > Ship Markdown docs in binary packages > ---

[jira] [Resolved] (MINIFICPP-2265) Add AttributeRollingWindow and EL nextInt

2024-01-05 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2265. - Resolution: Done > Add AttributeRollingWindow and EL nextInt > --

[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework

2024-01-05 Thread Matt Gilman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [

[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework

2024-01-05 Thread Matt Gilman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [

[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework

2024-01-05 Thread Matt Gilman (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [

Re: [PR] NIFI-12569 Upgrade Iceberg from 1.4.2 to 1.4.3 [nifi]

2024-01-05 Thread via GitHub
asfgit closed pull request #8206: NIFI-12569 Upgrade Iceberg from 1.4.2 to 1.4.3 URL: https://github.com/apache/nifi/pull/8206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (NIFI-12569) Upgrade Iceberg to 1.4.3

2024-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803613#comment-17803613 ] ASF subversion and git services commented on NIFI-12569: Commit 2

[jira] [Commented] (NIFI-12569) Upgrade Iceberg to 1.4.3

2024-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803614#comment-17803614 ] ASF subversion and git services commented on NIFI-12569: Commit 1

[jira] [Updated] (NIFI-12569) Upgrade Iceberg to 1.4.3

2024-01-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12569: -- Fix Version/s: 1.25.0 2.0.0 Resolution: Fixed Status: Resol

[jira] [Updated] (NIFI-12555) UI - Property with .dependsOn() incorrectly being displayed

2024-01-05 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean updated NIFI-12555: - Attachment: TestCustomProcessor.java > UI - Property with .dependsOn() incorrectly being displayed >

[jira] [Updated] (NIFI-12555) UI - Property with .dependsOn() incorrectly being displayed

2024-01-05 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean updated NIFI-12555: - Description: Consider PROPERTY_1 with: .dependsOn(PROPERTY_2, "foo")   In the UI, when Property 2 is s

[jira] [Commented] (NIFI-12555) UI - Property with .dependsOn() incorrectly being displayed

2024-01-05 Thread Mark Bean (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803616#comment-17803616 ] Mark Bean commented on NIFI-12555: -- I attached code for a sample custom processor which

Re: [PR] MINIFICPP-2229 Encrypt sensitive properties in the flow configuration [nifi-minifi-cpp]

2024-01-05 Thread via GitHub
szaszm commented on code in PR #1708: URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#discussion_r1443124349 ## libminifi/src/core/flow/StructuredConfiguration.cpp: ## @@ -620,20 +628,26 @@ void StructuredConfiguration::parseRPGPort(const Node& port_node, core::Process

[jira] [Commented] (NIFI-12555) UI - Property with .dependsOn() incorrectly being displayed

2024-01-05 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803634#comment-17803634 ] Peter Turcsanyi commented on NIFI-12555: Thanks [~markbean] for the example! I ha

[PR] [NIFI-12563] configure reporting task [nifi]

2024-01-05 Thread via GitHub
scottyaslan opened a new pull request, #8208: URL: https://github.com/apache/nifi/pull/8208 [NIFI-12563](https://issues.apache.org/jira/browse/NIFI-12563) Configure Reporting Task: ![Kapture 2024-01-05 at 13 03 30](https://github.com/apache/nifi/assets/6797571/d504929e-94db-4fa

[jira] [Created] (NIFI-12571) Upgrade Logback to 1.4.14

2024-01-05 Thread David Handermann (Jira)
David Handermann created NIFI-12571: --- Summary: Upgrade Logback to 1.4.14 Key: NIFI-12571 URL: https://issues.apache.org/jira/browse/NIFI-12571 Project: Apache NiFi Issue Type: Improvement

[PR] NIFI-12571 Upgrade Logback from 1.3.14 to 1.4.14 [nifi]

2024-01-05 Thread via GitHub
exceptionfactory opened a new pull request, #8209: URL: https://github.com/apache/nifi/pull/8209 # Summary [NIFI-12571](https://issues.apache.org/jira/browse/NIFI-12571) Upgrades Logback from 1.3.14 to 1.4.14. [Logback](https://logback.qos.ch/news.html) 1.3 and 1.4 have the sam

[jira] [Updated] (NIFI-12571) Upgrade Logback to 1.4.14

2024-01-05 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12571: Status: Patch Available (was: Open) > Upgrade Logback to 1.4.14 >

Re: [PR] NIFI-8932: Add capability to skip first N rows in CSVReader [nifi]

2024-01-05 Thread via GitHub
mattyb149 commented on code in PR #7952: URL: https://github.com/apache/nifi/pull/7952#discussion_r1443377852 ## nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/AbstractCSVRecordReader