[GitHub] nifi issue #1800: NIFI-3681 - Controller Service for Processor Leader Electi...

2017-05-17 Thread GrayGwizdz
Github user GrayGwizdz commented on the issue: https://github.com/apache/nifi/pull/1800 You might want to consider importing KeeperException so catch (KeeperException.NodeExistsException e) doesn't need the class in multiple places You also might want to consider refactori

[GitHub] nifi issue #1747: [NIFI-3716] Flowfile analyzer tool created

2017-05-09 Thread GrayGwizdz
Github user GrayGwizdz commented on the issue: https://github.com/apache/nifi/pull/1747 Reading through the code everything looks good, I always err on the side of the more test cases the better but I think you have your bases covered. --- If your project is set up for it, you can