[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r218401389 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r218401302 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/pom.xml --- @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r218200235 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r218199589 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2992 Sounds good. We can put this on hold while you do that client service PR. ---

[GitHub] nifi pull request #2872: NIFI-5318 Implement NiFi test harness: initial comm...

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2872#discussion_r218193985 --- Diff: nifi-docs/src/main/asciidoc/developer-guide.adoc --- @@ -2296,6 +2296,32 @@ threads that should be used to run the Processor can be set via

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r218172006 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r218170885 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi issue #3007: NIFI-5596 Upgraded splunk-sdk-java version

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3007 Merged, thanks for the contribution. @mohitgargk can you manually close this? I got distracted and forgot to add the "closes" line. Thanks. ---

[GitHub] nifi issue #3007: NIFI-5596 Upgraded splunk-sdk-java version

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3007 @mohitgargk it's mostly copy pasta, so I'll do it. ---

[GitHub] nifi issue #3007: NIFI-5596 Upgraded splunk-sdk-java version

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3007 Yes. Wanted to verify before putting @mohitgargk on a wild goose chase. ---

[GitHub] nifi issue #3007: NIFI-5596 Upgraded splunk-sdk-java version

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3007 The change itself LGTM, but awaiting L&N feedback. ---

[GitHub] nifi issue #3007: NIFI-5596 Upgraded splunk-sdk-java version

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3007 @joewitt I noticed that it adds bouncy castle and jbCrypt. These are transitive depdenencies that come in from security-utils. Should the be added to L&N? ``` [

[GitHub] nifi issue #2896: NIFI-5239 Made a client service an optional source of conn...

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2896 @zenfenan updated the capabilitydescription. That was the only change I felt I could make without running afoul of our policies on changes. ---

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r218059033 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r218058211 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBControllerService.java --- @@ -17,156

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r218057634 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBControllerService.java --- @@ -17,156

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2992 NP. We should discuss making a controller service that handles the connection pooling for Cassandra. Doesn't have to go in here, but it would be one less thing to update if it were. ---

[GitHub] nifi pull request #2896: NIFI-5239 Made a client service an optional source ...

2018-09-17 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2896#discussion_r218051121 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBControllerService.java --- @@ -17,156

[GitHub] nifi issue #3003: NIFI-5596 : Upgraded splunk-sdk-java version

2018-09-16 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3003 That concern wasn't over the CI issues, but over breaking compatibility by dropping support for versions of Splunk that need to be supported. ---

[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-16 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 [ES_Lookup_Test.xml.txt](https://github.com/apache/nifi/files/2386507/ES_Lookup_Test.xml.txt) [5051 Kibana Commands](https://github.com/apache/nifi/files/2386508/5051.kibana.txt

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r217899955 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r217899033 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r217898996 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -150,6 +172,7

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r217884483 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -150,6 +172,7

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-15 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r217884439 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r217798455 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java --- @@ -0,0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r217798314 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #2920: NIFI-5449: Added Base64 Encode/Decode functions to RecordP...

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2920 Merged. Thanks @mattyb149 ---

[GitHub] nifi pull request #2892: NIFI-1184 Mock FileSystem for PutHDFSTest

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2892#discussion_r217718166 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/PutHDFSTest.java --- @@ -362,32

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r217756404 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r217751008 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2920: NIFI-5449: Added Base64 Encode/Decode functions to ...

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2920#discussion_r217716411 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Base64Encode.java --- @@ -0,0 +1,58

[GitHub] nifi issue #2896: NIFI-5239 Made a client service an optional source of conn...

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2896 @zenfenan the reason I asked you to do this one first before I reopen 5333 is that I realized it contains updates to the controller service and configuration properties that are required to

[GitHub] nifi issue #3003: NIFI-5596 : Upgraded splunk-sdk-java version

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/3003 You're 2/3 on Travis, so don't worry. Did you try this new Splunk client with different versions of Splunk? ---

[GitHub] nifi pull request #2993: NIFI-5333 Added GetMongoRecord.

2018-09-14 Thread MikeThomsen
Github user MikeThomsen closed the pull request at: https://github.com/apache/nifi/pull/2993 ---

[GitHub] nifi issue #2993: NIFI-5333 Added GetMongoRecord.

2018-09-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2993 @zenfenan I got to thinking about it, and I think it needs [this](https://github.com/apache/nifi/pull/2896) one done first to make it work right. So I'm going to close this out until that o

[GitHub] nifi issue #2896: NIFI-5239 Made a client service an optional source of conn...

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2896 @mattyb149 can you take a look? I attached a flow that exercises all of the processors with this change. It just needs mongo running like `docker run -d -p 27017:27017 --name mongo_test

[GitHub] nifi issue #2896: NIFI-5239 Made a client service an optional source of conn...

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2896 [Mongo_Client_Service_Test.xml.txt](https://github.com/apache/nifi/files/2380858/Mongo_Client_Service_Test.xml.txt) Test flow for all of the processors. ---

[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2615 @mattyb149 can we close this out? ---

[GitHub] nifi pull request #2945: NIFI-4517: Added ExecuteSQLRecord and QueryDatabase...

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2945#discussion_r217485802 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractQueryDatabaseTable.java

[GitHub] nifi pull request #2945: NIFI-4517: Added ExecuteSQLRecord and QueryDatabase...

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2945#discussion_r216874550 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/sql/SqlWriter.java

[GitHub] nifi pull request #2945: NIFI-4517: Added ExecuteSQLRecord and QueryDatabase...

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2945#discussion_r217414116 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java

[GitHub] nifi pull request #2945: NIFI-4517: Added ExecuteSQLRecord and QueryDatabase...

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2945#discussion_r216874412 --- Diff: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java --- @@ -63,6 +63,19 @@ public RecordSchema

[GitHub] nifi issue #2993: NIFI-5333 Added GetMongoRecord.

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2993 @zenfenan any updates? ---

[GitHub] nifi issue #2896: NIFI-5239 Made a client service an optional source of conn...

2018-09-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2896 @zenfenan any updates? ---

[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation

2018-09-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2999 Merged. Thanks for the contribution. ---

[GitHub] nifi pull request #2999: NIFI-5589 : Clarify PutMongo documentation

2018-09-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2999#discussion_r217172110 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -112,8

[GitHub] nifi pull request #2999: NIFI-5589 : Clarify PutMongo documentation

2018-09-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2999#discussion_r217171902 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -112,8

[GitHub] nifi pull request #2999: NIFI-5589 : Clarify PutMongo documentation

2018-09-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2999#discussion_r217170815 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -112,8

[GitHub] nifi pull request #2999: NIFI-5589 : Clarify PutMongo documentation

2018-09-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2999#discussion_r217169836 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -112,8

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216783486 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216785597 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/test/java/org/apache/nifi/processors/neo4j/ITNeo4JCyperExecutor.java --- @@ -0,0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216781949 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/pom.xml --- @@ -0,0 +1,87 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216782816 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216784900 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java --- @@ -0,0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216781060 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,202

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216783144 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216785691 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/test/java/org/apache/nifi/processors/neo4j/ITNeo4JCyperExecutor.java --- @@ -0,0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216780813 --- Diff: nifi-assembly/NOTICE --- @@ -1135,6 +1135,11 @@ The following binary components are provided under the Apache Software License v

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216784220 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java --- @@ -0,0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216783723 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r216781672 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,31 @@ +nifi-neo4j-nar --- End diff

[GitHub] nifi issue #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2820 @PrashanthVenkatesan any updates? ---

[GitHub] nifi issue #2671: NiFi-5102 - Adding Processors for MarkLogic DB

2018-09-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2671 @vivekmuniyandi you have a merge conflict now. ---

[GitHub] nifi pull request #2872: NIFI-5318 Implement NiFi test harness: initial comm...

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2872#discussion_r216484785 --- Diff: nifi-testharness/src/main/java/org/apache/nifi/testharness/util/FileUtils.java --- @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request #2872: NIFI-5318 Implement NiFi test harness: initial comm...

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2872#discussion_r216484221 --- Diff: nifi-testharness/pom.xml --- @@ -0,0 +1,176 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001

[GitHub] nifi pull request #2872: NIFI-5318 Implement NiFi test harness: initial comm...

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2872#discussion_r216485286 --- Diff: nifi-testharness/src/test/java/org/apache/nifi/testharness/samples/Constants.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache

[GitHub] nifi issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2956 Did a `mvn dependency:tree` on the bundle and only `neo4j-java-driver` was new for the whole build. Checked it out so we seem to be good on the dependencies being at least compatibly licensed. ---

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2992 [PutCassandraRecord_Test.xml.txt](https://github.com/apache/nifi/files/2367829/PutCassandraRecord_Test.xml.txt) Validated that it works with that simple flow. I was able to use that to

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216070172 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216353686 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216353050 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216354635 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216353534 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216355406 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/pom.xml --- @@ -64,5 +64,20 @@ nifi-ssl-context-service

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216070922 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi pull request #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-10 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2992#discussion_r216069857 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java

[GitHub] nifi issue #2872: NIFI-5318 Implement NiFi test harness: initial commit of n...

2018-09-08 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2872 @peter-gergely-horvath the consensus seems to be just keep pushing new commits and let us do a squashed commit for you because that helps GitHub maintain the context of feedback in a review. ---

[GitHub] nifi issue #2992: NIFI-5510: Introducing PutCassandraRecord processor

2018-09-05 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2992 Been meaning to kick the tires on Cassandra a bit. Would a vanilla Docker image do or is there more setup required to work this? ---

[GitHub] nifi pull request #2993: NIFI-5333 Added GetMongoRecord.

2018-09-05 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2993 NIFI-5333 Added GetMongoRecord. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] nifi issue #2969: NIFI-5495 Made date format configurable.

2018-09-05 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2969 2/3 passed... ---

[GitHub] nifi issue #2969: NIFI-5495 Made date format configurable.

2018-09-05 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2969 @zenfenan Made that change. Seemed reasonable. ---

[GitHub] nifi issue #2896: NIFI-5239 Made a client service an optional source of conn...

2018-09-03 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2896 Thanks, will get to this today unless something comes up! ---

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 Per the discussion on the mailing list, I am moving the code [here](https://github.com/MikeThomsen/nifi-datageneration-bundle) and closing this PR. ---

[GitHub] nifi pull request #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-01 Thread MikeThomsen
Github user MikeThomsen closed the pull request at: https://github.com/apache/nifi/pull/2813 ---

[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2977 Saw @bbende's jira comment: > We should only update Guava dependencies that we directly use in our own code, but not transitive dependencies used by client libraries (i.e. do not

[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2977 @joewitt just checked the license on google/guava and it's still ASL so I think L&N is clear on this. ---

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501508 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-utils/src/main/java/org/apache/nifi/processors/network/parser/Netflowv5Parser.java

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501495 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-utils/src/main/java/org/apache/nifi/processors/network/parser/Netflowv5Parser.java

[GitHub] nifi issue #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2820 @PrashanthVenkatesan you also have a merge conflict. That'll need to be resolved as well. ---

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501822 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501780 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501748 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501765 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501429 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-utils/pom.xml --- @@ -0,0 +1,43 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501717 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501899 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java --- @@ -0,0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501605 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/pom.xml --- @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #2820: NIFI-5327 Adding Netflowv5 protocol parser

2018-08-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2820#discussion_r214501416 --- Diff: nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5

<    1   2   3   4   5   6   7   8   9   10   >