[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166141568 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166111534 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166111208 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r16666 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java --- @@ -152,21

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166111239 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166110849 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166088202 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166079130 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166078811 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r166073173 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r165940928 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java --- @@ -75,6

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2138#discussion_r165941527 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java --- @@ -310,6 +311,15

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-02-05 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2113 @mattyb149 I think all of the change requests are done. ---

[GitHub] nifi issue #1997: NIFI-4164 Adding a realistic time simulator processor to N...

2018-02-04 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/1997 @cherrera2001 Do you have any updates? ---

[GitHub] nifi pull request #2447: NIFI-4836: Allow output of FlowFiles during result ...

2018-02-04 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2447#discussion_r165860112 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #2447: NIFI-4836: Allow output of FlowFiles during result ...

2018-02-04 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2447#discussion_r165436273 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #2448: NIFI-4838 Added configurable progressive commits to...

2018-02-04 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2448 NIFI-4838 Added configurable progressive commits to GetMongo and also… … added attributes that show the progress in the result set that each flowfile represents. Thank you for

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-02-03 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r165812834 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-02-03 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r165812983 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/PutInfluxDB.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-02-03 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r165812819 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/PutInfluxDB.java --- @@ -0,0

[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...

2018-02-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 Ok. Did the merge and both GetMongoTest and RunMongoAggregationTest passed (didn't forget to comment out the @ignore statements...) ---

[GitHub] nifi issue #2432: NIFI-4815 - Add EL support to ExecuteProcess

2018-02-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2432 @markap14 @alopresto @joewitt When I ran this branch it worked fine for me. I think it's OK to sign off for merge. ---

[GitHub] nifi issue #2447: NIFI-4836: Allow output of FlowFiles during result set pro...

2018-02-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2447 I tried out this branch with a table that had about 800k rows (int, varchar(64), timestamp) and it worked smoothly for me. ---

[GitHub] nifi issue #2420: NIFI-4731

2018-02-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2420 It's whack-a-mole. To see many/all of them at once do this from the source root: `mvn clean install -Pcontrib-check :nifi-gcp-processors` (I didn't look closely. I&

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2175 So yeah, +1 on merge. ---

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2175 Ok. I just went back and tried out PutElasticSearchHttp (don't have time to retry the record one right now), and the behavior was as expected. It treats any delete that doesn't result i

[GitHub] nifi issue #2175: NIFI-4410: Improved error handling/logging in PutElasticse...

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2175 @mattyb149 Do you want to keep reviewing this or close it out? ---

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165352409 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi issue #2181: NIFI-4428: - Implement PutDruid Processor and Controller

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2181 @mattyb149 @joewitt PutDruid exists now. Should this PR be closed? ---

[GitHub] nifi issue #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2446 I have a patch that I've been working on for adding support for HBase visibility labels to the existing processors. Might want to think about how to integrate that into this processor. ---

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165304841 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165304629 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165338502 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi pull request #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2446#discussion_r165304550 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java --- @@ -0,0 +1,564

[GitHub] nifi issue #2446: NIFI-4833 Add ScanHBase processor

2018-02-01 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2446 I'll take a stab at reviewing, but you should git cherry pick this onto a git branch and not do it off your master branch. ---

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/1016 @pvillard31 If he doesn't respond, I can take a stab at addressing the feedback so this can be closed out. ---

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165032740 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/pom.xml --- @@ -0,0 +1,35 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi=

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165029171 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165033644 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/test/java/com/apache/nifi/processors/simulator

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165030818 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165031639 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165033904 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/test/java/com/apache/nifi/processors/simulator

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165031839 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165033444 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/scala/com/apache/nifi/processors/simulator/SimController.scala

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165030668 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165030487 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165029401 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-nar/resources/LICENSE --- @@ -0,0 +1,210 @@ + Apache

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165032723 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/pom.xml --- @@ -0,0 +1,35 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi=

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165032832 --- Diff: pom.xml --- @@ -1300,6 +1300,12 @@ 1.4.0-SNAPSHOT nar

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165033604 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/test/java/com/apache/nifi/processors/simulator

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165030357 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165032066 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165031960 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165029951 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/src/main/java/com/apache/nifi/processors/simulator/GenerateTimeSeriesFlowFile.java

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165029448 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-processors/pom.xml --- @@ -0,0 +1,109 @@ + + +http://maven.apache.org/POM

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165029109 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1997: NIFI-4164 Adding a realistic time simulator process...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/1997#discussion_r165029072 --- Diff: nifi-nar-bundles/nifi-simulator-bundle/nifi-simulator-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/1016 @brianburnett You didn't respond to the feedback from @pvillard31. Do you need help getting this pushed through? ---

[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 Any chance we can get this merged? ---

[GitHub] nifi issue #2294: NIFI-3538 Added DeleteHBaseRow

2018-01-31 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2294 @ijokarumawak @bbende The user who posted on nifi-dev asking for a copy of this confirmed that he's using it in production and is happy with it. If you have any time, could you take a quick

[GitHub] nifi issue #2443: NIFI-4827 Added support for reading queries from the flowf...

2018-01-30 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2443 Ok. I just pushed some changes that should fix things with the query location issue. I took your advice on following the SQL approach. Unit tests are there and batter the heck out of it. ---

[GitHub] nifi pull request #2443: NIFI-4827 Added support for reading queries from th...

2018-01-30 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2443#discussion_r164718633 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/test-flows/NIFI_4827.xml --- @@ -0,0 +1,635 @@ + --- End diff

[GitHub] nifi pull request #2443: NIFI-4827 Added support for reading queries from th...

2018-01-30 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2443#discussion_r164711784 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java --- @@ -89,6

[GitHub] nifi pull request #2443: NIFI-4827 Added support for reading queries from th...

2018-01-30 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2443#discussion_r164708858 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/test-flows/NIFI_4827.xml --- @@ -0,0 +1,635 @@ + --- End diff

[GitHub] nifi pull request #2443: NIFI-4827 Added support for reading queries from th...

2018-01-29 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2443#discussion_r164602936 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java --- @@ -89,6

[GitHub] nifi pull request #2443: NIFI-4827 Added support for reading queries from th...

2018-01-29 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2443#discussion_r164602408 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java --- @@ -81,6

[GitHub] nifi pull request #2443: NIFI-4827 Added support for reading queries from th...

2018-01-29 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2443#discussion_r164602170 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/test-flows/NIFI_4827.xml --- @@ -0,0 +1,635 @@ + --- End diff

[GitHub] nifi pull request #2443: NIFI-4827 Added support for reading queries from th...

2018-01-29 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2443 NIFI-4827 Added support for reading queries from the flowfile body to… … GetMongo. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-29 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 @mans2singh LGTM, but we need a committer to sign off now. ---

[GitHub] nifi issue #2441: NIFI-4823 Made pretty printing configurable in GetMongo.

2018-01-29 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2441 @markap14 Thanks for the feedback. I merged them into the commit and also found along the way a bug in how I was handling it. So should be good to go now once the build finishes. ---

[GitHub] nifi pull request #2441: NIFI-4823 Made pretty printing configurable in GetM...

2018-01-29 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2441 NIFI-4823 Made pretty printing configurable in GetMongo. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 Here's a simple test that generates a new write every 3 seconds. [PutInfluxDb_Test.xml.gz](https://github.com/apache/nifi/files/1671417/PutInfluxDb_Test.xml.gz) This is the

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 +1 LGTM. ---

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 Testing it out now. Will let you know if actually using it I observe anything weird. ---

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 @mans2singh This works in the unit test per @mattyb149 's point: ``` runner.assertValid(); runner.setProperty(PutInfluxDB.PASSWORD, ""); runner

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 @mattyb149 That sounds like the validator is being called even when it's not a required property. Is there a good reason for NiFi to do that? ---

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-27 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 @mattyb149 Do you have a recommendation for the validator [to use here]( https://github.com/apache/nifi/pull/2101#issuecomment-361025124)? ---

[GitHub] nifi issue #2432: NIFI-4815 - Add EL support to ExecuteProcess

2018-01-27 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2432 +1 LGTM Ran it, and it worked fine. ---

[GitHub] nifi pull request #2432: NIFI-4815 - Add EL support to ExecuteProcess

2018-01-27 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2432#discussion_r164268334 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java

[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 We should be good to go now. I just checked in a change that addresses the few minor points left over. ---

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 @mans2singh Figured out the issue, it's a time conversion. I added ```:multiply(100)``` to the EL and it worked. InfluxDB uses nanoseconds; I was supplying milliseconds. @jo

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164218451 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 Everything I insert gets defaulted to some time around the epoch. I tried your sample, but it doesn't seem to work for me at least (data gets written, but it doesn't have the a

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164209603 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164209671 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164210261 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/PutInfluxDB.java --- @@ -0,0

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164212464 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITPutInfluxDBTest.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164209408 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164209928 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164208704 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164208755 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164209539 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164212590 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITPutInfluxDBTest.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164210019 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java

[GitHub] nifi pull request #2101: NIFI-4289 - InfluxDB put processor

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2101#discussion_r164212552 --- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/test/java/org/apache/nifi/processors/influxdb/ITPutInfluxDBTest.java

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r164200676 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/GetMongoTest.java --- @@ -135,15

[GitHub] nifi pull request #2180: Added GetMongoAggregation to support running Mongo ...

2018-01-26 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2180#discussion_r164106059 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor

2018-01-25 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 I'm going to try to get some time today and tomorrow to go through the code itself, but I was able to build a flow that uses the line protocol as described, and it successfully inserted mul

[GitHub] nifi issue #2294: NIFI-3538 Added DeleteHBaseRow

2018-01-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2294 That restart.index change is in place. I put a unit test in there that tests it out and it works just fine. ---

[GitHub] nifi issue #2294: NIFI-3538 Added DeleteHBaseRow

2018-01-24 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2294 @mgaido91 That loop, incidentally, is being eliminated now because I decided to follow the same practice that was used in PutHBaseRecord where on failure it adds "restart.index" which

<    7   8   9   10   11   12   13   14   >