Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2150
Looks good to me. The only change I'd recommend is do a squashed commit so
your patch is just one commit.
Not a core committer, but FWIW +1
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2237#discussion_r147990929
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2104
I closed this pull request because I think there is a lot of refactoring
that will be required to make this work.
---
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/2104
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2175
I forgot to mention that when you run into that scenario, it actually sends
the output to Success, which it shouldn't since most of the documents failed to
be deleted.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2175
I found one area that this doesn't handle properly at all, and that's
deleting documents where the ID cannot be found. The reason your patch fails
there is that the check around the d
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2175
I actually had a bad batch go through, and it sent them out properly. What
log settings need to be set in the configuration files to make sure I see your
changes?
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2150#discussion_r146825133
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -439,6
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2150#discussion_r146825541
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -370,6
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2150#discussion_r146825326
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -669,6
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2220
+1 Looks correct.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@joewitt alright, I'll see what trouble I can get into.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2180
@alopresto @milanchandna Can you take a look at the changes when you get a
chance?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@mattyb149 Have you had a chance to take a look at it?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2180
@mattyb149 @markap14 @milanchandna Do any of you have some time to do a
quick look to see if this can get merged?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@mattyb149 Ok. Changes are made. I refactored the commit to be based on a
controller service. For now, that service only handles a single function: basic
search. However, there is now a
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@mattyb149 I'm going to leave this open, but I decided to refactor the heck
out of it around a client service for ElasticSearch. The service only has one
method for now, but I think it'
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143463999
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r143464047
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
I set up a profile called integration-tests and renamed the file to
JsonQueryElasticsearch_IT. It runs really well from the project folder, but for
some reason running `mvn clean install
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
I discovered a slick plugin for Maven that lets you cleanly run
ElasticSearch in the background during integration tests. I added that to the
test setup under a profile. So I have some cleanup to
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
Thanks. I'll get to these some time today or tomorrow.
FYI Elastic has some official statements on the future direction of the
Java client here:
https://www.elastic.co/blog/state-o
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2104
I think Kotlin makes no sense in light of this because it's really not a
scripting language. Focusing on InvokeScriptProcessor would make more sense
because that is where a language like K
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2125
(Go ahead and commit, seems like a good approach to me)
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2125
+1 The string lookup one is going to be interesting.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2104
@mattyb149 I did a sample flow with each of ours and found the performance
to be awful. I did some investigation and experimentation with the Kotlin
ScriptEngine and found that after repeatedly
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2125
@bbende all of the changes you requested were added.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r143060642
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2180
@mattyb149 @markap14 @milanchandna Did some cleanup and rebased against
1.5.0-SNAPSHOT.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r142912872
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r142563421
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongoAggregation.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2180#discussion_r142458671
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2180
Added GetMongoAggregation to support running Mongo aggregations.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2125
@markap14 @mattyb149 Can you take a look when you get a chance?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2123
@markap14 Do you think you could take a look at the updates?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2125
@markap14 All of the changes should now be checked in.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2125#discussion_r138158414
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2123
@markap14 Updated based on your feedback and added the ability to merge
either a single field or the entire Mongo result minus the _id field.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2123
@mattyb149 Ok should be good to go now.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r137559094
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-mongodb-services-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2123#discussion_r137059065
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-mongodb-services-bundle/nifi-mongodb-services-nar/src/main/resources/META-INF/NOTICE
---
@@ -0,0
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2063
@mattyb149 Do you think you'll have a chance to review this this week?
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2125
NIFI-4346 Created a LookupService that uses HBase as its back end.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2123
NIFI-4345 Added a MongoDB controller service and a lookup service.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2063
@mattyb149 Can you take a look? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2113
NIFI-4325 Added new processor that uses the JSON DSL.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2063
@mattyb149 Ok, changes committed and at least the French build ran to
completion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2063#discussion_r134629298
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
---
@@ -151,17
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2063
Thanks for the feedback @mattyb149 . I'll start working on these shortly
(got some other stuff I have to do at the moment).
---
If your project is set up for it, you can reply to this emai
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2063
@mattyb149 @pvillard31 @bbende @joewitt Could one of you take a look at
this and give me some feedback? I can fix the merge conflicts that came up
since I submitted this.
---
If your project is
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2104
NIFI-4307 Added Kotlin 1.1.X support to ExecuteScript.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2063
NIFI-4269 Added the ability to serialize Mongo documents to a clean Jâ¦
â¦SON view instead of just extended JSON.
Thank you for submitting a contribution to Apache NiFi.
In
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1961
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1961
@bbende Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1961#discussion_r130873950
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -0,0 +1,323
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1945
@markap14 @joewitt Any chance of getting this reviewed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1961
@bbende Saw on the mailing list that you've been away for a little while.
Any chance you're back and ready to take a look?
---
If your project is set up for it, you can reply to this
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1945
Yay? Nay?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1945
@bbende @markap14 @pvillard31 Any chance of getting this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1961
@bbende Ok, should be good to go now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1961
@bbende Updated. Let me know what you think when you get a chance. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1961
@bbende I ran this against a large body of our test data, and it seemed to
work just fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1945
@markap14 @bbende @pvillard31 I made the changes. It should be ready for a
merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1945
@markap14 @bbende Everything looks good. Do you want to commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/1961
NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecord
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1948
Thanks @pvillard31. I'll get to these shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1945#discussion_r124553244
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java
---
@@ -0,0
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/1945
@markap14 I'm testing the change locally and will push the commit that
addresses these once I'm satisfied it works.
---
If your project is set up for it, you can reply to this emai
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1945#discussion_r124553265
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/pom.xml ---
@@ -66,5 +74,10 @@
guava
test
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1945#discussion_r124553212
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1945#discussion_r124553180
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java
---
@@ -0,0
GitHub user MikeThomsen reopened a pull request:
https://github.com/apache/nifi/pull/1945
NIFI-4124 Added org.apache.nifi.mongo.PutMongoRecord.
https://issues.apache.org/jira/browse/NIFI-4124
You can merge this pull request into a Git repository by running:
$ git pull https
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/1945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user MikeThomsen reopened a pull request:
https://github.com/apache/nifi/pull/1945
NIFI-4124 Added org.apache.nifi.mongo.PutMongoRecord.
https://issues.apache.org/jira/browse/NIFI-4124
You can merge this pull request into a Git repository by running:
$ git pull https
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/1945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1945#discussion_r124303897
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/pom.xml ---
@@ -48,6 +48,16
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1945#discussion_r124295160
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/pom.xml ---
@@ -48,6 +48,16
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/1945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user MikeThomsen reopened a pull request:
https://github.com/apache/nifi/pull/1945
NIFI-4124 Added org.apache.nifi.mongo.PutMongoRecord.
https://issues.apache.org/jira/browse/NIFI-4124
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/1948
NIFI-4122 Added the ability to combine multiple Mongo result documentâ¦
â¦s into a single output JSON array.
Thank you for submitting a contribution to Apache NiFi.
In order
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/1943
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user MikeThomsen reopened a pull request:
https://github.com/apache/nifi/pull/1945
NIFI-4124 Added org.apache.nifi.mongo.PutMongoRecord.
https://issues.apache.org/jira/browse/NIFI-4124
You can merge this pull request into a Git repository by running:
$ git pull https
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/1945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user MikeThomsen reopened a pull request:
https://github.com/apache/nifi/pull/1943
NIFI-4122 Added the ability to combine multiple Mongo result documentâ¦
https://issues.apache.org/jira/browse/NIFI-4122
You can merge this pull request into a Git repository by running
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/1943
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/1945
NIFI-4124 Added org.apache.nifi.mongo.PutMongoRecord.
https://issues.apache.org/jira/browse/NIFI-4124
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/1943
NIFI-4122 Added the ability to combine multiple Mongo result documentâ¦
https://issues.apache.org/jira/browse/NIFI-4122
You can merge this pull request into a Git repository by running
1301 - 1387 of 1387 matches
Mail list logo