Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r214501669
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r214501991
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r214501922
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java
---
@@ -0,0
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2872
@peter-gergely-horvath can you push that commit?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2896
@zenfenan @mattyb149 can one of you review?
The goal here, btw, is to make it so that admins are able to easily share a
`MongoClient` between multiple processors. Per the
[docs](http
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2969
@zenfenan @mattyb149 can one of you review?
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r214460944
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2861
@mattyb149 Made the requested changes.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2861#discussion_r214358747
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2861#discussion_r214032109
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2915
@zenfenan the consumer one has input forbidden on it, so you won't get
flowfiles there. For the publisher, my guess is it's probably being
conservative about reconfiguring the producers, which
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2973#discussion_r213980541
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2958#discussion_r213977393
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
---
@@ -204,144
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2958#discussion_r213979035
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
---
@@ -204,144
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 can we merge?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2881
@zenfenan @mattyb149 can we close this?
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213375336
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213326155
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r213305700
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2948
If we haven't already, we might want to mark the 0.8 support as
`@Deprecated` so we can end of life it.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r212993976
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r212992888
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r212991535
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBLookupService.java
---
@@ -83,6 +84,7
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2969#discussion_r212960358
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/main/java/org/apache/nifi/mongodb/MongoDBLookupService.java
---
@@ -83,6 +84,7
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2969
NIFI-5495 Made date format configurable.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2820
@joewitt @bbende AFAIK, I have no resources for testing this against a live
Cisco system. What are your thoughts on merging it if everything checks out but
I can't do a live test?
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r210782553
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/pom.xml ---
@@ -0,0 +1,67 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r210782792
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/ParseNetflowv5.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2914#discussion_r210456763
--- Diff:
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2914#discussion_r210378187
--- Diff:
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2881
@zenfenan updated.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
Should be all good to go now.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2807
I'm going to back this out, close the Jira and merge it with my side
project
[nifi-datageneration-bundle](https://github.com/MikeThomsen/nifi-datageneration-bundle).
---
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/2807
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r210070170
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
---
@@ -127,8 +133,113 @@
5.6.8
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2615
@mattyb149 Refactored the query builder.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r209966944
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r209707403
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r209707241
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/groovy/org/apache/nifi/elasticsearch/integration
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r209699519
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r209698134
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
---
@@ -127,8 +133,113 @@
5.6.8
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r209696028
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
---
@@ -127,8 +133,113 @@
5.6.8
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2448
Sure, but you might want to look at the link above your last one as that
touches on the dual ProcessSession you and @markap14 suggested. That turned out
to not be entirely straight-forward, so I
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2914
@zenfenan changed it.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206105937
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -23,11 +23,15 @@ LABEL site="https://nifi.apache.org;
ARG UID=1000
ARG GID=1000
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206106251
--- Diff: nifi-docker/dockerhub/pom.xml ---
@@ -39,7 +39,7 @@
1000
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206106274
--- Diff: nifi-docker/dockerhub/pom.xml ---
@@ -61,7 +61,7
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2905
Go for it. I'm not very knowledgeable on the subject, so I'll defer.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2914
@pvillard31 @zenfenan it's an autoterminating relationship by default and
the default behavior is maintain the status quo.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2914
In case any reviewer comes along and wonders why it wouldn't be simpler to
just control the EL logic and input data better, the reason why is that the
folks in our company who reported this error
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2914
NIFI-5448 Added failure relationship to UpdateAttributes to handle baâ¦
â¦d expression language logic.
Thank you for submitting a contribution to Apache NiFi.
In order
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2905
@pepov can you share some examples of how to test this?
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2906
NIFI-5440 Added db and collection attributes to GetMongo output.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2890
(Will merge if it works against an ES6 docker image)
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2896
NIFI-5239 Made a client service an optional source of connection poolâ¦
â¦ing in Mongo processors.
NIFI-5239 Updated two driver versions.
Thank you for submitting
Github user MikeThomsen closed the pull request at:
https://github.com/apache/nifi/pull/2893
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2893
Thanks. Ill redo this then..
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2891
@ottobackwards I decided to go back and force validation of the results
after the EL is evaluated.
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2895
NIFI-5412 Added additional documentation for PutMongo.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2893
[Mongo_client_test.xml.txt](https://github.com/apache/nifi/files/2196064/Mongo_client_test.xml.txt)
That is a flow for testing the functionality against a Mongo server running
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2893
NIFI-5329 Made a client service an optional source of connection poolâ¦
â¦ing in Mongo processors.
Thank you for submitting a contribution to Apache NiFi.
In order
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2891
NP.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2891
@mattyb149 can you review? It's a pretty small commit for what appears to
be a false positive on a bug.
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2891
NIFI-5305 Added a unit test to check for the behavior described in thâ¦
â¦e bug report because it was not being explicitly checked before.
Thank you for submitting a contribution
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2881
NIFI-5413 Added additional documentation for PutMongoRecord and fixedâ¦
⦠a typo in RunMongoAggregation's documentation.
Thank you for submitting a contribution to Apache NiFi
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2880
NIFI-5410 Added additional documentation for GetMongo.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2877
2/3 passed.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2877
> It shouldn't be strictly coupled to the ES version, but they obviously
could introduce breaking changes, as they could for the existing ES processors.
AIUI the next major version sho
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2879
NIFI-5409 Added additional documentation for DeleteMongo.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2743
@timhallinflux not at the moment. It's a huge commit, and I've been too
busy to get into it.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2856
@ottobackwards I've thought something similar. We could build a big JSON
file or folder of JSON files that have the standard verbiage per dependency and
then cause a build error if it finds
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2448
@mattyb149 there you go.
Also, I started applying the two session approach
[here](https://github.com/MikeThomsen/nifi/tree/split-proc), but I'm not sure
about my approach because I had
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2864#discussion_r201056631
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/resources/docs
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2865
NIFI-5390 Added more documentation for DeleteByQueryElasticsearch.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2864
NIFI-5389 Added additional documentation for JsonQueryElasticsearch.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2780
> (it won't be on the test classpath if you're using JUnit 5)
The global declaration for JUnit is JUnit 4.12. If someone
> It should be "compile" scope, b
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2862
NIFI-5391 Removed two unused dependencies from nifi-elasticsearch-resâ¦
â¦tapi-processors.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2861
NIFI-5248 Added new Elasticsearch json and record processors.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi-registry/pull/129
@apiri rebased and pushed.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2854#discussion_r200815742
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java
---
@@ -196,4 +187,53
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2854#discussion_r200815662
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java
---
@@ -196,4 +187,53
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2849
[Session_Test.xml.txt](https://github.com/apache/nifi/files/2172744/Session_Test.xml.txt)
Test flow I used.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2856
@joewitt nifi-redis-nar was right AFAICT.
The way I'm looking for implicated jars is `mvn dependency:tree | grep
compile`. I am skipping ones that aren't scoped to compile.
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2856
NIFI-4811 Added two missing entries to the nifi-redis-service-api-narâ¦
⦠NOTICE file.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
@joewitt IntelliJ reported 4 hits on `${projection.version}`. Is
that worth a new Jira ticket to harmonize?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
Done.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
Do we have anything you can think of that isn't set to the current version?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2848
Ok. Everything checked out as far as I saw when I tried it, but I'll revert
it.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200798916
--- Diff: nifi-test/pom.xml ---
@@ -0,0 +1,145 @@
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-ins
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2843#discussion_r200798895
--- Diff: nifi-test/pom.xml ---
@@ -0,0 +1,145 @@
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-ins
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2782
@zenfenan can you review? It's mostly copy pasta from the ES v5 client.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2813#discussion_r200323522
--- Diff:
nifi-nar-bundles/nifi-data-generation-bundle/nifi-data-generation-processors/src/main/java/org/apache/nifi/processors/generation
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2813#discussion_r200322961
--- Diff:
nifi-nar-bundles/nifi-data-generation-bundle/nifi-data-generation-processors/src/main/java/org/apache/nifi/processors/generation
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2843
You can ping me when you're ready.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2843
@peter-gergely-horvath looks like you have a stylecheck failure. Did you
build the maven module(s) you added using `mvn clean install -Pcontrib-check`?
Looks like you have at least a few files
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2843
@peter-gergely-horvath @joewitt I can start reviewing this, but would like
verification from both of you that the IP issues y'all talked about on dev are
sufficiently squared away before I begin.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2815
@pvillard31 @zenfenan left me a note saying he's traveling with limited
access right now, so I might do the rebasing and merging today myself.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2828
@pvillard31
> Out of curiosity, any reason why to use bitnami/zookeeper?
Probably copy pasta from a previous docker compose file.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2828
@pvillard31 done.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2813#discussion_r199637841
--- Diff:
nifi-nar-bundles/nifi-data-generation-bundle/nifi-data-generation-processors/src/main/java/org/apache/nifi/processors/generation
201 - 300 of 1373 matches
Mail list logo
