[GitHub] nifi pull request #2813: NIFI-5084 Added GenerateRecord processor.

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2813#discussion_r199637841 --- Diff: nifi-nar-bundles/nifi-data-generation-bundle/nifi-data-generation-processors/src/main/java/org/apache/nifi/processors/generation

[GitHub] nifi pull request #2813: NIFI-5084 Added GenerateRecord processor.

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2813#discussion_r199637157 --- Diff: nifi-nar-bundles/nifi-data-generation-bundle/nifi-data-generation-processors/src/main/java/org/apache/nifi/processors/generation

[GitHub] nifi pull request #2813: NIFI-5084 Added GenerateRecord processor.

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2813#discussion_r199636926 --- Diff: nifi-nar-bundles/nifi-data-generation-bundle/nifi-data-generation-processors/src/main/java/org/apache/nifi/processors/generation

[GitHub] nifi issue #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2802 @alopresto for future reference, if a commit has to be reversed (hopefully for not this reason), would adding `This opens #ABCD` to the revert commit message have the effect of reopening it

[GitHub] nifi issue #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2802 Jira reopened and commit reverted. @ottobackwards can you reopen? ---

[GitHub] nifi issue #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2802 @alopresto no problem. Sorry if it cause any inconvenience. Ticket seemed straight forward to me, but I'll let you take your time with it. ---

[GitHub] nifi pull request #2619: NIFI-5059 Updated MongoDBLookupService to be able t...

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2619#discussion_r199602436 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/test/java/org/apache/nifi/mongodb/TestSchemaRegistry.java --- @@ -0,0 +1,49

[GitHub] nifi issue #2619: NIFI-5059 Updated MongoDBLookupService to be able to detec...

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2619 @mattyb149 made the changes you requested. ---

[GitHub] nifi pull request #2619: NIFI-5059 Updated MongoDBLookupService to be able t...

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2619#discussion_r199600826 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/serialization

[GitHub] nifi pull request #2619: NIFI-5059 Updated MongoDBLookupService to be able t...

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2619#discussion_r199597348 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java

[GitHub] nifi pull request #2828: NIFI-5195 Added clustering to the docker image

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2828#discussion_r199498859 --- Diff: nifi-docker/dockerhub/sh/update_cluster_state_management.sh --- @@ -0,0 +1,31 @@ +#!/bin/sh -e + +#Licensed to the Apache

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r199447258 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi pull request #2828: NIFI-5195 Added clustering to the docker image

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2828#discussion_r19944 --- Diff: nifi-docker/dockermaven/sh/start.sh --- @@ -26,6 +26,18 @@ prop_replace 'nifi.remote.input.host' "${NIFI_REMOTE_IN

[GitHub] nifi pull request #2828: NIFI-5195 Added clustering to the docker image

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2828#discussion_r199445234 --- Diff: nifi-docker/dockermaven/sh/start.sh --- @@ -26,6 +26,18 @@ prop_replace 'nifi.remote.input.host' "${NIFI_REMOTE_IN

[GitHub] nifi issue #2829: NIFI-5359 Exposed variable registry to docker image.

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2829 @apiri Can you review? It's only 3 lines of changes. ---

[GitHub] nifi pull request #2829: NIFI-5359 Exposed variable registry to docker image...

2018-07-02 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2829 NIFI-5359 Exposed variable registry to docker image. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] nifi issue #2828: NIFI-5195 Added clustering to the docker image

2018-07-02 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2828 @dkhwangbo we can set up a new ticket for adding that. ---

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r199346844 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r199346966 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCalculateAttributeHash.java

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r199346929 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r199346768 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-07-01 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r199346716 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi issue #2619: NIFI-5059 Updated MongoDBLookupService to be able to detec...

2018-06-30 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2619 @zenfenan can you review? I think we're almost at close out point. ---

[GitHub] nifi issue #2828: NIFI-5195 Added clustering to the docker image

2018-06-29 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2828 @apiri can you review? ---

[GitHub] nifi pull request #2828: NIFI-5195 Added clustering to the docker image

2018-06-29 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2828 NIFI-5195 Added clustering to the docker image Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi-registry issue #129: NIFIREG-181 Updated registry docker build to make ...

2018-06-29 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/129 @apiri This too. ---

[GitHub] nifi-registry pull request #129: NIFIREG-181 Updated registry docker build t...

2018-06-29 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi-registry/pull/129 NIFIREG-181 Updated registry docker build to make flow provider confi… …gurable. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...

2018-06-29 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/128 @apiri updated. Let me know what you think. ---

[GitHub] nifi-registry issue #128: NIFIREG-180 Added db configuration properties to t...

2018-06-29 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi-registry/pull/128 @apiri Can you review? Once this is done, I'd like to move onto adding support for the GitFlow adapter. ---

[GitHub] nifi-registry pull request #128: NIFIREG-180 Added db configuration properti...

2018-06-29 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi-registry/pull/128 NIFIREG-180 Added db configuration properties to the docker image. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MikeThomsen/nifi

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 @ottobackwards 1. I wanted to keep it simple. You can't really wire up the writer without going through most of that, and I wanted to have a simple configuration option for just du

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-26 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 @joewitt so here's a thought... do you think it would be feasible to write a deployment process that pushes the extra nars (ex atlas, hive3 and this) to our GitHub repo's "release

[GitHub] nifi issue #2619: NIFI-5059 Updated MongoDBLookupService to be able to detec...

2018-06-26 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2619 @mattyb149 can we close the loop on this? ---

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-26 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 As mentioned in the docs, the Confluent lib that I use for this uses extensions to Avro syntax to define the rules. ---

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-26 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 @zenfenan can you review? ---

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-25 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2813 @joewitt can you review the L&N? I added the new stuff, but wasn't sure if the existing dependencies that are covered elsewhere (Ex. Jackson and Bouncy Castle) had to also get added t

[GitHub] nifi pull request #2813: NIFI-5084 Added GenerateRecord processor.

2018-06-25 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2813 NIFI-5084 Added GenerateRecord processor. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #2702: Added Apache Pulsar processors

2018-06-21 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2702 That's correct. I would recommend you build a custom bundle and deliver that because you can deliver NARs independent of the release. Then any bug fixes you find along the way can be merged

[GitHub] nifi issue #2702: Added Apache Pulsar processors

2018-06-21 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2702 Nothing left for you at the moment. I keep getting side tracked with real work requirements. It's a big commit, so we'll need a lot of review. @alopresto @markap14 @bbende @ij

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-06-21 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 It's worth looking at. It also provides a good entry point to start working on that GetMongoRecord processor that was requested today. Right now, the refactoring of the Mongo co

[GitHub] nifi pull request #2807: NIFI-5326 Wrote RandomLookupService.

2018-06-21 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2807 NIFI-5326 Wrote RandomLookupService. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-06-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 I have a ticket open to transition everything in the Mongo space over to making a client service the source of configurations and connection pooling for Mongo. So the short term solution would be

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-06-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 With your second option, if you don't transfer the original input before you call `session.commit()` it will throw an exception because the original input will not be assigned to a relatio

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-06-20 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 @mattyb149 here's the use case that lead to this for the sake of discussion: > Client has a few huge collections. Client wants to be able to fetch very large chunks of them a

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-06-19 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r196439507 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi issue #2619: NIFI-5059 Updated MongoDBLookupService to be able to detec...

2018-06-19 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2619 @mattyb149 @ijokarumawak do either of you have time to get this reviewed before 1.7.0 release vote starts? ---

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-06-19 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 @mattyb149 @pvillard31 any chance one of you could re-review this today? ---

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-06-19 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r196402323 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi issue #2749: NIFI-5145 Fixed evaluateAttributeExpressions in mockproper...

2018-06-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2749 @mattyb149 Regarding your question about what is blocked by this PR, there are some integration tests in the Mongo package that break without this because the Mongo processors have optional input

[GitHub] nifi issue #2749: NIFI-5145 Fixed evaluateAttributeExpressions in mockproper...

2018-06-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2749 @mattyb149 @alopresto I backed out the FTP-related changes and put a temporary fix in there that handles the edge case that was impacting the FTP processors. There are two cases that cause

[GitHub] nifi issue #2793: NIFI-5309 update the logger message to get the output form...

2018-06-15 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2793 You won't see any sign that it's been merged in your repo until you pull the latest master branch from apache/nifi on GitHub. You can see your commit in master [here](https://github.

[GitHub] nifi pull request #2736: NIFI-5223 Allow the usage of expression language fo...

2018-06-14 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2736#discussion_r195584322 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-service-api/src/main/java/org/apache/nifi/serialization

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @markap14 I cleaned it up and got most of what I suggested done. Couldn't figure out a good way to detect the protocol ranges, but this should do. ---

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-06-14 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ijokarumawak Added a new commit that should get it to close out. ---

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ijokarumawak I accidentally squashed the changes that @markap14 requested into your commit. ---

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r195273615 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r195272720 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r195272595 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r195272389 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2777: NIFI-5287 Made LookupRecord able to take in flowfil...

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2777#discussion_r19527 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-service-api/src/main/java/org/apache/nifi/lookup/LookupService.java --- @@ -35,6 +35,19

[GitHub] nifi pull request #2777: NIFI-5287 Made LookupRecord able to take in flowfil...

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2777#discussion_r195270966 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java

[GitHub] nifi pull request #2777: NIFI-5287 Made LookupRecord able to take in flowfil...

2018-06-13 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2777#discussion_r195270892 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLookupRecord.java

[GitHub] nifi issue #2749: NIFI-5145 Fixed evaluateAttributeExpressions in mockproper...

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2749 @mattyb149 can we close this out? ---

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2777 @markap14 @ijokarumawak cleaned it up by removing that attribute and it's rebased against master (as of my last pull this morning). Can one of you review? ---

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @markap14 Ok, that's fair. I think the general issue has to be addressed, but the easy route is obviously blocked. So what I'm going to do to try to head this is off is: 1. R

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ijokarumawak fixed AWS bundle and 2/3 Travis builds succeeded. ---

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2777 @ottobackwards I think that's overkill because a Map is fine for the main variables and a Map also works for passing EL output. A major advantage of using two maps is that the "conte

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ijokarumawak the AWS gateway tests are broken because I moved test server. I'll do a patch for that. ---

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 @ijokarumawak merged your PR. You can merge at any time. ---

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2777 @ijokarumawak > Adding those values into lookup coordinate may not sound that wrong, if we keep the consistent overlaying order. It is, however, dangerous to do w

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-06-12 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r194695221 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r194575701 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r194575528 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r194575493 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r194576777 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #2718: NIFI-5213: Allow AvroReader to process files w embe...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2718#discussion_r194572498 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 @markap14 can you review? @joewitt can you review the L&N? I took a stab at updating the v6 client's NOTICE, but am not sure if it's right. ---

[GitHub] nifi issue #2782: NIFI-5292 Renamed ElasticSearch client service impl to sho...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2782 Looked over the transitive dependencies and HdrHistogram ([license info; appears public domain](https://github.com/HdrHistogram/HdrHistogram/blob/master/LICENSE.txt)) and SnakeYaml (ASL, unknown

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-11 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2777 @markap14 @ijokarumawak updated based on the last comment. ---

[GitHub] nifi pull request #2782: NIFI-5292 Renamed ElasticSearch client service impl...

2018-06-11 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2782 NIFI-5292 Renamed ElasticSearch client service impl to show it is for… … 5x. NIFI-5292 Added 6.X ES Client. Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #2778: NIFI-5288 Quietly convert Java arrays to Lists so the Mong...

2018-06-10 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2778 @mattyb149 I think everything you want is here now. ---

[GitHub] nifi pull request #2778: NIFI-5288 Quietly convert Java arrays to Lists so t...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2778#discussion_r194242476 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java

[GitHub] nifi pull request #2778: NIFI-5288 Quietly convert Java arrays to Lists so t...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2778#discussion_r194242453 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java

[GitHub] nifi pull request #2778: NIFI-5288 Quietly convert Java arrays to Lists so t...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2778#discussion_r194241805 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoRecordIT.java

[GitHub] nifi pull request #2778: NIFI-5288 Quietly convert Java arrays to Lists so t...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2778#discussion_r194241786 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java

[GitHub] nifi pull request #2778: NIFI-5288 Quietly convert Java arrays to Lists so t...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2778#discussion_r194241017 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java

[GitHub] nifi issue #2778: NIFI-5288 Quietly convert Java arrays to Lists so the Mong...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2778 Because 5145, the integration tests might not completely run if run as a suite. I have verified that PutMongoRecordIT is not affected by 5145 and can be run by itself with a Docker image of Mongo

[GitHub] nifi pull request #2778: NIFI-5288 Quietly convert Java arrays to Lists so t...

2018-06-09 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2778 NIFI-5288 Quietly convert Java arrays to Lists so the MongoDB API can… … handle them. Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi pull request #2776: NIFI-5284: Added JSON_TYPE support to RunMongoAggre...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2776#discussion_r194235387 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2777 @ijokarumawak Review? ---

[GitHub] nifi pull request #2777: NIFI-5287 Made LookupRecord able to take in flowfil...

2018-06-09 Thread MikeThomsen
GitHub user MikeThomsen opened a pull request: https://github.com/apache/nifi/pull/2777 NIFI-5287 Made LookupRecord able to take in flowfile attributes and c… …ombine them with lookup keys. Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2723 Other than the issue w/ literals you cited, looks ready to merge IMO. ---

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r194224970 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r194224226 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r194224162 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r194224132 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/resources/docs/org.apache.nifi.processors.standard.RecordStats

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r194223936 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r194223780 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r194223770 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-06-09 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r194223753 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java --- @@ -0,0

<    1   2   3   4   5   6   7   8   9   10   >