[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-03-08 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/1450 @ijokarumawak @mattyb149 We could add example how to use String JDBC to wiki. No need to be part of NiFi codebase. --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-04 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/1450 Hi @ijokarumawak I have something like this already in use. This was meant to be temporary solution until “right” implementation is available. Now I am little bit confused

[GitHub] nifi pull request #1417: NIFI-3339 Add getDataSource() to DBCPService.

2017-02-03 Thread ToivoAdams
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/1417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #1450: NIFI-3339b Add getDataSource() to DBCPService, seco...

2017-01-29 Thread ToivoAdams
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/1450 NIFI-3339b Add getDataSource() to DBCPService, second version Thank you for submitting a contribution to Apache NiFi. ### Note: Please ensure that once the PR is submitted, you check

[GitHub] nifi pull request #1417: NIFI-3339 Add getDataSource() to DBCPService.

2017-01-14 Thread ToivoAdams
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/1417 NIFI-3339 Add getDataSource() to DBCPService. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #984: Nifi 2624

2016-10-16 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/984 I created new pull request #1142 Could not reopen this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro...

2016-10-16 Thread ToivoAdams
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/1142 NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logical type usin… Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we

[GitHub] nifi issue #984: Nifi 2624

2016-10-08 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/984 @trixpan I did rebase, resolved conflicts. Git refused to push. So I used force push. toivo@Optx:~/git/nifi$ git push origin -f nifi-2624 Counting objects: 2712, done. Delta

[GitHub] nifi pull request #984: Nifi 2624

2016-10-08 Thread ToivoAdams
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #388: nifi-1214b Mock Framework should allow order-indepen...

2016-09-21 Thread ToivoAdams
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #803: nifi-1214c Mock Framework should allow order-indepen...

2016-09-21 Thread ToivoAdams
Github user ToivoAdams closed the pull request at: https://github.com/apache/nifi/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #803: nifi-1214c Mock Framework should allow order-independent as...

2016-09-20 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/803 New PR #1033 I did rebase as usual. But git refused to push and recommended pull before push. I did pull but it seems I should force push instead of pull. Thanks Toivo

[GitHub] nifi pull request #1033: nifi-1214d Mock Framework …on FlowFiles. This rep...

2016-09-20 Thread ToivoAdams
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/1033 nifi-1214d Mock Framework …on FlowFiles. This replaces previous nifi-1214c New Pull Request, replaces previous #803 You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi issue #986: Nifi 2381

2016-09-18 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/986 Hi @pvillard31 I did changes. Thank you for reviewing. Toivo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi issue #803: nifi-1214c Mock Framework should allow order-independent as...

2016-09-17 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/803 Git complained and I did what he recommend (git pull origin). It seems this was mistake. I will create another clean PR. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #803: nifi-1214c Mock Framework should allow order-indepen...

2016-09-16 Thread ToivoAdams
Github user ToivoAdams commented on a diff in the pull request: https://github.com/apache/nifi/pull/803#discussion_r79117053 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockFlowFile.java --- @@ -290,4 +291,18 @@ public long getLineageStartIndex() { public long

[GitHub] nifi pull request #986: Nifi 2381

2016-09-04 Thread ToivoAdams
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/986 Nifi 2381 Connection Pooling Service -Drop invalid connections and create new ones done. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request #984: Nifi 2624

2016-09-03 Thread ToivoAdams
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/984 Nifi 2624 JDBC-to-Avro processors handle BigDecimals as Strings. JdbcCommon treats BigDecimals now as Avro Logical type using bytes to hold data (not String as is was before). You can merge

[GitHub] nifi pull request #803: nifi-1214c Mock Framework should allow order-indepen...

2016-08-06 Thread ToivoAdams
GitHub user ToivoAdams opened a pull request: https://github.com/apache/nifi/pull/803 nifi-1214c Mock Framework should allow order-independent assumptions … …on FlowFiles. This replaces previous nifi-121b You can merge this pull request into a Git repository by running

[GitHub] nifi issue #388: nifi-1214b Mock Framework should allow order-independent as...

2016-07-23 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/388 I hope conflicts are now resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled