Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/2970
@pepov I took that lookup out. It appeared to be completely unnecessary.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/2970
@pepov is the second lookup you're referring to this line?
```java
Group nodeGroup =
userGroupProvider.getGroup(nodeGroupIdentifier);
```
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/2970
The group id lookup logic was running even if group name was not specified.
Fixed that. All tests are passing locally.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/2970
@kevdoran @pepov it's now looking up group ID from the given name. Unit
test updated to reflect such, and docs updated to reflect the new property.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/2970
@pepov @kevdoran thanks for the feedback. I'll update the docs to reflect
the property change, and update the code to reflect that the group name is
provided and look up the group identifier
Github user achristianson commented on the issue:
https://github.com/apache/nifi/pull/2970
@pepov @mcgilman new PR where we authorize the node group rather than its
users. Please take a look when you get a chance.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi/pull/2970
NIFI-5542 Added support for node groups to FileAccessPolicyProvider
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user achristianson closed the pull request at:
https://github.com/apache/nifi/pull/2965
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2965#discussion_r212977830
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi/pull/2965
NIFI-5542 Added support for node groups to FileAccessPolicyProvider
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@apiri This was merged on the basis of "I'll provide an implicit agreement
to move forward." MINIFICPP-577 has been created to refactor the Property
constructor
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/371
Added snap build instructions. Will merge unless there are any further
objections.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/350
Rebased & all issues addressed. Ready for review.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@phrocker Please elaborate what exactly your issues are. As you can see
from 20 days ago, all concerns were addressed to the best of my knowledge.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/380
MINIFICPP-574 Include required cstring library
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we
Github user achristianson closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/379
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/379
Minificpp 574
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/374
Fixed.
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/374#discussion_r204400344
--- Diff: CMakeLists.txt ---
@@ -165,6 +165,56 @@ else()
set(UUID_LIBRARIES "uuid")
endif()
+if(NOT USE_S
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/375
@phrocker I agree. Since this would affect all the external project builds,
I created MINIFICPP-570 to move all external builds out to their own space(s)
consistently.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/377
MINIFICPP-555 Pass through CMAKE args to external projects so that exâ¦
â¦ternal builds are consistent with main build
Thank you for submitting a contribution to Apache
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/376
MINIFICPP-562 Fixed thirdparty/uuid include path
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/375
MINIFICPP-561 Added internal/static build of bzip2
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/374
MINIFICPP-559 Move cURL external build up to fix dependency resolution
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/371
@jdye64 if you can, please send me the instructions you gave @phrocker. I
can add those to the build instructions and update this PR.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/371
@phrocker The official snap docs recommend building using Ubuntu 16.04.
Other environments might not work.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/371
MINIFICPP-556 Added initial snapcraft build
This wouldn't have been possible without the help of Jeremy Dyer.
In order to streamline the review of the contribution we ask you
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/370
MINIFICPP-459 Added build-time caveat for flex regarding accessibilitâ¦
â¦y and compatibility of FlexLexer.h
Thank you for submitting a contribution to Apache NiFi - MiNiFi
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/369
MINIFICPP-483 Added compile-time bustache caveats
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/350
Build fails are timeouts after 52/53 passed unit tests; suspect possible
travis environmental issue.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
Fixed.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
Looks like some conflict(s) cropped up. Taking a look.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/350
Fixed.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/359
Fixed.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/359
@phrocker I read through the blog post.
The high level objective of this PR is to achieve the "copy free" state.
The push_back( T&& value
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/359
MINIFICPP-515 Use emplace_back instead of push_back
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/358
MINIFICPP-533 Fixed signed/unsigned integer comparison mismatch
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/357
MINIFICPP-534 Added EL support to ExecuteProcess
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/356
MINIFICPP-536 Added EL support to GetFile
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/355
MINIFICPP-535 Add support for nonexistent flow_file provided as paramâ¦
⦠to an Expression
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192156058
--- Diff: extensions/sensors/CMakeLists.txt ---
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155481
--- Diff: extensions/sensors/SensorLoader.cpp ---
@@ -0,0 +1,30 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155217
--- Diff: extensions/sensors/GetMovementSensors.cpp ---
@@ -0,0 +1,109 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192154943
--- Diff: extensions/sensors/GetMovementSensors.cpp ---
@@ -0,0 +1,109 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192154395
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153880
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153700
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153282
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/350
Minificpp 465
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/349
Minificpp 467
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
Build fail looks unrelated.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/342
Fixed.
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/347#discussion_r191844258
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -65,7 +65,13 @@ core::Property InvokeHTTP::FollowRedirects("Follow
Redi
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/347#discussion_r191843838
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -65,7 +65,13 @@ core::Property InvokeHTTP::FollowRedirects("Follow
Redi
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/347
MINIFIPP-514 Incorporated regex peroperty validation information into agent
manifest
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486780
--- Diff: libminifi/src/controllers/NetworkPrioritizerService.cpp ---
@@ -65,33 +65,38 @@ void NetworkPrioritizerService::yield
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486723
--- Diff: libminifi/src/controllers/NetworkPrioritizerService.cpp ---
@@ -65,33 +65,38 @@ void NetworkPrioritizerService::yield
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486681
--- Diff: libminifi/src/controllers/NetworkPrioritizerService.cpp ---
@@ -65,33 +65,38 @@ void NetworkPrioritizerService::yield
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486381
--- Diff: libminifi/include/io/NetworkPrioritizer.h ---
@@ -86,10 +92,15 @@ class NetworkInterface {
friend class NetworkPrioritizer
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/344
MINIFICPP-511 Fix "controllserServices" AgentInformation key
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/343
MINIFICPP-510 Fix log level when notifying of usage of default values
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/341
Minificpp 507
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/340
MINIFICPP-500 Incorporate mutually-exclusive property metadata into aâ¦
â¦gent information
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
Travis fail seems to be unrelated (segfault in C2 components).
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/338
Minificpp 508
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
Rebased.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
The general build covers an older/LTS Ubuntu which is more conservative.
This way we cover old as well as new compilers.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
This is ready for review. The build fails due to MINIFICPP-503. The custom
script is because we're building in docker (make docker). The reason for this
additional build is outlined
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/337
Should this be an extension? it seems like a fairly specific use case that
we might want to leave out of the compilation in many cases.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/336
MINIFICPP-498 Test newer compiler (gcc >= 6) (and also test build of â¦
â¦Docker image) in travis
Thank you for submitting a contribution to Apache NiFi - MiNiF
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/335
MINIFICPP-503 Fix docker sync excludes to fix missing Parser.yy buildâ¦
⦠error
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/333#discussion_r189914896
--- Diff: libminifi/src/processors/PutFile.cpp ---
@@ -51,7 +51,9 @@ core::Property PutFile::CreateDirs(
"Create Missing Direct
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/334
Fixed the linter issue.
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189913737
--- Diff: libminifi/include/core/Property.h ---
@@ -56,10 +56,15 @@ class Property {
/*!
* Create a new property
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/333
Fixed the name/value redundancy.
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/333#discussion_r189911483
--- Diff: libminifi/include/core/state/nodes/AgentInformation.h ---
@@ -297,9 +297,20 @@ class ComponentManifest : public DeviceInformation
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/333#discussion_r189911362
--- Diff: libminifi/src/processors/PutFile.cpp ---
@@ -51,7 +51,9 @@ core::Property PutFile::CreateDirs(
"Create Missing Direct
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334
Minificpp 502
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/333
MINIFICPP-501 Incorporate dependent property metadata into agent infoâ¦
â¦rmation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/315
@apiri I think that might be more of a container issue vs. a build issue.
The date lib interacts with the system zoneinfo db, so I think trouble with
that is why it is raising
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/315
@apiri done.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/332
MINIFICPP-499 Incorporate property required validation metadata into â¦
â¦agent manifest
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/325
@phrocker fixed travis & rebased. Did you see anything else?
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/315
@apiri looks like travis issue is fixed. Did you see any other issues?
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/315
@apiri Confirmed compiler version issue, from Howard Hinnant, author of
date:
"I'm not positive to tell you the truth, but based on this bug report:
https://gcc.gn
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/315
Ah, seems to be in the 3rd party date lib. We might need to disable these
date fns when an old compiler is in use (similar to how we disable regex).
The lib should support C
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/329
MINIFICPP-476 Added support for literal true/false values
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/328
@phrocker Also rm -rf thirdparty/flex. It might have some junk from another
PR that is no longer in git.
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/328
@phrocker
Try deleting the following generated files & trying again:
/extensions/expression-language/Parser.*
/extensions/expression-language/Scanner
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/315
Taking a look.
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/328
MINIFICPP-474 Added getDelimitedField EL function
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/325
MINIFICPP-369 Added multiple attribute/aggregate EL functions
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/322
MINIFICPP-484 Updated sol2 to 2.20.0
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/311
Agreed that should be documented. I created MINIFICPP-483 to do the
build-time instructions. This ticket is for ApplyTemplate usage docs, which at
the processor level is distinct from
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r186519113
--- Diff: extensions/expression-language/base64.h ---
@@ -0,0 +1,188
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/320
MINIFICPP-392 Switched to black list for copying src tree to avoid miâ¦
â¦ssing newly-added dirs
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user achristianson closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/301
---
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/301
Going to close this PR as invalid. FlexLexer.h appears to be incompatible
between common versions. Flex/bison are build requirements when EL code is
generated. This ticket made
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/318
MINIFICPP-475 Added support for preferred frame width/height to GetUSâ¦
â¦BCamera properties
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/317
MINIFICPP-478 Added missing date manipulation heading/intro docs
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
1 - 100 of 402 matches
Mail list logo
